Split bill - Split bill preview briefly shows participant name and date

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.5.3 Reproducible in staging?: y Reproducible in production?: n If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Go to the group chat.
3. Click + > Split bill.
4. Create a bill split.

Expected Result:

The split bill preview will now show participant name and date.

Actual Result:

he split bill preview shows participant name and date briefly.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [x] Android: Native
• [x] Android: mWeb Chrome
• [ ] iOS: Native
• [x] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [x] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/93399543/000e1ad8-9662-456c-9a2f-cad3336e1b2c

View all open jobs on GitHub

[github-actions[bot]]

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot[bot]]

Triggered auto assignment to @pecanoro (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[ZhenjaHorbach]

I think the problem is related to this PR https://github.com/Expensify/App/pull/31604

[dukenv0307]

In issue #30680 we decided to show merchant field for split bill, and now we are hard-coded merchant in optimistic data. And I think this will be fixed in this PR https://github.com/Expensify/App/pull/30721

[aimane-chnaif]

In issue #30680 we decided to show merchant field for split bill, and now we are hard-coded merchant in optimistic data. And I think this will be fixed in this PR #30721

I thought preview part would be completely fixed in https://github.com/Expensify/App/issues/30680. If not, why did not put the issue on hold for https://github.com/Expensify/App/pull/30721 despite my hold suggestion here?

[aimane-chnaif]

I suggest to revert https://github.com/Expensify/App/pull/31604 since fixing one bug caused another bug which is same (or more) critical level.

[pecanoro]

Let's revert the PR yeah, it needs a much better fix.

[dukenv0307]

@aimane-chnaif @pecanoro To fix this issue we only need to replace the line to iou.merchant.

https://github.com/Expensify/App/blob/a0b219711080751d6826bb2330ddd85c1641d7bf/src/libs/actions/IOU.js#L939

[pecanoro]

Hmm, ok, if I assign you the issue, can you fix it in the next hour or so? Otherwise, I will have to revert

[dukenv0307]

@pecanoro Sure please assign me.

[pecanoro]

@aimane-chnaif Do you want to be the reviewer?

[aimane-chnaif]

yes

[dukenv0307]

@aimane-chnaif The PR is ready for review.

[pecanoro]

Revert has been deployed and tested, removing deploy blocker label!

[melvin-bot[bot]]

@pecanoro, @aimane-chnaif, @dukenv0307 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[pecanoro]

I have no clue why the automation didn't work. Anyhow, we don't have to pay @dukenv0307 because it was a regression but we do have to pay @aimane-chnaif since he wasn't the original reviewer. I will create a separate issue for that.

[pecanoro]

We have to wait a few days for the regression anyways and I will create it.

[pecanoro]

I might be OOO so I am going to create it now.

[pecanoro]

Created here: https://github.com/Expensify/App/issues/32677