Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.5k stars 2.85k forks source link

HelpDot - Clicking `Expensify Classic` brings you to main homepage instead of Expensify Classic category homepage #32579

Closed maddylewis closed 9 months ago

maddylewis commented 10 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers): N/A Logs: N/A Expensify/Expensify Issue URL: https://github.com/Expensify/Expensify/issues/337748 Issue reported by: @maddylewis Slack conversation: N/A

Action Performed:

  1. Head to https://help.expensify.com/
  2. Click into Expensify Classic - https://help.expensify.com/expensify-classic/hubs/
  3. Click any homepage category (ex: Bank Accounts & Credit Cards)
  4. Click Expensify Classic in the LHN to return to the main, Expensify Classic homepage

Expected Result:

When clicking Expensify Classic from a category page, I would expect to be returned to the Expensify Classic category homepage - https://help.expensify.com/expensify-classic/hubs/:

image

Actual Result:

When clicking Expensify Classic from a category page, you're brought back to the main homepage where you're prompted to click Expensify Classic or New Expensify - https://help.expensify.com/:

image

To get back to the Expensify Classic category homepage, you must click Bank Accounts & Company Cards, which to me, is unintuitive.

Workaround:

N/A

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

https://github.com/Expensify/App/assets/38016013/1f19d3c9-7e7d-448f-8336-e9e68df42b2f

View all open jobs on GitHub

melvin-bot[bot] commented 10 months ago

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot[bot] commented 10 months ago

Bug0 Triage Checklist (Main S/O)

maddylewis commented 10 months ago

oh @MitchExpensify - kinda the perfect person to review this.

while the current design is intentional, i think this is an area that could be improved to help navigate the site more intuitive overall.

lmk your thoughts and then we can cc rushat to have a look if we want to move forward with a fix :)

MitchExpensify commented 10 months ago

I played around with this and it is a little odd I agree. That said you have all the same options expanded that you would see in the left-hand menu so I'm not sure what benefit going back to Expensify Classic does for the user necessarily.

E.g. If I click Expensify Classic all the same options are expended in the left hand menu that are in the squares. Then if I click "Account settings" I can easily navigate to any of the same options with one click via the left hand menu without needing to return to the tab itself (With all the squares). I quite like that aspect of the collapse/expand behavior in the left hand menu.

That leads me to think this isn't a problem necessarily. Curious if that sways you at all with regards to needing this fixed.

melvin-bot[bot] commented 10 months ago

@MitchExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

MitchExpensify commented 10 months ago

Checking in on what you think about my take above, @maddylewis

maddylewis commented 10 months ago

chatting more with our tech writer, Ren, and he made the good point that the LHN that shows on the homepage menu is redundant since the categories are listed as icons on the homepage. this makes me think we should maybe eliminate the LHN altogether and only have a back button.

the LHN should still exist once you're in an article so that you can click through the headings and subheadings easily. but the LHN when you're on the homepage and/or subcategory list seems redundant/not useful.

melvin-bot[bot] commented 10 months ago

@MitchExpensify @maddylewis this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

MitchExpensify commented 10 months ago

this makes me think we should maybe eliminate the LHN altogether and only have a back button.

I'll defer to you on that one! Personal preference but I quite like how the LHN lets you jump around anywhere you'd like to go without leaving the page you are on or clicking back.

maddylewis commented 10 months ago

okok im going to move to weekly for now since we're not totally sure if this is a "bug" worth fixing atm.

melvin-bot[bot] commented 10 months ago

@MitchExpensify @maddylewis this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

melvin-bot[bot] commented 9 months ago

@MitchExpensify, @maddylewis Eep! 4 days overdue now. Issues have feelings too...

melvin-bot[bot] commented 9 months ago

@MitchExpensify, @maddylewis Huh... This is 4 days overdue. Who can take care of this?

maddylewis commented 9 months ago

im gonna close this for now