search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.55k stars 2.89k forks source link

[$500] Scan - notifications@expensify.com only changes to Expensify after opening the message in thread #32581

Closed lanitochka17 closed 8 months ago

lanitochka17 commented 11 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.8-1 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:

Action Performed:

  1. Log in with a new account
  2. Go to any chat
  3. Create a Scan request using an image that will fail the scanning
  4. After the scanning fails, click on the IOU preview twice to open IOU details page
  5. Right click on the "scanning failed" system message > Reply in thread

Expected Result:

In Step 4, the owner of "scanning failed" system message is displayed as Expensify

Actual Result:

In Step 4, the owner of "scanning failed" system message is notifications@expensify.com. It only changes to Expensify after opening the system message in thread

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/67410c2b-baee-47b4-9f79-16ed8c8acaa6

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01e866fa63ee2203e1
  • Upwork Job ID: 1732481608650776576
  • Last Price Increase: 2024-01-03
blimpich commented 8 months ago

Updated in production. Display name now works.

https://github.com/Expensify/App/assets/17171674/bdfc0ef7-d749-4c64-a765-574223628c1f

blimpich commented 8 months ago

I'm going to do a bit of code cleanup on the frontend, then I will consider this done and close the issue.

melvin-bot[bot] commented 8 months ago

@eVoloshchak, @slafortune, @anmurali, @blimpich Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

blimpich commented 8 months ago

Ah I forgot to close this issue. Frontend changes have been merged and a separate issue was created for paying the C+ contributor here: https://github.com/Expensify/App/issues/37190.

Since payment is handled in that issue and this issue has been resolved I'm going to close this now.