[$500] [HOLD for payment 2023-12-20] IOU - Currency is reverted to the original currency after switching between tabs

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.11-1 Reproducible in staging?: y Reproducible in production?: n If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com.
2. Click FAB > Request money > Manual.
3. Select a different currency and change the amount.
4. Go to Scan tab.
5. Go to Manual tab. The currency is not preserved.

Expected Result:

The currency and amount will be preserved.

Actual Result:

The currency is reverted to the original currency.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [x] Android: Native
• [x] Android: mWeb Chrome
• [x] iOS: Native
• [x] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [x] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/93399543/b88f50f4-88a9-4bae-8f27-8976aa3da796

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e1265bf119a76d4b
• Upwork Job ID: 1734989360105709568
• Last Price Increase: 2023-12-13
• Automatic offers:
• 0xmiroslav | Contributor | 28066539

[github-actions[bot]]

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot[bot]]

Triggered auto assignment to @neil-marcellini (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[luacmartins]

It seems that the issue comes from resetting the transaction here. It doesn't happen for the amount because we render the local state instead of the transaction in Onyx - https://github.com/Expensify/App/blob/e1d334a706312e2242cc64cbcd959f1c2c52028c/src/pages/iou/steps/MoneyRequestAmountForm.js#L81

[neil-marcellini]

Thanks Carlos. Sorry for the delay. I'm working 75% and am focusing on the web deploy for now. I'll see if I can take a look after.

[luacmartins]

I have a fix up

[Julesssss]

PR merged and is being CP'd

[Julesssss]

@luacmartins this still seems to occur 😕

https://github.com/Expensify/App/assets/10736861/cee716f2-c0e1-4c58-a1c9-7894cdc6d685

[0xmiros]

@Julesssss it's new expected behavior

[luacmartins]

Correct. We changed the behavior and both amount and currency should be reset.

[melvin-bot[bot]]

Triggered auto assignment to @michaelhaxhiu (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot[bot]]

Bug0 Triage Checklist (Main S/O)

• [ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• [ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• [ ] This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• [ ] This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• [ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[Julesssss]

Oh my bad, I need to stop working. Thank you

[Julesssss]

Ah, thank you

[melvin-bot[bot]]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.11-25 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/32884

If no regressions arise, payment will be issued on 2023-12-20. :confetti_ball:

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• [ ] External issue reporter
• [ ] Contributor that fixed the issue
• [ ] Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @0xmiroslav requires payment (Needs manual offer from BZ)

[melvin-bot[bot]]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [ ] [@0xmiroslav] The PR that introduced the bug has been identified. Link to the PR:
• [ ] [@0xmiroslav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [ ] [@0xmiroslav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [ ] [@0xmiroslav] Determine if we should create a regression test for this bug.
• [ ] [@0xmiroslav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [ ] [@michaelhaxhiu] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[michaelhaxhiu]

Ok looks like we owe C+ payment here:

@0xmiroslav requires payment (Needs manual offer from BZ)

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~01e1265bf119a76d4b

[melvin-bot[bot]]

Current assignee @0xmiroslav is eligible for the External assigner, not assigning anyone new.

[michaelhaxhiu]

Payment due 12-20, so waiting

But here's the job - https://www.upwork.com/jobs/~01e1265bf119a76d4b

@0xmiroslav

[luacmartins]

Just pending payment

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @narefyev91 (External)

[melvin-bot[bot]]

📣 @0xmiroslav 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

[michaelhaxhiu]

Waiting for job offer to be accepted

[michaelhaxhiu]

paid.