[HOLD for payment 2023-12-20] [$500] Split - A new group is formed when splitting bill with a few members in the group

lanitochka17 commented 11 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.11-1 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:

Action Performed:

Go to staging.new.expensify.com
Go to group chat with many members
Click + > Split bill
Unselect a few members and create the bill split Note that a new group is formed

Expected Result:

The bill split is created in the same group chat

Actual Result:

A new group is formed in which the bill split is created

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/ea4258f3-f34b-4533-a89b-95c0825e0e79

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01ecb31d068a616959
Upwork Job ID: 1734322113712480256
Last Price Increase: 2023-12-11
Automatic offers:

shubham1206agra | Contributor | 28050164

github-actions[bot] commented 11 months ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

melvin-bot[bot] commented 11 months ago

Triggered auto assignment to @tgolen (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

abzokhattab commented 11 months ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

A new group is formed when splitting bil with a few members in a group

What is the root cause of that problem?

in the split we pass the report argument as the tag https://github.com/Expensify/App/blob/968f39f0a2c6e7305e46f7d5a8a546407689cc10/src/pages/iou/request/step/IOURequestStepConfirmation.js#L202-L212

What changes do you think we should make in order to solve the problem?

we should change it to

        IOU.splitBill(
                    selectedParticipants,
                    currentUserPersonalDetails.login,
                    currentUserPersonalDetails.accountID,
                    transaction.amount,
                    trimmedComment,
                    transaction.currency,
                    transaction.category,
                    transaction.tag,
                    report.reportID,
                );

POC:

also notice that we are not passing the merchant as in the old moneyconfirm page

situchan commented 11 months ago

@abzokhattab's proposal looks good to me. We recently added merchant so this should be correct fix:

        IOU.splitBill(
                    selectedParticipants,
                    currentUserPersonalDetails.login,
                    currentUserPersonalDetails.accountID,
                    transaction.amount,
                    trimmedComment,
                    transaction.currency,
                    transaction.category,
                    transaction.tag,
                    report.reportID,
                    transaction.merchant,
                );

melvin-bot[bot] commented 11 months ago

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

melvin-bot[bot] commented 11 months ago

Triggered auto assignment to @sophiepintoraetz (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot[bot] commented 11 months ago

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
[ ] This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
[ ] This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

melvin-bot[bot] commented 11 months ago

Job added to Upwork: https://www.upwork.com/jobs/~01ecb31d068a616959

melvin-bot[bot] commented 11 months ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

tgolen commented 11 months ago

@situchan is correct, the merchant field needs added too. Thanks for grabbing this one!

youssef-lr commented 11 months ago

@tgolen I was fixing this one here https://github.com/Expensify/App/pull/30721, I had to copy the update to the new file as I was changing the old one

tgolen commented 11 months ago

OK, thanks. Since this is a deploy blocker, I think we'll need a PR just for this fix.

youssef-lr commented 11 months ago

Sounds good!

melvin-bot[bot] commented 11 months ago

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

abzokhattab commented 11 months ago

The PR is ready

Julesssss commented 11 months ago

Starting CP

adelekennedy commented 11 months ago

Testing

adelekennedy commented 11 months ago

Just tested - when I unselect members from the split no new group is formed. The split remains in the same group chat

shubham1206agra commented 11 months ago

Please assign me here as reviewer

melvin-bot[bot] commented 11 months ago

📣 @shubham1206agra 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

melvin-bot[bot] commented 11 months ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 11 months ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.11-25 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/32896

If no regressions arise, payment will be issued on 2023-12-20. :confetti_ball:

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

[ ] External issue reporter
[x] Contributor that fixed the issue
[x] Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@shubham1206agra requires payment automatic offer (Contributor)
@abzokhattab requires payment (Needs manual offer from BZ)

melvin-bot[bot] commented 11 months ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@shubham1206agra] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@shubham1206agra] Determine if we should create a regression test for this bug.
[ ] [@shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ] [@sophiepintoraetz] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

sophiepintoraetz commented 11 months ago

@shubham1206agra - please can you accept the offer? I will pay once you have completed the BZ checklist. @abzokhattab - offer is in your inbox

abzokhattab commented 11 months ago

Thanks @sophiepintoraetz, I have accepted the offer

shubham1206agra commented 11 months ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[x] [@shubham1206agra] The PR that introduced the bug has been identified. Link to the PR: https://github.com/Expensify/App/pull/28618
[x] [@shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/28618/files#r1432806472
[x] [@shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not Required
[x] [@shubham1206agra] Determine if we should create a regression test for this bug. No as we already caught this in deploy testing
[x] [@shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ] [@sophiepintoraetz] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

sophiepintoraetz commented 11 months ago

Both paid, thanks!

Expensify / App