[LOW] [Splits] [$500] Chat - Member stays hidden if the reply comes in the IOU report

lanitochka17 commented 11 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.11.1 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:

Action Performed:

Navigate to https://staging.new.expensify.com/
Log in with two different accounts that didn't have any contact with each other yet
Account B: Create an IOU with account A
Account A: Open the chat with the IOU
Account A: Tap on the received IOU
Account A: Write any message
Account B: Navigate between conversations (to reveal the hidden account)

Expected Result:

The member should be revealed

Actual Result:

Member stays hidden if the reply comes in the IOU report

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/a2ded882-a0d3-4da8-84b5-1b8ebe7436c5

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01cc37bbe9540440f6
Upwork Job ID: 1734327335985864704
Last Price Increase: 2024-01-01

melvin-bot[bot] commented 11 months ago

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot[bot] commented 11 months ago

Job added to Upwork: https://www.upwork.com/jobs/~01cc37bbe9540440f6

melvin-bot[bot] commented 11 months ago

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
[ ] This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
[ ] This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

melvin-bot[bot] commented 11 months ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

dksingla commented 11 months ago

We are not getting enough details from the server about user A.


            "onyxMethod": "merge",
            "key": "personalDetailsList",
            "value": {
                "16127502": {
                    "accountID": 16127502,
                    "avatar": "https:\/\/d2k5nsl2zxldvw.cloudfront.net\/images\/avatars\/default-avatar_1.png",
                    "firstName": "",
                    "lastName": "",
                    "status": null
                },
                "16127512": {
                    "accountID": 16127512,
                    "avatar": "https:\/\/d2k5nsl2zxldvw.cloudfront.net\/images\/avatars\/default-avatar_13.png",
                    "firstName": "",
                    "lastName": "",
                    "status": null,
                    "displayName": "diwakij420@gearstag.com",
                    "login": "diwakij420@gearstag.com",
                    "pronouns": "",
                    "timezone": {
                        "automatic": true,
                        "selected": "Asia\/Calcutta"
                    },
                    "payPalMeAddress": "",
                    "phoneNumber": "",
                    "validated": true
                }
            }
        },```

keisyrzk commented 11 months ago

Hm please find my recording. I tried multiple times on staging server with fresh account being the User B. Have not seen the hidden naming at all. Did I miss something in reproduction steps? I tried both ways when splitting the bill: (1) click "split" on the side of the user on search

(2) click "Request (...)" in user details

Recording: https://github.com/Expensify/App/assets/18525360/1992cce0-2502-49f8-b53d-63729efa03d5

abdulrahuman5196 commented 11 months ago

Reviewing now

abdulrahuman5196 commented 11 months ago

@strepanier03 Isn't this the expected behaviour? Or are we changing the hidden feature?

melvin-bot[bot] commented 11 months ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] commented 11 months ago

@strepanier03, @abdulrahuman5196 Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] commented 11 months ago

@strepanier03, @abdulrahuman5196 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

strepanier03 commented 11 months ago

Apologies for the delay here, I was OoO. I'll confirm the expected behavior and update everyone here.

strepanier03 commented 11 months ago

We created a function in Auth to determine whether userA knows userB. The criteria are:

if userB has ever requested money or sent an expense report to userA
if userB has ever sent a message in a DM or groupDM that userA is a part of
if userA and userB share access to at least one non-public workspace room or domain room

It looks like we need to fix this because userA replying to userB should establish the relationship between the accounts that allows for the user to be revealed.

strepanier03 commented 11 months ago

Confirming wave/VIP here.

melvin-bot[bot] commented 10 months ago

@strepanier03 @abdulrahuman5196 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

melvin-bot[bot] commented 10 months ago

@strepanier03, @abdulrahuman5196 Eep! 4 days overdue now. Issues have feelings too...

abdulrahuman5196 commented 10 months ago

We are waiting on this https://github.com/Expensify/App/issues/32870#issuecomment-1863612993. I think folks are off this week, so could expect delays in responses.

melvin-bot[bot] commented 10 months ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

strepanier03 commented 10 months ago

@abdulrahuman5196 - You're correct, the holidays and OoO are impacting the response here. I checked and nothing on my post yet. I'll check tomorrow but I think it's safe to assume no update will come until next week.

mvtglobally commented 10 months ago

Issue not reproducible during KI retests. (First week)

melvin-bot[bot] commented 10 months ago

@strepanier03 @abdulrahuman5196 this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

melvin-bot[bot] commented 10 months ago

@strepanier03, @abdulrahuman5196 Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] commented 10 months ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] commented 10 months ago

@strepanier03 @abdulrahuman5196 this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

melvin-bot[bot] commented 10 months ago

@strepanier03, @abdulrahuman5196 Whoops! This issue is 2 days overdue. Let's get this updated quick!

abdulrahuman5196 commented 10 months ago

@abdulrahuman5196 - You're correct, the holidays and OoO are impacting the response here. I checked and nothing on my post yet. I'll check tomorrow but I think it's safe to assume no update will come until next week.

Same here

strepanier03 commented 10 months ago

I've bumped the Slack thread for an update and will take action here as soon as I can.

melvin-bot[bot] commented 10 months ago

Current assignee @abdulrahuman5196 is eligible for the Internal assigner, not assigning anyone new.

strepanier03 commented 10 months ago

All right, we've added this to a VIP with a Low priority. We expect this will have an Internal element to it to resolve but if you disagree @abdulrahuman5196 please chime in. (expected behavior)

melvin-bot[bot] commented 10 months ago

@strepanier03 @abdulrahuman5196 this issue is now 4 weeks old and preventing us from maintaining WAQ. This should now be your highest priority. Please post below what your plan is to get a PR in review ASAP. Thanks!

melvin-bot[bot] commented 10 months ago

@strepanier03, @abdulrahuman5196 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

strepanier03 commented 10 months ago

Since this is Low priority, I'm switching to weekly until it's picked up so that I don't have to update it every day.

strepanier03 commented 10 months ago

No update, low priority.

strepanier03 commented 10 months ago

All good Melvin.

strepanier03 commented 10 months ago

Hmmm, not sure why the overdue here is being so sticky.

strepanier03 commented 9 months ago

All good Melvin, low priority for the time being.

abdulrahuman5196 commented 9 months ago

@strepanier03 Are we going to work on this now? Seems the daily label is added on this?

melvin-bot[bot] commented 9 months ago

@strepanier03, @abdulrahuman5196 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

strepanier03 commented 9 months ago

@abdulrahuman5196 - It's not a priority, so likely not, but I'm supposed to keep it daily so that's why the label is applied.

melvin-bot[bot] commented 9 months ago

@strepanier03, @abdulrahuman5196 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

strepanier03 commented 9 months ago

Pausing on this as we discuss this VIP internally.

melvin-bot[bot] commented 9 months ago

@strepanier03, @abdulrahuman5196 Huh... This is 4 days overdue. Who can take care of this?

strepanier03 commented 9 months ago

All good Melvin.

strepanier03 commented 9 months ago

Low priority and will be worked on when it's more of a priority.

melvin-bot[bot] commented 9 months ago

@strepanier03, @abdulrahuman5196 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

strepanier03 commented 9 months ago

All good Melvin.

strepanier03 commented 8 months ago

Waiting to be picked up.

strepanier03 commented 8 months ago

All good Melvin, waiting for internal ownership.

strepanier03 commented 8 months ago

Assigned to a project and waiting to be picked up.

melvin-bot[bot] commented 8 months ago

@strepanier03, @abdulrahuman5196 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Expensify / App