Web - Split - Scan bill split is created in one of the participants' chat instead of new group chat

kavimuru commented 11 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v1.4.11-6 Reproducible in staging?: y Reproducible in production?: n If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause internal team Slack conversation:

Action Performed:

Go to staging.new.expensify.com.
Click FAB > Request money > Scan.
Enter amount > Next.
Select two users that have existing IOUs > Click Split.
Create the bill split.

Expected Result:

The bill split is created in a new group chat with the selected users.

Actual Result:

The bill split is created in one of the participants' 1:1 DM instead of a new group chat.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x ] iOS: mWeb Safari
[x ] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/43996225/a15b98fa-f575-4485-9ecd-f26f4259d487

View all open jobs on GitHub

melvin-bot[bot] commented 11 months ago

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot[bot] commented 11 months ago

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
[ ] This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
[ ] This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

github-actions[bot] commented 11 months ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

melvin-bot[bot] commented 11 months ago

Triggered auto assignment to @MariaHCD (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

abzokhattab commented 11 months ago

same as https://github.com/Expensify/App/issues/32855

MariaHCD commented 11 months ago

This does look to be similar to #32855. Closing in favor of that issue.

shubham1206agra commented 11 months ago

@Julesssss @MariaHCD The fix does not seem to fix this issue. Please reopen this. It opens wrong report actually

Julesssss commented 11 months ago

Hey @shubham1206agra just to confirm, even with the changes from the linked PR (which haven't yet been merged)?

shubham1206agra commented 11 months ago

Yes It just opens the wrong report (more specific, of first participant)

shubham1206agra commented 11 months ago

Fix seems to be relatively easy. I will fix this in another PR

Julesssss commented 11 months ago

Thanks, reopening. I will assign you now @shubham1206agra.

@MariaHCD I'll try to keep an eye on this one but we have about 20+ blockers so it would be great if you could also keep on eye on any developments here. Thanks

Julesssss commented 11 months ago

Fix seems to be relatively easy. I will fix this in another PR

Hey @shubham1206agra just checking which PR you fixed this in?

shubham1206agra commented 11 months ago

https://github.com/Expensify/App/pull/32918

Julesssss commented 11 months ago

Thanks, I just merged that fix. We'll verify the fix on staging

Expensify / App