[HOLD for payment 2024-01-11] [$500] Expense - Missing "Required" and "Request" for Category & Tag and Merchant respectively

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.12-2 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:

Action Performed:

Precondition:

• User is an employee of a Collect workspace on OD.
• The workspace has set Category and Tag to required.

1. Go to the Collect workspace chat.
2. Click + > Request money > Manual.
3. Enter amount > Next.

Expected Result:

On confirmation page,

• "Required" is shown on Category and Tag row.
• "Request" is shown in Merchant field by default.

Actual Result:

On confirmation page,

• "Required" is not shown on Category and Tag row.
• "Request" is not shown in Merchant field by default.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [x] Android: Native
• [x] Android: mWeb Chrome
• [x] iOS: Native
• [x] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [x] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/93399543/6a507a0e-9441-41b0-8302-acdc35a6e055

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018b84474aa7b66f4e
• Upwork Job ID: 1735302826178007040
• Last Price Increase: 2023-12-14
• Automatic offers:
• shubham1206agra | Reviewer | 28066311
• DylanDylann | Contributor | 28066312

[melvin-bot[bot]]

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~018b84474aa7b66f4e

[melvin-bot[bot]]

Bug0 Triage Checklist (Main S/O)

• [ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• [ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• [ ] This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• [ ] This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• [ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

[kbecciv]

Production on previous build

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense - Missing "Required" and "Request" for Category & Tag and Merchant respectively

What is the root cause of that problem?

We have not passed the right label prop for category and tag [here]()

What changes do you think we should make in order to solve the problem?

We should pass the prop if policy requires category and tag:

rightLabel={Boolean(props.policy.requiresCategory) ? translate('common.required') : ''} 

rightLabel={Boolean(props.policy.requiresTag) ? translate('common.required') : ''}

We may also have a canUseViolations check.

[GItGudRatio]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense - Missing "Required" and "Request" for Category & Tag and Merchant respectively

What is the root cause of that problem?

The rightLabel prop is passed correctly in these places:

• https://github.com/Expensify/App/blob/fa87f8bb98aa960f71584e188cbaee5c091bb0f0/src/components/MoneyRequestConfirmationList.js#L713
• https://github.com/Expensify/App/blob/fa87f8bb98aa960f71584e188cbaee5c091bb0f0/src/components/MoneyRequestConfirmationList.js#L732

However, it is not used here:

• https://github.com/Expensify/App/blob/89cc7211fbef34d80450770f796b5e4792fc8a53/src/components/MoneyTemporaryForRefactorRequestConfirmationList.js#L712-L724

This is the function responsible for rendering the component here: https://github.com/Expensify/App/blob/aace20dcdbe79a3a144b8113daf5d1445fd9dc9c/src/pages/iou/request/step/IOURequestStepConfirmation.js#L8

What changes do you think we should make in order to solve the problem?

We need to add the conditional properly, along with the usePermissions hook. const {canUseViolations} = usePermissions();

rightLabel={canUseViolations && Boolean(props.policy.requiresCategory) ? translate('common.required') : ''}

rightLabel={canUseViolations && Boolean(props.policy.requiresTag) ? translate('common.required') : ''}

What alternative solutions did you explore? (Optional)

N/A

[DylanDylann]

Proposal

Please re-state the problem that we are trying to solve in this issue.

On confirmation page,

"Required" is shown on Category and Tag row. "Request" is shown in Merchant field by default.

What is the root cause of that problem?

1. In IOURequestStepConfirmation, we don't set rigthLabel for Tag and Category.
2. We don't have logic to prevent the user from requesting money if category/tag is required and the user doesn't select category/tag.
3. In the manual request, split bill, scan request, the default merchant is empty

What changes do you think we should make in order to solve the problem?

1. In 2 places https://github.com/Expensify/App/blob/3a44f772e2c381b1cdb025f845551c5f0985bad5/src/components/MoneyTemporaryForRefactorRequestConfirmationList.js#L713 https://github.com/Expensify/App/blob/3a44f772e2c381b1cdb025f845551c5f0985bad5/src/components/MoneyTemporaryForRefactorRequestConfirmationList.js#L728

we should add

rightLabel={canUseViolations && Boolean(props.policy.requiresCategory) ? translate('common.required') : ''}

rightLabel={canUseViolations && Boolean(props.policy.requiresTag) ? translate('common.required') : ''}

And then in here https://github.com/Expensify/App/blob/3a44f772e2c381b1cdb025f845551c5f0985bad5/src/components/MoneyTemporaryForRefactorRequestConfirmationList.js#L504

we should add an error handling if category/tag is required and the user doesn't select category/tag.

if (!iouCategory) {
  setFormError('common.error.invalidCategory');
  return;
}
if (!iouTag) {
  setFormError('common.error.invalidTag');
  return;
}

In en.ts and es.ts we also need to add the translation for 'common.error.invalidCategory' and 'common.error.invalidTag'

2. In the manual request, split bill, scan request, we should set deafult merchant is 'Request'. To do that, in here https://github.com/Expensify/App/blob/961d5010bfd708bee0707c625244d0983846dc6d/src/components/MoneyTemporaryForRefactorRequestConfirmationList.js#L694 we should update like this

title={iouMerchant || CONST.TRANSACTION.DEFAULT_MERCHANT} 

like we did with the date field https://github.com/Expensify/App/blob/961d5010bfd708bee0707c625244d0983846dc6d/src/components/MoneyTemporaryForRefactorRequestConfirmationList.js#L660

And then when requesting money we also do the same thing: checking if iouMerchant is empty we will use CONST.TRANSACTION.DEFAULT_MERCHANT

Result

https://github.com/Expensify/App/assets/141406735/6f9dc92d-4575-40a6-91e5-43381bc739e2

[melvin-bot[bot]]

@miljakljajic, @shubham1206agra Whoops! This issue is 2 days overdue. Let's get this updated quick!

[shubham1206agra]

No proposal seems to have complete solution, i.e., missing Request in merchant.

[DylanDylann]

@shubham1206agra Updated proposal

[shubham1206agra]

@DylanDylann I don't think your solution is correct for setting merchant

[DylanDylann]

@shubham1206agra is this expected

[shubham1206agra]

No I mean your solution method by which you are setting a merchant

[DylanDylann]

@shubham1206agra I don't see any way to setup Merchant to request on olddot. So I think that the reporter want to display request as default value

[shubham1206agra]

No I mean the use of useEffect hook is not ideal here 😅

[DylanDylann]

@shubham1206agra Updated proposal with another way like we did in the date field

[shubham1206agra]

@tgolen I just want to confirm the default merchant. Should we set it to Request or it was removed for some reason?

[tgolen]

I am not sure. I have not heard of it being a requested change, but that doesn't mean it wasn't. @dylanexpensify @mountiny @luacmartins might know.

[luacmartins]

It seems like we still use Request as the default merchant, no? What do you mean by it was removed?

[shubham1206agra]

It seems like we still use Request as the default merchant, no? What do you mean by it was removed?

I mean as a default merchant.

[shubham1206agra]

@DylanDylann's proposal looks good to me in that case.

🎀👀🎀 C+ reviewed

[melvin-bot[bot]]

Triggered auto assignment to @tgolen, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot[bot]]

📣 @shubham1206agra 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job

[melvin-bot[bot]]

📣 @DylanDylann 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

[DylanDylann]

@luacmartins In case the user enables "Required" category/tags, should we disable request money if user don't select category/tags ?

[luacmartins]

IIRC we don't block the user in that case and instead will show a violation. Is that right @cead22?

[DylanDylann]

@cead22 Could you help to confirm this one ?

[cead22]

• Shouldn't this have been assigned to me and IR?
• Which file are we keeping in the end, App/src/components/MoneyTemporaryForRefactorRequestConfirmationList.js?
• I say we close this and I'll handle this in a separate issues as part of the violations project

To answer the question, Carlos is right, we don't block the user

[shubham1206agra]

• Which file are we keeping in the end, App/src/components/MoneyTemporaryForRefactorRequestConfirmationList.js?

Yes

• I say we close this and I'll handle this in a separate issues as part of the violations project

@cead22 Since @DylanDylann has nearly completed this issue fix, let us finish this issue up.

[cead22]

The issue fix is a 3 line change, and we don't have a PR with tests or anything yet. I still think we should close and let the people working on violations fix this. This isn't really a bug, it's a small oversight coming from the fact that we have 2 files doing the same thing, one of which is temporary due to a refactor.

Ultimately, I'll lean on what @miljakljajic and @tgolen want to do

[melvin-bot[bot]]

@tgolen, @miljakljajic, @shubham1206agra, @DylanDylann Whoops! This issue is 2 days overdue. Let's get this updated quick!

[mountiny]

The change @shubham1206agra is referring to is that for expenses we will require a merchant to be set during creation so the Request will be removed from there. In case of Scan request too there should be no way to add the merchant during creation so Request wont be default either.

[mountiny]

@shubham1206agra With that said, I think you can omit changes to the Merchant field in this PR and only handle the category and tag.

We are handling the merchant changes in here https://github.com/Expensify/App/pull/32486

[DylanDylann]

@shubham1206agra The PR is ready for review. Could you help to take a look?

[melvin-bot[bot]]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.21-4 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/33595

If no regressions arise, payment will be issued on 2024-01-11. :confetti_ball:

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• [ ] External issue reporter
• [ ] Contributor that fixed the issue
• [ ] Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @shubham1206agra requires payment automatic offer (Reviewer)
• @DylanDylann requires payment automatic offer (Contributor)

[melvin-bot[bot]]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [ ] [@shubham1206agra] The PR that introduced the bug has been identified. Link to the PR:
• [ ] [@shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [ ] [@shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [ ] [@shubham1206agra] Determine if we should create a regression test for this bug.
• [ ] [@shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [ ] [@miljakljajic] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[miljakljajic]

@shubham1206agra make sure you accept the offer so that we can pay promptly when the seven day hold is up!

[miljakljajic]

@shubham1206agra @DylanDylann payment issued for you both! Do you have suggestions for additional test rail steps we should add for this issue?

[shubham1206agra]

Not really. This is an edge case handling and is behind a beta right now.

[melvin-bot[bot]]

Issue is ready for payment but no BZ is assigned. @greg-schroeder you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

[greg-schroeder]

Unassigning myself as it seems Milja already handled this

[miljakljajic]

I'll close this out as payment has been issued and no test rail steps are required.