Closed izarutskaya closed 8 months ago
Job added to Upwork: https://www.upwork.com/jobs/~013a9a9a0a9a660619
Triggered auto assignment to @stephanieelliott (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details.
Platforms
in OP are ✅)Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External
)
:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Triggered auto assignment to @mountiny (Engineering
), see https://stackoverflow.com/c/expensify/questions/4319 for more details.
Extra top padding on each field in Additional details page
Currently we have a margin-top: 16px each fileds
containerStyles={[styles.mt4]}
we should remove margin-top
containerStyles={[styles.mt4]} // remove
Or we can update to mt-2
N/A
But why is it not reproducible in production @namhihi237? Because the line of code you're referring to is an old one. 😕
I'm available for fixing this issue immediately.
Wallet - Extra top padding on each field in Additional details page
This is a regression from https://github.com/Expensify/App/pull/24620.
The addition of this line here is causing the issue: https://github.com/Expensify/App/commit/4068e30aaeba5295b60243f64745740178fd8c74#diff-a97b40d6cf9952955d364e70010b61de4d91a39d1281c4e39f2178e24b9deff9R264
Remove this line to fix the issue.
After Fix:
https://github.com/Expensify/App/assets/54214654/9fbf876d-0b33-4b15-a756-0284a38fc416
📣 @jjcoffee 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!
Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻 Keep in mind: Code of Conduct | Contributing 📖
I think this is minor issue so it does not have to be a blocker, but also I think that should be handled with the PR authors @perunt @allroundexperts @jjcoffee
Bumped in slack
I made a PR for that. It's a duplication of the style's name. I don't know why it wasn't a thing on merge conflicts.
Hey @perunt @allroundexperts @jjcoffee is there a PR for this? I don't see one linked.
@stephanieelliott, here's the PR that resolved the issue: https://github.com/Expensify/App/pull/33221
All reviews completed, PR is undergoing QA
Reviewing
label has been removed, please complete the "BugZero Checklist".
The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.23-4 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-01-17. :confetti_ball:
For reference, here are some details about the assignees on this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
This is a followup PR to resolve a regression from a PR that the contributor/C+ reviewed, so no payment is due here! Payment will be handled on the original issue.
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v1.4.13-4 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause-Internal Team Slack conversation: @
Action Performed:
Expected Result:
Each field is spaced adequately.
Actual Result:
Each field has excess top padding, making each field look wide apart from one another.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
View all open jobs on GitHub
Upwork Automation - Do Not Edit