Closed kbecciv closed 8 months ago
Job added to Upwork: https://www.upwork.com/jobs/~0143f494715bf21dfc
Triggered auto assignment to @lschurr (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details.
Platforms
in OP are β
)Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External
)
Hi, I'm Artur from Callstack - expert contributor group - and I would like to work on this issue.
π£ @artus9033! π£ Hey, it seems we donβt have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
Settings - Focus shifts to first digit on shortcut & back #33170
We always focus to the first input using useFocusEffect
when page is mounted.
Instead of focus
inside useFocusEffect
we can use focusLastSelected
.
https://github.com/Expensify/App/assets/85894871/9e8946c5-5c5f-4dee-bb6a-b576c68970f6
Could you review the proposal @alitoshmatov?
Reviewing
@Krishna2323 Your RCA is correct. Your solution solves a problem and straightforward
We can go with @Krishna2323 's proposal
C+ reviewed π π π
Triggered auto assignment to @nkuoch, see https://stackoverflow.com/c/expensify/questions/7972 for more details.
π£ @alitoshmatov π An offer has been automatically sent to your Upwork account for the Reviewer role π Thanks for contributing to the Expensify app!
π£ @Krishna2323 π An offer has been automatically sent to your Upwork account for the Contributor role π Thanks for contributing to the Expensify app!
Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review π§βπ» Keep in mind: Code of Conduct | Contributing π
@alitoshmatov, PR ready for a review.
Reviewing
label has been removed, please complete the "BugZero Checklist".
The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.16-5 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-01-02. :confetti_ball:
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
@alitoshmatov could you work through the checklist on this one?
Payment summary:
Payments sent in Upwork. Closing this one out.
If you havenβt already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v1.4.13-0 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:
Action Performed:
Expected Result:
App should focus back to next empty magic code input OR magic code input which was focused before opening keyboard shortcut on back from any keyboard shortcut
Actual Result:
App focuses on first magic code input on back from keyboard shortcut even though focus was on other magic code input before opening any keyboard shortcut
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/93399543/7293e50c-0b84-48a5-95ad-b05053310739
View all open jobs on GitHub
Upwork Automation - Do Not Edit