[Wave 8] Ideal nav

[adamgrzybowski]

Details

Introduces the new navigation style to the App, mainly the new bottom tabs, the workspace switcher and moves several pages to the main pane navigator. For more details about the navigation patterns and design, refer to the design doc.

Fixed Issues

$ https://github.com/Expensify/App/issues/32941

Tests

• [x] Verify that no errors appear in the JS console

There is obviously lots to cover in testing, we have let QA Applause team know about this big change and gave them a document with testing steps to follow.

Offline tests

Similar to the Test when it comes to the navigation patterns.

QA Steps

There is obviously lots to cover in testing, we have let QA Applause team know about this big change and gave them a document with testing steps to follow.

• [x] Verify that no errors appear in the JS console

PR Author Checklist

• [x] I linked the correct issue in the ### Fixed Issues section above
• [x] I wrote clear testing steps that cover the changes made in this PR
  • [x] I added steps for local testing in the Tests section
  • [x] I added steps for the expected offline behavior in the Offline steps section
  • [x] I added steps for Staging and/or Production testing in the QA steps section
  • [x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • [x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • [x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• [x] I included screenshots or videos for tests on all platforms
• [x] I ran the tests on all platforms & verified they passed on:
  • [x] Android: Native
  • [x] Android: mWeb Chrome
  • [x] iOS: Native
  • [x] iOS: mWeb Safari
  • [x] MacOS: Chrome / Safari
  • [x] MacOS: Desktop
• [x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• [x] I followed proper code patterns (see Reviewing the code)
  • [x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • [x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • [x] I verified that comments were added to code that is not self explanatory
  • [x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • [x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • [x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • [x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • [x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • [x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • [x] I verified the JSDocs style guidelines (in STYLE.md) were followed
• [x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• [x] I followed the guidelines as stated in the Review Guidelines
• [x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• [x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• [x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• [x] I verified that if a function's arguments changed that all usages have also been updated correctly
• [x] If any new file was added I verified that:
  • [x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• [x] If a new CSS style is added I verified that:
  • [x] A similar style doesn't already exist
  • [x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• [x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• [x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• [x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• [x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• [x] If the PR modifies the form input styles:
  • [x] I verified that all the inputs inside a form are aligned with each other.
  • [x] I added Design label so the design team can review the changes.
• [x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• [x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

We are not adding specific test screenshots or videos into this sections. The PR has been tested thoroughly over the course of weeks on various platforms. You can see that progress in the comment history here, rest assured we tried our best to catch any regressions.

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

[MaciejSWM]

[github-actions[bot]]

:test_tube::test_tube: Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! :test_tube::test_tube:	Android :robot:	iOS :apple:
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/33280/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/33280/index.html
Desktop :computer:	Web :spider_web:
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/33280/NewExpensify.dmg	https://33280.pr-testing.expensify.com

[staszekscp]

Hey @mountiny! When would be possible to start testing the changes? 😄

[s77rt]

@adamgrzybowski Can you please merge main / resolve conflicts? I see some changes related the LHP that should not be a part of this PR

[WojtekBoman]

Conflicts have been resolved :)

[s77rt]

How is this supposed to look on Web? Not seeing much currently

[s77rt]

1. Missing icon on the bottom tabs
2. We should not keep navigating to a page that are we are currently in
3. Navigation direction should be different when going to Chats

https://github.com/Expensify/App/assets/16493223/3b19eea1-2131-42c4-bc8e-c88f0bda7e11

[s77rt]

Question: What is the role of the Expensify top-left logo button?

https://github.com/Expensify/App/assets/16493223/e7e50849-4df4-49ed-adc0-f54bd2eb865c

[github-actions[bot]]

:test_tube::test_tube: Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! :test_tube::test_tube:	Android :robot:	iOS :apple:
❌ FAILED ❌	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/33280/index.html
The QR code can't be generated, because the android build failed
Desktop :computer:	Web :spider_web:
❌ FAILED ❌	https://33280.pr-testing.expensify.com
The QR code can't be generated, because the Desktop build failed

---

:eyes: View the workflow run that generated this build :eyes:

[s77rt]

Help and Go Expensify Classing missing the external link icon

[kosmydel]

Help and Go Expensify Classing missing the external link icon

The designs don't include this icon. Do you think the icons should be visible here? cc @shawnborton

[kosmydel]

How is this supposed to look on Web? Not seeing much currently <img alt="Screenshot 2024-01-04 at 11 37 54 AM"

Oh, we forgot to mention. To got everything working you have to do the following:

rm -rf node_modules
npm i

We made some changes in a patch file and simple npm i doesn't re-apply patches.

[kosmydel]

Question: What is the role of the Expensify top-left logo button?

We haven't implemented this part yet - the workspace switcher. We are currently working on it.

[mountiny]

Question: What is the role of the Expensify top-left logo button?

This will be workspace switcher, where you can filter the app functionality on workspace basis

[s77rt]

I love the new web design <3

[s77rt]

1. Going to Profile does not have the Profile highlighted
2. Going to AllSettings does not have the Workspace highlighted (and it can't be highlighted on a second click)
3. There is a back button in the Workspace that should not be there (at least for Web)

https://github.com/Expensify/App/assets/16493223/34ae90c0-e61e-417e-832c-da0b053fd8d1

[s77rt]

Delete popover is misplaced

Same with workspace avatar change button

[s77rt]

Bug / By design? The settings in the workspace do not take full width

[s77rt]

Starting VBBA process messes with the flow: the central screen have a chat while the sidebar is on workspace settings. Also browser back button do not work

https://github.com/Expensify/App/assets/16493223/5ab90a13-1f2a-4556-aa6b-6829ac5b1f72

[s77rt]

Not a bug: Now that the workspace name field is pushed on it's own page we should auto focus the input

[s77rt]

Crash when trying to view a workspace avatar

https://github.com/Expensify/App/assets/16493223/59b55792-3174-414f-835a-5f8500b41386

[s77rt]

(similar to https://github.com/Expensify/App/pull/33280#issuecomment-1876967788) If you refresh the page while RHP is open the highlighted item in Settings list is lost

https://github.com/Expensify/App/assets/16493223/695b289f-408b-4f0b-9296-1a44bec5a776

[s77rt]

Workspace links all redirects to the overview and you can't refresh a page that you are currently in

https://github.com/Expensify/App/assets/16493223/bb6c8baa-8dbc-437a-986d-593ca286f89a

[s77rt]

URL naming inconsistency:

• Navigating to Workspace Settings > Overview > Name => workspace/0680EF3C70411F57/name
• Navigating to Workspace Settings > Overview > Currency => workspace/0680EF3C70411F57/overview/currency

[shawnborton]

Bug / By design? The settings in the workspace do not take full width

That is by design, but we need some modifications here. @adamgrzybowski can you please do the following:

• on desktop, these cards should be aligned to the left
• on desktop, these cards should have an inner padding of 32px. On mobile, it goes back to 20px.
• on desktop, these cards have a max-width of 600px

cc @dannymcclain @dubielzyk-expensify for extra eyes on this PR too.

[shawnborton]

Starting VBBA process messes with the flow: the central screen have a chat while the sidebar is on workspace settings. Also browser back button do not work

Yeah, ideally this flow should start on the same page (in this case the travel page) but just launched in the RHP.

[s77rt]

1. Workspace name overflows
2. There is extra spacing in the Workspace initial settings page at the top and no back button
3. Inner pages are broken e.g. Invoices
4. All pages have a top padding except the Members page, the Invite button is too close to the top (not necessary a bug)

https://github.com/Expensify/App/assets/16493223/1947b7c6-4396-4a72-80e7-b3a432656ab5

[shawnborton]

Also I wanted to clarify, the Workspace name and page name should not be in a scrollable view. I think just the content below it (the subnav items) would be scrollable. I saw that from the video above, here is a screenshot:

So how it should behave: basically everything in this top outlined rectangle is fixed, but the content in the rectangle below (the sub nav options) can scroll vertically:

[shubham1206agra]

@shawnborton Can you provide figma link here if possible to check the styling layout in detail (spacing, color, etc.)?

[shawnborton]

@shubham1206agra I put a couple references for you here: https://www.figma.com/file/Xv3yHJooZcxRGkXbAcTZD5/%23ideal-nav-(Ideal-Nav)?type=design&node-id=2684%3A72517&mode=design&t=larByJRbckmqvl1c-1

[shubham1206agra]

Requested access

[s77rt]

As an anonymous user:

1. Sign in button overlaps
2. The search opens in RHP (not a blocker - it may not be related to this PR, didn't check)
3. Can create workspace

https://github.com/Expensify/App/assets/16493223/5537ae48-1fea-4e63-9457-f240ae9043c9

[s77rt]

Animation inconsistency iOS / Android

https://github.com/Expensify/App/assets/16493223/f419ed05-8f1e-4f75-afc0-a5bcdae46f9f

[s77rt]

1. Can't open https://dev.new.expensify.com:8082/settings/wallet from chat it always redirects to /profile
2. The invite page https://dev.new.expensify.com:8082/workspace/0680EF3C70411F57/invite opens in RHP but keeps the central screen unchanged. Then when you press the assistance button and go back the central pane changes to /members and the bottom tab navigator stays on Chats

https://github.com/Expensify/App/assets/16493223/1cac26f8-dd68-43dd-ace4-db3ca4b046d9

[s77rt]

1. Going to Workspace -> any workspace causes some a flicker (probably related to https://github.com/Expensify/App/pull/33280#issuecomment-1877362108)
2. Going back takes you to the workspace initial page instead of the workspaces list

https://github.com/Expensify/App/assets/16493223/123f03fc-6a4b-433b-a582-7d78e807a07e

[s77rt]

(Similar to https://github.com/Expensify/App/pull/33280#issuecomment-1877440041 Clicking the get assistance button changes the central pan screen

https://github.com/Expensify/App/assets/16493223/af397fcd-a2fe-4694-bf32-13e1415b0467

[shawnborton]

One thing I want to mention here, the bottom FAB button should be at our large button size of 52x52, with the icon inside of it at 20x20:

I'll update those two mocks I shared in Figma as well.

[mountiny]

@MaciejSWM @WojtekBoman @kosmydel Whenever you think this is ready for a new build once some bugs are fixed feel free to let me know I will kick it off

[s77rt]

Low priority bug: Go to Settings -> Preferences -> Go back to Settings and increase screen width. The central pan is empty

https://github.com/Expensify/App/assets/16493223/bf8299af-43d9-474f-89d3-469e8ee09f6a

[s77rt]

Avatars misalignment

[s77rt]

1. Double offline indicator in small screens
2. Missing offline indicator in wide screens

[s77rt]

On App open no bottom tab item is highlighted (native only)

[s77rt]

Missing border bottom in some pages e.g. Profile, Workspaces, etc.

[s77rt]

The back behavior in "App download links" is wrong

https://github.com/Expensify/App/assets/16493223/a9f8c5d5-18ab-452d-bd05-e0e119ca5703

[s77rt]

(Could be related to https://github.com/Expensify/App/pull/33280#issuecomment-1876993340) Once you start VBBA process you get stuck and can't go back

https://github.com/Expensify/App/assets/16493223/074f019d-5389-4d74-b587-230eabf489c0

[s77rt]

Go to Workspace Settings and go though the settings (3+) in wide layout, then resize to small window. Pressing go back should take you directly to WorkspaceInitialPage. Instead you'd be going to the previous pages and weirdly end up passing by the Report screen. (reduceReportRoutes probably have some relation here)

https://github.com/Expensify/App/assets/16493223/fba078e1-fdbc-492a-b31b-075e5b30ffce

[s77rt]

Brick road indicator not implemented correctly (still in progress?)

1. RBR is shown on Profile but it should not (going through the Profile route won't take you to where the error is)
2. Most the pages are missing RBR

https://github.com/Expensify/App/assets/16493223/e01fb75e-5df6-41f6-bcff-58faea0b6cc7

[kosmydel]

Missing border bottom in some pages e.g. Profile, Workspaces, etc.

It was discussed here.

Attaching screenshot, as the channel probably is private:

It will be done as a follow-up.

[shubham1206agra]

@MaciejSWM Can you fix merge conflicts and start an adhoc build?

[kosmydel]

@MaciejSWM Can you fix merge conflicts and start an adhoc build?

It's not ready yet for another build. We will have more information tomorrow as @adamgrzybowski will be back from OOO.