[HOLD for payment 2024-01-02] [HOLD for payment 2023-12-29] [$500] Contact method - Delete contact method confirmation pop-up appears after slight delay

lanitochka17 commented 10 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.15-4 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - internal Team Slack conversation:

Issue found when executing PR https://github.com/Expensify/App/pull/32901

Action Performed:

Go to Settings > Profile > Contact method
Click New contact method
Enter a new email
Click on the newly added email
Click Remove

Expected Result:

Delete confirmation pop-up appears without delay

Actual Result:

Delete confirmation pop-up appears after slight delay.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/8c192da0-4c1b-4ad3-928c-fb70085ba05b

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~016b88b71e8f06ec60
Upwork Job ID: 1737900809599180800
Last Price Increase: 2023-12-21
Automatic offers:

shubham1206agra | Reviewer | 28067079
FitseTLT | Contributor | 28067080

Issue Owner

Current Issue Owner: @isabelastisser

github-actions[bot] commented 10 months ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

melvin-bot[bot] commented 10 months ago

Triggered auto assignment to @NikkiWines (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

FitseTLT commented 10 months ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

Delete contact method confirmation pop-up appears after slight delay https://github.com/Expensify/App/blob/2f7c2b2caa32002455165965d140230a38e3f18c/src/pages/settings/Profile/Contacts/ContactMethodDetailsPage.js#L222-L227

What is the root cause of that problem?

It is caused by this pr to display modal after keyboard is dismissed

What changes do you think we should make in order to solve the problem?

We should do that only for touch screen https://github.com/Expensify/App/blob/2f7c2b2caa32002455165965d140230a38e3f18c/src/pages/settings/Profile/Contacts/ContactMethodDetailsPage.js#L222-L227 change it to

toggleDeleteModal(isOpen) {
        if (canUseTouchScreen()) {
            InteractionManager.runAfterInteractions(() => {
                this.setState({isDeleteModalOpen: isOpen});
            });
            Keyboard.dismiss();
        } else {
            this.setState({isDeleteModalOpen: isOpen});
        }
    }

What alternative solutions did you explore? (Optional)

allroundexperts commented 10 months ago

Hm... Is this a bug? We decided to run it after all interactions.

NikkiWines commented 10 months ago

This seems to only occur when the contact method is unvalidated, which makes sense given @allroundexperts's and @FitseTLT's comments above. I do think it comes across a bit buggy and we should fix it. Especially if we're applying logic that only impacts touchscreen devices to all platforms

NikkiWines commented 10 months ago

Anyway, @FitseTLT your solution looks good to me! Adding the relevant labels and assigning you 👍

melvin-bot[bot] commented 10 months ago

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot[bot] commented 10 months ago

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
[ ] This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
[ ] This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

melvin-bot[bot] commented 10 months ago

Job added to Upwork: https://www.upwork.com/jobs/~016b88b71e8f06ec60

melvin-bot[bot] commented 10 months ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

melvin-bot[bot] commented 10 months ago

📣 @shubham1206agra 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job

melvin-bot[bot] commented 10 months ago

📣 @FitseTLT 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

shubham1206agra commented 10 months ago

@FitseTLT can you raise a PR quickly? So I can also start recording the videos also

FitseTLT commented 10 months ago

K 👍

situchan commented 10 months ago

I think this should be handled as regression.

The correct flow would be:

original contributor raise PR
original C+ review PR
new contributor get partial bounty for their solution being used

cc: @mallenexpensify (as we were discussing this process recently)

shubham1206agra commented 10 months ago

@situchan above flow only applies only when the original author raised the PR without another proposal getting selected, and uses the solution from the proposal here

shubham1206agra commented 10 months ago

@FitseTLT, Can you publish the PR right now? You can complete the checklist later.

melvin-bot[bot] commented 10 months ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 10 months ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.15-5 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/33439

If no regressions arise, payment will be issued on 2023-12-29. :confetti_ball:

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

[ ] External issue reporter
[ ] Contributor that fixed the issue
[ ] Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@FitseTLT requires payment automatic offer (Contributor)
@shubham1206agra requires payment automatic offer (Reviewer)

melvin-bot[bot] commented 10 months ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@shubham1206agra] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@shubham1206agra] Determine if we should create a regression test for this bug.
[ ] [@shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ] [@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

melvin-bot[bot] commented 10 months ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.16-5 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/33439

If no regressions arise, payment will be issued on 2024-01-02. :confetti_ball:

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

[ ] External issue reporter
[ ] Contributor that fixed the issue
[ ] Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@FitseTLT requires payment automatic offer (Contributor)
@shubham1206agra requires payment automatic offer (Reviewer)

melvin-bot[bot] commented 10 months ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@shubham1206agra] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@shubham1206agra] Determine if we should create a regression test for this bug.
[ ] [@shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ] [@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

melvin-bot[bot] commented 10 months ago

Issue is ready for payment but no BZ is assigned. @puneetlath you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

puneetlath commented 10 months ago

Hm, @isabelastisser is already assigned. Not sure why it added me, but going to remove myself.

shubham1206agra commented 10 months ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[x] [@shubham1206agra] The PR that introduced the bug has been identified. Link to the PR: https://github.com/Expensify/App/pull/32901
[x] [@shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/32901/files#r1440603557
[x] [@shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not required
[x] [@shubham1206agra] Determine if we should create a regression test for this bug. No as this was deploy blocker
[x] [@shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[x] [@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

isabelastisser commented 10 months ago

Hey @shubham1206agra, please accept the offer in Upwork and I will process the payment. Thanks!

shubham1206agra commented 10 months ago

@isabelastisser Accepted

isabelastisser commented 10 months ago

The payment was made in Upwork. All set!

mallenexpensify commented 10 months ago

@isabelastisser can you please post the amounts that were paid, to whom and their roles? I have this set at a TextExpander that I fill out each time.

Contributor: @ paid $ via Upwork Contributor+: @

isabelastisser commented 10 months ago

@mallenexpensify

Contributor: @FitseTLT paid $500 via Upwork Contributor+: @shubham1206agra paid $500 via Upwork

Expensify / App