search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3k stars 2.51k forks source link

Room - Room chat avatar is different for user who creates room & who has been invited to room #33470

Open lanitochka17 opened 5 months ago

lanitochka17 commented 5 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.15-4 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:

Action Performed:

  1. Launch app
  2. Tap fab--start chat
  3. Tap room
  4. Enter room name and select a workspace with custom avatar
  5. Tap create room
  6. Tap header
  7. Tap members---Invite
  8. Invite user X to room 9 .Navigate to LHN and note avatar of room chat
  9. Go to https://staging.new.expensify.com/
  10. Login as user X
  11. Note avatar of room chat

Expected Result:

Room chat avatar must be same for user who creates room and for user who has been invited to room

Actual Result:

Room chat avatar is different for user who creates room and for user who has been invited to room

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/fbc7a3bd-7ef8-4165-83c4-072d8c245c11

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~013499a52b4634b0ed
  • Upwork Job ID: 1737991692071854080
  • Last Price Increase: 2023-12-29
Issue OwnerCurrent Issue Owner: @grgia
grgia commented 2 months ago

the partial compensation sounds good to me

@getusha I agree with this

grgia commented 2 months ago

https://github.com/Expensify/Auth/pull/9708/files For personal reference, this is where the policyAvatar was added (internal repo). Looking to see if there's an issue with this flow.

@getusha @dukenv0307 what's being returned in your testing?

grgia commented 2 months ago

@getusha @dukenv0307 I got a chance to get dev set up and tested on your test branch and cannot replicate the bug, could you reiterate the problem?

Screenshot 2024-03-06 at 4 48 46 PM
getusha commented 2 months ago

@grgia

  1. Invite User B to a room
  2. After user B is invited to the room
  3. Change the avatar of the workspace linked to the room

The new avatar will not be synced that's the issue, it loads fine first time.

https://github.com/Expensify/App/assets/75031127/cf61eb46-1da1-4197-8bad-d07d77da8496

dukenv0307 commented 2 months ago

@grgia please check this when you get a chance 🙏

alexpensify commented 2 months ago

@grgia - I think you are back online this week, we need feedback here. Thanks!

grgia commented 2 months ago

@dukenv0307 @getusha could you rephrase your question? Could you catch me up on what is required? Is this internal only?

dukenv0307 commented 1 month ago

@grgia We have a bug mentioned in https://github.com/Expensify/App/issues/33470#issuecomment-1983637810, it seems like the policyAvatar is not updated when the user changes the workspace avatar. Please check this 🙏

dukenv0307 commented 1 month ago

@grgia friendly bump

grgia commented 1 month ago

it seems like the policyAvatar is not updated when the user changes the workspace avatar

Which command? @dukenv0307

dukenv0307 commented 1 month ago

@grgia Currently, when user A changes the avatar of the room, Pusher does not update policyAvatar until the openReport API is called.

alexpensify commented 1 month ago

Weekly Update: @grgia does this recent reply answer the question?

alexpensify commented 1 month ago

Weekly Update: Waiting for feedback here

melvin-bot[bot] commented 3 weeks ago

This issue has not been updated in over 15 days. @alexpensify, @grgia, @getusha, @dukenv0307 eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

alexpensify commented 3 weeks ago

Moving back to Weekly

grgia commented 2 weeks ago

@dukenv0307 what would we like to happen instead here?

dukenv0307 commented 2 weeks ago

@grgia Can you check this comment We need Pusher update policyAvatar to user B can update avatar without call API openReport

dukenv0307 commented 6 days ago

@grgia Can you please check my comment above https://github.com/Expensify/App/issues/33470#issuecomment-2089983598?

alexpensify commented 4 days ago

Heads up, I will be offline until Tuesday, May 28, 2024, and will not actively watch over this GitHub during that period.

If anything urgent is needed here, please ask for help in the #expensify-open-source Slack Room-- thanks!