[HOLD for payment 2024-01-11] [$500] IOU - Can't download receipt image

lanitochka17 commented 10 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.15.1 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:

Action Performed:

Navigate to https://staging.new.expensify.com/
Navigate to a workspace chat
Go offline
Do a scan IOU
Download the image

Expected Result:

I should be able to download it

Actual Result:

Can't download the receipt image

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/5d116036-7648-453d-952e-ce43cb0752e8

View all open jobs on GitHub

melvin-bot[bot] commented 10 months ago

Job added to Upwork: https://www.upwork.com/jobs/~01886b4eae0edf845e

melvin-bot[bot] commented 10 months ago

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot[bot] commented 10 months ago

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
[ ] This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
[ ] This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

melvin-bot[bot] commented 10 months ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

namhihi237 commented 10 months ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

Can not download receipt when offline

What is the root cause of that problem?

When we offline the image doest not upload to S3 show the source file is local but we have isAuthTokenRequired is true, so the URL has a encryptedSourceUrl. That is wrong

We do not return the isLocalFile https://github.com/Expensify/App/blob/659f509b7e1093252d7c2ea14d0082ee78dd6503/src/libs/ReceiptUtils.ts#L45-L49 So here, isAuthTokenRequired is true with the local file

https://github.com/Expensify/App/blob/659f509b7e1093252d7c2ea14d0082ee78dd6503/src/components/ReportActionItem/ReportActionItemImage.js#L87

What changes do you think we should make in order to solve the problem?

We shouldupdate

const isLocalFile = path.startsWith('blob:') || path.startsWith('file:');
return {thumbnail: null, image: path, isLocalFile };

What alternative solutions did you explore? (Optional)

We can always return isLocalFile for the rest case

bfitzexpensify commented 10 months ago

@shubham1206agra what do you think of @namhihi237's proposal? Is this a fairly simple change? I think it would be ideal for this to work, but this feels like a fairly unusual flow for someone to follow

shubham1206agra commented 10 months ago

@shubham1206agra what do you think of @namhihi237's proposal? Is this a fairly simple change? I think it would be ideal for this to work, but this feels like a fairly unusual flow for someone to follow

Actually, it can be quite common for someone to follow this route. Example is what if I clicked the image of a receipt, and I just want a copy of the image in my local storage too. Then this flow can be followed

shubham1206agra commented 10 months ago

@namhihi237's proposal looks good to me.

🎀👀🎀 C+ reviewed

melvin-bot[bot] commented 10 months ago

Triggered auto assignment to @arosiclair, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

melvin-bot[bot] commented 10 months ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 10 months ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.21-4 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/33585

If no regressions arise, payment will be issued on 2024-01-11. :confetti_ball:

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

[ ] External issue reporter
[ ] Contributor that fixed the issue
[ ] Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@namhihi237 requires payment (Needs manual offer from BZ)
@shubham1206agra requires payment (Needs manual offer from BZ)

melvin-bot[bot] commented 10 months ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@shubham1206agra] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@shubham1206agra] Determine if we should create a regression test for this bug.
[ ] [@shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ] [@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

melvin-bot[bot] commented 10 months ago

Issue is ready for payment but no BZ is assigned. @sakluger you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

melvin-bot[bot] commented 10 months ago

Payment Summary

[Upwork Job]()

Contributor: @namhihi237 paid $500 via Upwork (Offer)
Reviewer / C+: @shubham1206agra paid $500 via Upwork (Offer)

BugZero Checklist (@sakluger)

[x] I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
[x] I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
[ ] I have paid out the Upwork contracts or cancelled the ones that are incorrect
[x] I have verified the payment summary above is correct

sakluger commented 10 months ago

Sent offers via Upwork. @shubham1206agra could you please complete the BZ checklist?

namhihi237 commented 10 months ago

@sakluger accepted

sakluger commented 10 months ago

Thanks @namhihi237! I completed your payment.

shubham1206agra commented 10 months ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[x] [@shubham1206agra] The PR that introduced the bug has been identified. Link to the PR: https://github.com/Expensify/App/pull/30747
[x] [@shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/30747/files#r1450354884
[x] [@shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not required
[x] [@shubham1206agra] Determine if we should create a regression test for this bug. No as this is an edge case missed by ttps://github.com/Expensify/App/pull/30747
[x] [@shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ] [@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

shubham1206agra commented 10 months ago

@sakluger Checklist done

sakluger commented 10 months ago

Thank you! All paid out 👍

Expensify / App