[$500] mWeb/Safari - Workspace - Expensify site is visible while doing the Plaid bank account steps

lanitochka17 commented 8 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.16.3 Reproducible in staging?: Y Reproducible in production?: Unable to check the Plaid connection in prod If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:

Action Performed:

Navigate to https://staging.new.expensify.com/
Log in with an expensifail account
Create a workspace
Start adding a bank account (Connect with Plaid)

Expected Result:

It shouldn't be visible until the Plaid process is finished

Actual Result:

Expensify site is visible for a short time while doing the Plaid bank account steps

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[x] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/7718431a-6aa2-400c-bf8f-dbf7f6b50139

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01dd088023ec934a0c
Upwork Job ID: 1738686198818414592
Last Price Increase: 2024-01-06

melvin-bot[bot] commented 8 months ago

Job added to Upwork: https://www.upwork.com/jobs/~01dd088023ec934a0c

melvin-bot[bot] commented 8 months ago

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot[bot] commented 8 months ago

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
[ ] This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
[ ] This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

melvin-bot[bot] commented 8 months ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

github-actions[bot] commented 8 months ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

melvin-bot[bot] commented 8 months ago

Triggered auto assignment to @hayata-suenaga (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

melvin-bot[bot] commented 8 months ago

Current assignee @s77rt is eligible for the External assigner, not assigning anyone new.

mountiny commented 8 months ago

I dont think this is a deploy blocker but leaving this open to check into the root cause

hoangzinh commented 8 months ago

I think this issue is not a bug, but it's how an integration works. Same as when a user sign in with Google, after clicking the "Sign in with Google" button => it will navigate to Google to authenticate => and then redirect back to our Expensify App to process sign in/up.

s77rt commented 8 months ago

This seems to be dependent on the selected bank. I tried to reproduce this but it worked just fine. Either way I think we should close this.

https://github.com/Expensify/App/assets/16493223/de6ffa11-c95a-44e8-b960-706d1eb1144a

s77rt commented 8 months ago

Not overdue. To be closed

melvin-bot[bot] commented 8 months ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

s77rt commented 8 months ago

Same ^

s77rt commented 8 months ago

Same ^ To be closed

melvin-bot[bot] commented 8 months ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

s77rt commented 8 months ago

@anmurali or @hayata-suenaga Can you please close this? (not a bug)

hayata-suenaga commented 8 months ago

sorry I have been OOO. Yes I agree we can close this

Expensify / App