[HOLD for payment 2024-01-04] [$250] Android - Workspace - Card icon is shown as a green square icon

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.17-1 Reproducible in staging?: y Reproducible in production?: n If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:

Action Performed:

1. Launch New Expensify app.
2. Go to Settings > Workspaces > any workspace.

Expected Result:

All icons are displayed properly.

Actual Result:

Card icon is shown as a green square icon.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [x] Android: Native
• [ ] Android: mWeb Chrome
• [ ] iOS: Native
• [ ] iOS: mWeb Safari
• [ ] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b583b60c7afce86e
• Upwork Job ID: 1739665839943921664
• Last Price Increase: 2023-12-26
• Automatic offers:
• situchan | Contributor | 28070426
• aswin-s | Contributor | 28070450

Issue Owner

Current Issue Owner: @JmillsExpensify

[github-actions[bot]]

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot[bot]]

Triggered auto assignment to @mountiny (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[mountiny]

Potentially related to the expo image update, but its odd this is only happening on native android

[mountiny]

QA confirmed only happening on native android

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~01b583b60c7afce86e

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

[mountiny]

Actually found that this will most likely be related to the expo image update as there were some other icons which had similar issue https://expensify.slack.com/archives/C01GTK53T8Q/p1703186271886829

[mountiny]

cc @akinwale @WojtekBoman

[melvin-bot[bot]]

Upwork job price has been updated to $250

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Card icon is shown as a green square icon.

What is the root cause of that problem?

There card icon path has a typo, it's expensifycard

What changes do you think we should make in order to solve the problem?

Should be expensify-card

What alternative solutions did you explore? (Optional)

NA

[mountiny]

Still looking for proposals

[Tony-MK]

On the dev environment, it seems like it works properly.

[mountiny]

I do not have android to confirm this in staging/ prod

[mountiny]

Thanks! @Tony-MK Do you for sure have the latest main with expo-image installed?

[shubham1206agra]

Not able to repro this on emulator

[Pujan92]

Same for me too.

[situchan]

@mountiny can we get android apk for staging build? Contributors don't have access to it

[mountiny]

Lets check on some adhoc build waiting for some to finish

[Tony-MK]

@mountiny It was version v1.4.17-1 Develop but it seems other contributors have verified it.

[ishpaul777]

Tested on latest main on physical device, not reproducable.

[mountiny]

I am making an adhoc buil don this up to date PR so you could test there https://github.com/Expensify/App/pull/33604

[situchan]

reproduced in release build. Not happening in debug build. This happens on all android devices, no matter real device or emulator.

[shubham1206agra]

Yes In release build, it happens

[shubham1206agra]

Tested on latest main on physical device, not reproducable.

@ishpaul777 What error are you getting here?

[ishpaul777]

The proptype error is unrelated appears when click on bank account option

https://github.com/Expensify/App/assets/104348397/5ecdeb47-24d7-4af8-96fc-7a36a3d3de32

RC for the error is undefined proptype value is assigned in IconSection introduced in https://github.com/Expensify/App/commit/5e800a2289c1cd2c4a1d7a19ab53b0791a776f3d https://github.com/Expensify/App/blob/92501dc7f0288dc88016159d40ed693547222284/src/components/Section/IconSection.js#L8-L12

[aimane-chnaif]

RC for the error is undefined proptype value is assigned in IconSection introduced in https://github.com/Expensify/App/commit/5e800a2289c1cd2c4a1d7a19ab53b0791a776f3d

it's known and will be fixed separately during TS migration. Btw not urgent since it's just console warning

[kbecciv]

@mountiny Issue is reported on:

1. Samsung Galaxy Note 10+ / Android 12
2. Samsung Galaxy Z Fold 4 / Android 14
3. Samsung Galaxy A02s/12
4. Pixel 6 / Android 14
5. Pixel 5 / Android 14

[mountiny]

@shubham1206agra @ishpaul777 @situchan any proposals for this one? I think if this would be a last DB, I would remove the label as its minor but would be nice to fix it

[aswin-s]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Card icon on Workspace home screen is shown as a green square icon.

What is the root cause of that problem?

TheExpensifyCard icon file name is expensifycard.svg. There is another asset named expensify-card.svg which is mapped to ExpensifyCardImage. Looks like after release build there is a name conflict that causes the image assets to get swapped/overwritten.

What changes do you think we should make in order to solve the problem?

Simply rename the file to expensify-card-icon.svg and update the import in Expensicons.ts like below

import ExpensifyCard from '@assets/images/expensify-card-icon.svg';

To verify the fix generate a release build using below command and check the Workspace screen.

npx react-native run-android  --mode release

What alternative solutions did you explore? (Optional)

None (edited)

[mountiny]

@aswin-s interesting, did you test this theory?

[aswin-s]

@mountiny Yes, I generated a release build locally and tested on simulator. I could simulate the green square icon on simulator before the fix too.

[melvin-bot[bot]]

📣 @situchan 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot[bot]]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot[bot]]

Bug0 Triage Checklist (Main S/O)

• [ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• [ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• [ ] This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• [ ] This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• [ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[mountiny]

@aswin-s Can you make a draft PR so we can generate adhoc build for testing?

[aswin-s]

@mountiny Done!

[melvin-bot[bot]]

📣 @aswin-s 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot[bot]]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.17-8 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/33629

If no regressions arise, payment will be issued on 2024-01-03. :confetti_ball:

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• [ ] External issue reporter
• [ ] Contributor that fixed the issue
• [ ] Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @aswin-s requires payment automatic offer (Contributor)
• @situchan requires payment automatic offer (Contributor)

[melvin-bot[bot]]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [ ] [@situchan] The PR that introduced the bug has been identified. Link to the PR:
• [ ] [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [ ] [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [ ] [@situchan] Determine if we should create a regression test for this bug.
• [ ] [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [ ] [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.18-8 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/33629

If no regressions arise, payment will be issued on 2024-01-04. :confetti_ball:

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• [ ] External issue reporter
• [ ] Contributor that fixed the issue
• [ ] Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @aswin-s requires payment automatic offer (Contributor)
• @situchan requires payment automatic offer (Contributor)

[melvin-bot[bot]]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [ ] [@situchan] The PR that introduced the bug has been identified. Link to the PR:
• [ ] [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [ ] [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [ ] [@situchan] Determine if we should create a regression test for this bug.
• [ ] [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [ ] [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot[bot]]

@JmillsExpensify, @aswin-s, @mountiny, @situchan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot[bot]]

@JmillsExpensify, @aswin-s, @mountiny, @situchan 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[mountiny]

@situchan can you please complete the checklist here?

Summary is $250 to @aswin-s and $250 to @situchan

[melvin-bot[bot]]

@JmillsExpensify, @aswin-s, @mountiny, @situchan 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

[situchan]

Not able to find offending PR but from deploy checklist, I think expo-image PR is the culprit. This was caught by QA team during regression test so no need new regression test. To prevent such bugs further, it would be good to add eslint rule to avoid duplicated resource file names after excluding -, but not a big deal.

[mountiny]

@JmillsExpensify ready for payment

[melvin-bot[bot]]

@JmillsExpensify, @aswin-s, @mountiny, @situchan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot[bot]]

@JmillsExpensify, @aswin-s, @mountiny, @situchan Eep! 4 days overdue now. Issues have feelings too...