Workspace - Plaid process auto starts after adding a personal bank account

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.21.1 Reproducible in staging?: y Reproducible in production?: Team can not verify production If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:

Action Performed:

1. Navigate to https://staging.new.expensify.com/
2. Create a workspace
3. Navigate to settings - wallet
4. Click on the "Enable wallet" button
5. Complete the process with Chase bank
6. Navigate to the workspace settings
7. Click on the "Bank account" button

Expected Result:

Plaid process shouldn't start without clicking on it's button.

Actual Result:

Plaid process auto starts after adding a personal bank account.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android: Native
• [x] Android: mWeb Chrome
• [ ] iOS: Native
• [x] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/93399543/be51e2ff-732e-402f-967c-799a11d4dc43

View all open jobs on GitHub

[github-actions[bot]]

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot[bot]]

Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[Pujan92]

Seems a backend issue where for wallet OpenPlaidBankAccountSelector api it sets the unwanted reimbursementAccount BankAccountStep data.

https://github.com/Expensify/App/blob/3b385efb37c2d35965dbc58469a7725da1f673aa/src/components/AddPlaidBankAccount.js#L191

As OpenPlaidBankAccountSelector common for reimbursementAccount bank account setup and wallet bank account flow, we can pass an extra param which can help to decide whether to set reimbursementAccount BankAccountStep or not.

[marcaaron]

Seems a backend issue where for wallet OpenPlaidBankAccountSelector api it sets the unwanted reimbursementAccount BankAccountStep data

This is an old change though (~ 1 year) so I would guess either the same happens on production or a more recent frontend change causes this.

A code comment says:

If there are accounts, then return the processed list of bank accounts as well as the owners in case of withdrawal setup.

Sounds like the expectation is that we would just land in the Add bank account page with the accounts already available in the selector? cc @nkuoch who might remember for sure.

The frontend for this has not been changed since the last deploy so I think this is a non-blocker. The last material changed looks to be here. So, maybe we introduced some regression about how this works.

[melvin-bot[bot]]

Triggered auto assignment to @peterdbarkerUK (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot[bot]]

Bug0 Triage Checklist (Main S/O)

• [x] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• [x] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• [x] This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• [x] This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• [x] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot[bot]]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot[bot]]

@peterdbarkerUK Eep! 4 days overdue now. Issues have feelings too...

[peterdbarkerUK]

Checking in VIP-Split

[melvin-bot[bot]]

@peterdbarkerUK Huh... This is 4 days overdue. Who can take care of this?

[peterdbarkerUK]

Coming from here - this is expected behaviour.