search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.34k stars 2.77k forks source link

[Unvalidated Sign-Up] Include a magic link in every unread message summary footer and use it for any CTAs in the email as well #34166

Closed anmurali closed 3 months ago

anmurali commented 8 months ago

Problem: Email notifications from New Dot have links to go to new.expensify.com to respond, or approve, or pay etc. Clicking on this simply brings you to new.expensify.com like any other site visitor and you have to sign in from scratch. This feels like a sub optimal experience since we already know the user (we emailed them), and we know where they need to go (we included the CTA in the email), and yet we force them to sign in from scratch and navigate to where they need to go on their own

Solution:

  1. IF the account is unvalidated (ie, nobody has ever signed in)
    • THEN make every link we send via UnreadMessageSummary into a magic link (because there's nothing in the account yet to steal)
  2. However, after you click it the first time, you have an infinite session, so in theory you shouldn't need a magic link when clicking the link the next time. This would mean:
    • The first link you click drops you straight into the product
    • The second link requires authentication with a magic link, if you don't already have an infinite session (eg, if you are on a new device)
  3. Use that same logic for any link that would be used for any "calls to action" in the body of the email, which will soon be refactored to look exactly like the product UI.
melvin-bot[bot] commented 8 months ago

Triggered auto assignment to @tylerkaraszewski (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

tylerkaraszewski commented 8 months ago

Sorry Melvin, my plate is full.

MitchExpensify commented 8 months ago

Looking for help here https://expensify.slack.com/archives/CC7NECV4L/p1704845562604679?thread_ts=1704818282.056719&cid=CC7NECV4L

techievivek commented 8 months ago

I can work on this one. Thanks. 🙌

melvin-bot[bot] commented 8 months ago

@techievivek Whoops! This issue is 2 days overdue. Let's get this updated quick!

techievivek commented 8 months ago

Not overdue, working on it. Latest discussion is here: https://expensify.slack.com/archives/C05NJ4SLBMF/p1705328587735239?thread_ts=1704221792.809129&cid=C05NJ4SLBMF

melvin-bot[bot] commented 8 months ago

@techievivek Whoops! This issue is 2 days overdue. Let's get this updated quick!

MitchExpensify commented 8 months ago

Asking for an update here https://expensify.slack.com/archives/C05NJ4SLBMF/p1705701594874099

melvin-bot[bot] commented 7 months ago

@techievivek 12 days overdue. Walking. Toward. The. Light...

techievivek commented 7 months ago

Sorry, I couldn't prioritize this today. I will work on it tomorrow :for-sure:, I also replied to the thread here: https://expensify.slack.com/archives/C05NJ4SLBMF/p1706595259842319

techievivek commented 7 months ago

Update for today: https://expensify.slack.com/archives/C05NJ4SLBMF/p1706667468085419

techievivek commented 7 months ago

Added an updated here: https://expensify.slack.com/archives/C05NJ4SLBMF/p1707141774434789?thread_ts=1706915414.620219&cid=C05NJ4SLBMF

melvin-bot[bot] commented 7 months ago

@techievivek Whoops! This issue is 2 days overdue. Let's get this updated quick!

techievivek commented 7 months ago

Not overdue, I created a GH for the frontend changes https://github.com/Expensify/App/issues/36325, and posted an updated here: https://expensify.slack.com/archives/C05NJ4SLBMF/p1707530916220149

melvin-bot[bot] commented 7 months ago

@techievivek Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

techievivek commented 7 months ago

App PR is deployed to staging and Web-E PR is ready for review https://github.com/Expensify/Web-Expensify/pull/40734

melvin-bot[bot] commented 7 months ago

@techievivek Whoops! This issue is 2 days overdue. Let's get this updated quick!

techievivek commented 7 months ago

Web-E PR is merged 🎉, posted an update in Slack here: https://expensify.slack.com/archives/C05NJ4SLBMF/p1708135487521139

melvin-bot[bot] commented 6 months ago

@techievivek Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] commented 6 months ago

@techievivek Huh... This is 4 days overdue. Who can take care of this?

MitchExpensify commented 6 months ago

Shall we close or what else are we waiting on?

melvin-bot[bot] commented 6 months ago

@techievivek Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

melvin-bot[bot] commented 6 months ago

@techievivek 10 days overdue. I'm getting more depressed than Marvin.

melvin-bot[bot] commented 6 months ago

@techievivek 12 days overdue. Walking. Toward. The. Light...

melvin-bot[bot] commented 6 months ago

This issue has not been updated in over 14 days. @techievivek eroding to Weekly issue.

melvin-bot[bot] commented 5 months ago

This issue has not been updated in over 15 days. @techievivek eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

trjExpensify commented 4 months ago

👋 I think we should track this issue along with the "native" sign-up not requiring validation/magic code, so I'm going to bring it under the [Unvalidated Sign-up] project and bump up the priority to the August release. I don't think we necessarily need this one for XeroCon, but we should minimally have it re-implemented for Q2 where we expect to see more invited users to NewDot.

On that topic, @techievivek you might be interested in this. It would be super valuable for the XeroCon conference, so let us know there if you're interested in getting that work over the line. Thanks!

trjExpensify commented 4 months ago

I'm going to remove the Reviewing label on this issue, as a new PR is required to re-implement this one and I can't see it linked. I'd probably also suggest just closing https://github.com/Expensify/Expensify/issues/374479 and using this one where the context of what we're trying to achieve is in the OP from Anu. 👍

techievivek commented 4 months ago

As discussed here https://expensify.slack.com/archives/C036QM0SLJK/p1716211040969329?thread_ts=1715336674.469839&cid=C036QM0SLJK, I will review this and the main GH https://github.com/Expensify/App/issues/30794 along with the linked PR by tomorrow.

quinthar commented 3 months ago

Excited for this! Let's chat in realtime here: https://expensify.slack.com/archives/C066HJM2CAZ/p1716892649705859

techievivek commented 3 months ago

Still discussing potential solution on above thread.

techievivek commented 3 months ago

Web-E PR here: https://github.com/Expensify/Web-Expensify/pull/42241

techievivek commented 3 months ago

Both Auth and Web-E PRs are ready for review here. Web-E: https://github.com/Expensify/Web-Expensify/pull/42241 Auth: https://github.com/Expensify/Auth/pull/11119

techievivek commented 3 months ago

Auth PR is deployed to PROD. Web-E we will get it merge it today.

melvin-bot[bot] commented 3 months ago

@techievivek Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] commented 3 months ago

@techievivek Eep! 4 days overdue now. Issues have feelings too...

techievivek commented 3 months ago

This is done and released under Xerocon milestone.