Open lanitochka17 opened 9 months ago
Ah! This is outdated, request money is now submit expense. Sorry I missed that, as it stands I can't recreate this and with submit expense I can recreate this.
Sorry, I don't understand this:
Sorry I missed that, as it stands I can't recreate this and with submit expense I can recreate this.
@trjExpensify @slafortune This is still reproducible in latest main
Cool, thanks. Seems like we still have to look into this then, @roryabraham. On the basis of this, I'm moving it back to weekly as we focus on polish for #wave-collect.
It's not clear how to reproduce this now, since the two submitted manual requests are batched together and it's not clear how to pay the 2nd one without paying the 1st:
Same deal with P2P requests:
so this is indeed no longer reproducible
@tienifr feel free to provide updated reproduction steps if you'd like
I suspect you had the workspace set to instant submit @roryabraham, so this needs a coupla' pre-steps to have multiple reports:
Workflows
Delay submissions
Yes - I can still recreate this when setting delay submission. I've updated the test steps to include that and leaving submit and close.
chatted with @trjExpensify in slack, it's unlikely I'll be able to prioritize this one this week so we may look for another volunteer
Looking for a volunteer here - https://expensify.slack.com/archives/C049HHMV9SM/p1725553790788449
PayMoneyRequest
sample responseOk, so I think that the hasOutstandingChildRequest
Onyx update in PayMoneyRequest
comes from here, which in turn comes from the giant getChats
function. In there, I think I might need to unpack ReportItem::isAwaitingActionFromCurrentUser a bit more
Update: I think the linked IOU is not being found here when it should be. Testing in focus mode right now, but also will need to test in most recent mode too.
Also, maybe this can be DRYed up but this is performance-sensitive code so I might default to trying to just get this working rather than rocking the boat too much.
@thienlnam volunteered to grab this one from me since tomorrow's my last day before parental leave and I'm focusing on trying to complete (or almost complete) CP to Prod
Nice one, thank you Jack!
Been sidetracked wrapping up things for Hubspot doc, but will look into this in the next couple o days
Summarizing some things in the thread for my own investigation
Auth flow
hasOutstandingChildRequest
is calculated is via ReportItem::isAwaitingActionFromCurrentUser
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.27-1 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:
Action Performed:
Precondition: There is a Collect workspace on Old Dot with admin and employee pre-steps to have multiple reports for testing -
Expected Result:
In Step 4, green dot should still appear for the workspace chat in LHN because there is still unpaid report
Actual Result:
In Step 4, LHN for the workspace chat with unpaid report does not show green dot after paying one of the reports. It only shows green dot when revisiting main chat from the expense report
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/78819774/9fa5d1b7-103b-457a-8c67-b280b0ddeba8
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @roryabraham