search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.03k stars 2.54k forks source link

[$500] Desktop - Notifications - Notification was not shown when user received the first message in a new chat #34876

Closed kbecciv closed 2 weeks ago

kbecciv commented 4 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.28-0 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4206591&group_by=cases:section_id&group_order=asc&group_id=295000 Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:

Action Performed:

Precondition: there should not be the existing conversation between users

  1. Open app on the main testing device
  2. From the secondary account, which does not have a conversation with the main testing device account, send a message to the main testing device.

Expected Result:

The notification should be shown when first message was received in a new chat

Actual Result:

Notification was not shown when user received the first message in a new chat

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/93399543/033afda3-701f-4d22-a600-8df02db9aaf6

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01f42ec145a22f6147
  • Upwork Job ID: 1749416702776217600
  • Last Price Increase: 2024-01-29
melvin-bot[bot] commented 4 months ago

Job added to Upwork: https://www.upwork.com/jobs/~01f42ec145a22f6147

melvin-bot[bot] commented 4 months ago

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot[bot] commented 4 months ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @cubuspl42 (External)

kbecciv commented 4 months ago

We think that this bug might be related to #vip-vsb CC @quinthar

subhampanja2 commented 4 months ago

Working fine for me.

Screenshot 2024-01-22 at 9 54 41 PM Screenshot 2024-01-22 at 9 55 57 PM

I did exactly same as mentioned. how to reproduce it ?

miljakljajic commented 4 months ago

This actually happened to me this morning with an actual message (video linked), but I am not able to reproduce it with my test account: https://github.com/Expensify/App/assets/28715117/19ae0045-2e50-4772-ac4f-1b0d28e62511

melvin-bot[bot] commented 4 months ago

@cubuspl42, @miljakljajic Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] commented 4 months ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

cubuspl42 commented 4 months ago

I don't have high expectations of this being fixed externally (if at all).

WestDon commented 4 months ago

Proposal

Please re-state the problem that we are trying to solve in this issue

No notification for newly created channel from one account to another

What is the root cause of that problem?

The problem is with wrong data coming from pusher when creating channel

What changes do you think we should make in order to solve the problem?

We need check and update server code to make sure property in report with name notificationPreference correct -'always', now its coming 'daily' that is incorrect and cancel notification for that report

melvin-bot[bot] commented 4 months ago

📣 @WestDon! 📣 Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details. Screen Shot 2022-11-16 at 4 42 54 PM Format: 
    Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
WestDon commented 4 months ago

Contributor details Your Expensify account email: andrei.vaschuk94@gmail.com Upwork Profile Link: https://www.upwork.com/freelancers/~016e3bd7b5d3e067ce

melvin-bot[bot] commented 4 months ago

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

miljakljajic commented 4 months ago

posted in our internal VSB channel - I'll see about whether we can work on this one externally or not

quinthar commented 3 months ago

Sounds great, adding it to VSB as LOW.

melvin-bot[bot] commented 3 months ago

@cubuspl42 @miljakljajic this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

melvin-bot[bot] commented 3 months ago

@cubuspl42, @miljakljajic Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

miljakljajic commented 3 months ago

Updated to a weekly given the lower priority, waiting to be picked

melvin-bot[bot] commented 3 months ago

@cubuspl42 @miljakljajic this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

melvin-bot[bot] commented 3 months ago

@cubuspl42, @miljakljajic Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

miljakljajic commented 3 months ago

still waiting

melvin-bot[bot] commented 3 months ago

@cubuspl42 @miljakljajic this issue is now 4 weeks old and preventing us from maintaining WAQ. This should now be your highest priority. Please post below what your plan is to get a PR in review ASAP. Thanks!

melvin-bot[bot] commented 3 months ago

Current assignee @cubuspl42 is eligible for the Internal assigner, not assigning anyone new.

melvin-bot[bot] commented 3 months ago

@cubuspl42, @miljakljajic Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] commented 3 months ago

@cubuspl42, @miljakljajic 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

miljakljajic commented 3 months ago

Should we increase the bounty for this one?

cubuspl42 commented 3 months ago

🎀 👀 🎀

melvin-bot[bot] commented 3 months ago

Triggered auto assignment to @flodnv, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

cubuspl42 commented 3 months ago

@flodnv

I would say that these glitches result from the overall Expensify notification architecture, which is unlikely to be solved externally. On the other hand, I don't have much faith in this being fixed internally either because of the priorities and "lack of hands".

Shouldn't we just close this?

miljakljajic commented 3 months ago

@flodnv what do you think?

flodnv commented 2 months ago

It's part of the roadmap as low priority. It can stay as such for a few months which is not a problem.

TheRealKraytonian commented 2 months ago

I will try and tackle this for $1000? I want 2 weeks to do it?

melvin-bot[bot] commented 2 months ago

📣 @TheRealKraytonian! 📣 Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details. Screen Shot 2022-11-16 at 4 42 54 PM Format: 
    Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
TheRealKraytonian commented 2 months ago

Contributor details Your Expensify account email: kraytonianmedia@gmail.com Upwork Profile Link: (https://www.upwork.com/freelancers/~01639918f2e1bb6b6a)

melvin-bot[bot] commented 2 months ago

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

TheRealKraytonian commented 2 months ago

lets do this :)

cubuspl42 commented 2 months ago

@TheRealKraytonian Welcome to Expensify! Please ensure to read the contributing guidelines and check out a few other issues with other contributors' proposals to get a feeling of how the Expensify process works.

cubuspl42 commented 2 months ago

This specific issue is marked "Internal" and is not open for proposals.

TheRealKraytonian commented 2 months ago

How can I gain access to the slack?

cubuspl42 commented 2 months ago

@TheRealKraytonian It's described in the contributing guidelines.

TheRealKraytonian commented 2 months ago

I emailed contributors username I believe and heard nothing back @cubuspl42

cubuspl42 commented 2 months ago

Please wait patiently; this is a human-managed process. In the meantime, find an issue open for proposals that you'd like to work on. Slack access won't give you much on its own. Let's not hijack this thread anymore, this is an internal issue and the comments should be related to it.

Preferably, you should hide your comments in this thread as "off-topic".

melvin-bot[bot] commented 2 weeks ago

@kbecciv, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.