[HOLD for payment 2024-07-26][$500] When amending the amount, if the last digit is a 0, we don't show it.

kavimuru commented 10 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.29-0 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @twisterdotcom Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1705662590072039

Action Performed:

create an expense report
Open the report and edit the amount so that last decimal digit is 0 (e.g. 23.20)
Again open and see the amount

Expected Result:

Should see 0 at the end

Actual Result:

"0" is missing

Workaround:

Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/43996225/9bb584e7-49a7-4968-ab33-db9e71b281f8

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0178a9407eab9689fe
Upwork Job ID: 1749451650573455360
Last Price Increase: 2024-01-29
Automatic offers:

abzokhattab | Contributor | 28129136

Issue Owner

Current Issue Owner: @eVoloshchak

sakluger commented 6 months ago

The PR is still in review.

sakluger commented 6 months ago

@eVoloshchak it looks like we're waiting for your review on the PR. Could you please take a look?

melvin-bot[bot] commented 6 months ago

@dangrous, @sakluger, @eVoloshchak, @abzokhattab Whoops! This issue is 2 days overdue. Let's get this updated quick!

sakluger commented 6 months ago

Still in review.

melvin-bot[bot] commented 6 months ago

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

sakluger commented 6 months ago

@JmillsExpensify assigning you to help watch this issue while I'm OOO through May 31.

Currently, the PR is in review. Can you please handle payment if needed? I'll take back over if it's still open when I return.

JmillsExpensify commented 6 months ago

Sounds good, thanks for the heads up.

melvin-bot[bot] commented 5 months ago

@JmillsExpensify, @dangrous, @sakluger, @eVoloshchak, @abzokhattab Eep! 4 days overdue now. Issues have feelings too...

eVoloshchak commented 5 months ago

Not overdue, final work is being done in https://github.com/Expensify/App/pull/40062

sakluger commented 5 months ago

Thanks for watching over this one @JmillsExpensify! I'm back and will take things back over.

sakluger commented 5 months ago

Looks like the PR is still in review.

melvin-bot[bot] commented 5 months ago

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

melvin-bot[bot] commented 5 months ago

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

dangrous commented 5 months ago

One of these ^ I don't think is a bug, just new behavior, but https://github.com/Expensify/App/issues/43215 feels real and fixable

melvin-bot[bot] commented 5 months ago

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

sakluger commented 5 months ago

@luacmartins @dangrous has this PR been deployed yet? I don't see any deploy comment, and am wondering how it cause those regressions if it hasn't been deployed.

luacmartins commented 5 months ago

Yes, the PR was deployed and included in this checklist https://github.com/Expensify/App/issues/43168. Automation probably failed

melvin-bot[bot] commented 5 months ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 5 months ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.81-11 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/40062

If no regressions arise, payment will be issued on 2024-06-18. :confetti_ball:

For reference, here are some details about the assignees on this issue:

@eVoloshchak requires payment through NewDot Manual Requests
@abzokhattab requires payment automatic offer (Contributor)

melvin-bot[bot] commented 5 months ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@eVoloshchak] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@eVoloshchak] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@eVoloshchak] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@eVoloshchak] Determine if we should create a regression test for this bug.
[ ] [@eVoloshchak] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ] [@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

melvin-bot[bot] commented 5 months ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.82-4 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/40062

If no regressions arise, payment will be issued on 2024-06-20. :confetti_ball:

For reference, here are some details about the assignees on this issue:

@eVoloshchak requires payment through NewDot Manual Requests
@abzokhattab requires payment automatic offer (Contributor)

melvin-bot[bot] commented 5 months ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@eVoloshchak] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@eVoloshchak] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@eVoloshchak] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@eVoloshchak] Determine if we should create a regression test for this bug.
[ ] [@eVoloshchak] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ] [@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

sakluger commented 4 months ago

Sorry, I'm a bit confused. I think that we still have https://github.com/Expensify/App/issues/43215 as a regression stemming from this issue, so we should hold payment until that is fixed. @dangrous @eVoloshchak could you please confirm if that's correct?

dangrous commented 4 months ago

Yep that's correct - the bot does not do well with regressions.

We're waiting on review/merge of https://github.com/Expensify/App/pull/43816 which should solve #43215

sakluger commented 4 months ago

Thanks @dangrous for clarifying! I've updated the title to be a bit more clear, and I'm going to move this back to weekly while we wait for https://github.com/Expensify/App/pull/43816 to be merged & deployed.

sakluger commented 4 months ago

The PR is still not merged.

dangrous commented 4 months ago

PR in review! Hopefully should get merged today

dangrous commented 4 months ago

we're merged!

dangrous commented 3 months ago

No automation for some reason, but this has been merged and deployed. Should be ready for payment on 7/26

sakluger commented 3 months ago

Thanks @dangrous 👍 - I updated the title accordingly and will come back tomorrow to make payments.

sakluger commented 3 months ago

Summarizing payment on this issue:

Contributor: @abzokhattab $500, paid via Upwork Contributor+: @eVoloshchak $500, please request on Newdot

sakluger commented 3 months ago

@eVoloshchak can you please complete the BZ checklist?

sakluger commented 3 months ago

Bump @eVoloshchak

eVoloshchak commented 3 months ago

The PR that introduced the bug has been identified. Link to the PR: this was the original implementation
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A

Regression Test Proposal

Click on FAB
Select Request Money -> Manual tab
Enter an amount that has 0 as the last decimal digit (e.g. 23.20)
Click on Next > go back using the header back button
Ensure the amount shown to the user is the same as in step 4 (the trailing zero isn't cut off)

Do we agree 👍 or 👎

sakluger commented 3 months ago

Thanks!

JmillsExpensify commented 2 months ago

$500 approved for @eVoloshchak

Expensify / App