[HOLD for payment 2024-02-01] [$500] Android - Add bank account - Choose an account hardly visible when light them applied

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.30-0 Reproducible in staging?: Y Reproducible in production?: No, unable to check prod If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4228288 Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:

Action Performed:

Precondition: the light mode has been applied

1. Open the app and log in
2. Navigate to any workspace settings > Bank account > Connect online with Plaid or Wallet > Add bank account > Personal bank account
3. Select e.g. Wells Fargo and continue with credentials
4. Select Checking and Savings accounts
5. Finish with the Plaid flow
6. On the Add bank account page open the selector

Expected Result:

The text in the modal is fully visible

Actual Result:

"Choose an account" is hardly visible

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [x] Android: Native
• [ ] Android: mWeb Chrome
• [ ] iOS: Native
• [ ] iOS: mWeb Safari
• [ ] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017d11e22a4c76ac05
• Upwork Job ID: 1750031291554013184
• Last Price Increase: 2024-01-24
• Automatic offers:
• mollfpr | Reviewer | 28118930
• mkhutornyi | Contributor | 28118931

[melvin-bot[bot]]

Triggered auto assignment to @puneetlath (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot[bot]]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions[bot]]

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

We think that this bug might be related to #vip-split-p2p-chat-groups

[mkhutornyi]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Android - Add bank account - Choose an account hardly visible when light them applied

What is the root cause of that problem?

In #33194, we applied platform specific text color in each item but missed picker title (placeholder)

What changes do you think we should make in order to solve the problem?

https://github.com/Expensify/App/blob/b31ea3a1979fb27df4a48ec2f7372263c1c6fffd/src/components/Picker/BasePicker.tsx#L54 use itemColor instead of theme.text

[thienlnam]

@mkhutornyi Are you around to handle this?

[mkhutornyi]

yes, I am around

[thienlnam]

Sweet - I'll assign ya!

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~017d11e22a4c76ac05

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[melvin-bot[bot]]

📣 @mollfpr 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job

[melvin-bot[bot]]

📣 @mkhutornyi 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

[thienlnam]

Pretty straightforward change and in a rush so I'll take over the C+ role for this PR

[thienlnam]

@mkhutornyi Please ping me when you get a PR up and ready to review!

[mkhutornyi]

PR is up

[thienlnam]

I'm realizing now that the change that added this was back in December, so it's likely that this is also happening on production which doesn't make this a blocker. In any case, we got it merged so it should be fixed on the next cycle. Thanks for the urgency here @mkhutornyi!

[mkhutornyi]

@thienlnam yes, correct. QA team marked this as deploy blocker with this reason: No, unable to check prod

[melvin-bot[bot]]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.31-7 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/35032

If no regressions arise, payment will be issued on 2024-02-01. :confetti_ball:

For reference, here are some details about the assignees on this issue:

• @mkhutornyi requires payment automatic offer (Contributor)

[melvin-bot[bot]]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [ ] [@thienlnam] The PR that introduced the bug has been identified. Link to the PR:
• [ ] [@thienlnam] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [ ] [@thienlnam] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [ ] [@mkhutornyi] Determine if we should create a regression test for this bug.
• [ ] [@mkhutornyi] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [ ] [@muttmuure] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot[bot]]

@thienlnam, @muttmuure, @mkhutornyi Eep! 4 days overdue now. Issues have feelings too...

[muttmuure]

$500 - @mkhutornyi

[muttmuure]

Paid

[muttmuure]

@mkhutornyi please can you complete the regression checklist and then we can close

[mkhutornyi]

• [x] [@mkhutornyi] Determine if we should create a regression test for this bug.
• [x] [@mkhutornyi] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

This bug was caught by Applause team so I believe we already have regression test case for this.

[muttmuure]

thank you