[$500] Chat - Attachment page keeps on loading infinitely.

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.34.0 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Tap on a report
3. Tap plus icon near compose
4. Tap Add attachment
5. Take a picture using camera and send it
6. Turn off mobile data
7. Open the attachment

Expected Result:

Attachment page must show the image and must not load infinitely.

Actual Result:

Attachment page keeps on loading infinitely.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [x] Android: Native
• [x] Android: mWeb Chrome
• [ ] iOS: Native
• [ ] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/93399543/6fe79ab0-0e8f-42ee-8d14-a2811d39de75

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019f92fc532944b2e5
• Upwork Job ID: 1752760607717834752
• Last Price Increase: 2024-03-14
• Automatic offers:
• situchan | Reviewer | 0
• FitseTLT | Contributor | 0

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[situchan]

Updating today after handling urgent PR review

[situchan]

@FitseTLT the proposal looks good. Do you mind sharing demo screenshot (with existing offline icon) so design team can give feedback?

[situchan]

Also, please make sure that we should still show the image when offline if it's previewed before and already cached locally.

[FitseTLT]

Also, please make sure that we should still show the image when offline if it's previewed before and already cached locally.

This is already included in the proposal as if it is cached isLoading will not be true 👍

@FitseTLT the proposal looks good. Do you mind sharing demo screenshot (with existing offline icon) so design team can give feedback?

Here is how it looks for the design team @Expensify/design @shawnborton

https://github.com/Expensify/App/assets/38649957/f0a7a1e2-e8ad-4e9c-ab90-36f92101f76c

[shawnborton]

In that screenshot, the icon should not be black - it should use our standard icon color.

[FitseTLT]

[FitseTLT]

So @shawnborton U have any other comment from design perspective??

[shawnborton]

Nope - what you have above looks correct.

[lschurr]

Should this be assigned to @FitseTLT? @shawnborton @situchan?

[shawnborton]

Curious what @situchan thinks from a technical perspective.

[situchan]

@FitseTLT's proposal looks good to me. 🎀 👀 🎀 C+ reviewed

[melvin-bot[bot]]

Triggered auto assignment to @marcochavezf, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot[bot]]

📣 @situchan 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job

[melvin-bot[bot]]

📣 @FitseTLT 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

[lschurr]

@shawnborton @marcochavezf does this bug fit in a specific wave or VIP project?

[shawnborton]

Hmm maybe #vip-vsb?

[shawnborton]

Curious what @marcochavezf thinks though!

[marcochavezf]

Catching up long convo, I suspect #vip-vsb will be the best fit since it can impact any customer who attaches an image in a chat

[FitseTLT]

PR will be up in 2 days

[FitseTLT]

@situchan @lschurr Should I come up with english version of the text that should be displayed when we show the offline indicator icon and then ask for spanish translation or there is another source I should refer even for the english version (may the internal engineers)?

[situchan]

I think @marcochavezf can get copy from marketing team

[marcochavezf]

I think @marcochavezf can get copy from marketing team

We're already using that copy in the App, right? I will apply the Waiting for copy label to get a second opinion

[melvin-bot[bot]]

Triggered auto assignment to @LLPeckham (Waiting for copy), see https://stackoverflow.com/c/expensify/questions/7025/ for more details.

[situchan]

I am not sure "This feature requires an active internet connection to be used" is correct. This feature actually doesn't require online when image is already cached.

[marcochavezf]

Hi @LLPeckham, what do you think about the copy in this screenshot? https://github.com/Expensify/App/issues/35502#issuecomment-2025746302 We're already using that copy in other parts of the app, but we want to gut-check if it is suitable for not displaying attachments when the app is offline.

[FitseTLT]

Definitely this cannot be used. It should be something like The attachment (image/video) will load when u get back online or sth but this feature needs connection is not right for an attachement that is seeking connection to load

[LLPeckham]

@marcochavezf - the screenshot is showing as broken for me, are you able to repost? Or copy and paste the copy?

[situchan]

@LLPeckham

[LLPeckham]

Thanks, @situchan. Ok so if this is just about attachments not being available while offline, then I agree the error copy above isn't clear enough.

We can keep the header if we want to have it the same, but I think the sub-copy should be more related to viewing an attachment than a feature requiring an active connection.

What about:

You appear to be offline. Attachment will become available once back online.

[situchan]

Thanks looks good to me. Hope @marcochavezf would agree too.

@FitseTLT let's implement that.

[marcochavezf]

Sounds good, the translation would be:

El archivo adjunto estará disponible cuando vuelvas a estar en línea.

[FitseTLT]

@marcochavezf The translation you gave me is for Attachment will become available once back online. right??

[FitseTLT]

created draft pr and discussing with design team for some UI input 👍

[shubham1206agra]

Since @situchan is OOO, I would like to take over here.

[DylanDylann]

I can take over this issue as a C+ reviewer because @situchan is OOO in April

[lschurr]

What's the latest here @FitseTLT? Did you get the feedback you needed from Design?

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[mallenexpensify]

@situchan is out OOO, reassigning a C+ via the auto-assigner for fairness.

[FitseTLT]

What's the latest here @FitseTLT? Did you get the feedback you needed from Design?

Yep, working on it based on the reponse.

[lschurr]

Looks like we've got a PR drafted that's waiting on some design input: https://github.com/Expensify/App/pull/39290

[lschurr]

Any update @FitseTLT?

[FitseTLT]

It will be ready for review by EOD

[lschurr]

Any change @FitseTLT?

[FitseTLT]

PR ready for review

[mallenexpensify]

PR still being actively worked on https://github.com/Expensify/App/pull/39290#issuecomment-2085198610

[melvin-bot[bot]]

This issue has not been updated in over 15 days. @LLPeckham, @marcochavezf, @mollfpr, @lschurr, @FitseTLT eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[mallenexpensify]

So close to merging... https://github.com/Expensify/App/pull/39290#issuecomment-2110701118

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[iwiznia]

FYI I think this PR caused a regression, see: https://github.com/Expensify/App/issues/42316#issuecomment-2123926673