[HOLD for payment 2024-03-13] MEDIUM: [$500] Drop domain names when searching for users and auto-filling mentions

[NikkiWines]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.35-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers): N/A Logs: N/A Expensify/Expensify Issue URL: N/A Issue reported by: N/A Slack conversation: N/A

Action Performed:

1. Create a room with 4 members: 2 on the same private domain, 1 on another private domain, and 1 on a public domain
2. Draft a message that includes mentions for each user.

Expected Result:

When mentioning a user on the same private domain, the search result for the mention should not include the domain for the user's email. For example, given a message between two users - nikkiwines@expensify.com and puneet@expensify.com - the search and auto-complete behavior should look like this:

When mentioning a user on a public domain or on a different private domain, the behavior should remain largely as it is, though we will now prepend an @ to the front of the login details (e.g. Nikki Wines nikkiwines@expensifail.com becomes Nikki Wines @nikkiwines@expensifail.com) when showing the mention options in search.

Actual Result:

The search result and mention auto-complete a same-private-domain mention contains the full email domain, even though the domain name gets removed after sending the message.

https://github.com/Expensify/App/assets/16747822/860a332c-b2e2-44dc-ad00-8f5f8fc409bf

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [x] Android: Native
• [x] Android: mWeb Chrome
• [x] iOS: Native
• [x] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [x] MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c84c193620b0a5db
• Upwork Job ID: 1754684823991881728
• Last Price Increase: 2024-02-06
• Automatic offers:
• tienifr | Contributor | 0

[alexpensify]

Here is the payment summary:

• External issue reporter - N/A
• Contributor that fixed the issue @tienifr $500 + $125 = $625
• Contributor+ that helped on the issue and/or PR @allroundexperts $250 + $125 = $375

Upwork Job: https://www.upwork.com/jobs/~01c84c193620b0a5db

Extra Notes regarding payment: There is regression, so I've accounted for that in the payment summary. Closing since everyone who is paid in Upwork has been sent one there.

There is an additional amount for the extra work as discussed here: https://github.com/Expensify/App/issues/35532#issuecomment-1979444185

[allroundexperts]

Hi @alexpensify! I think you forgot to account for https://github.com/Expensify/App/issues/35532#issuecomment-1979444185 in the payment summary?

[alexpensify]

@allroundexperts - thanks for the reminder. I'll work on this update later today.

[alexpensify]

I've updated the payment summary:

https://github.com/Expensify/App/issues/35532#issuecomment-1998726031

[alexpensify]

Alright, closing again - the summary and the payment in Upwork has been updated accordingly.

[JmillsExpensify]

$375 approved for @allroundexperts based on summary.