search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.34k stars 2.77k forks source link

[HOLD for payment 2024-03-29] [$500] Android – Image is reduced for a moment when quickly slide forward/back images using arrows #35615

Closed lanitochka17 closed 5 months ago

lanitochka17 commented 7 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.35-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4265112 Email or phone of affected tester (no customers): applausetester+jp_e_category@applause.expensifail.com Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:

Action Performed:

  1. Launch app
  2. Log in
  3. Navigate to a conversation that has 5 or more image attachments in it's history
  4. Click on one of the attachments to open the preview
  5. Click on the forward or back arrow to navigate through the conversation attachments quickly

Expected Result:

The image size is normal when quickly slide forward/back images using the arrows

Actual Result:

The image is reduced for a moment when quickly slide forward/back images using the arrows

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/a99e901f-5fa3-4580-8113-aa288435f338

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~019fd6243b644a1821
  • Upwork Job ID: 1753212539309678592
  • Last Price Increase: 2024-02-23
  • Automatic offers:
    • abdulrahuman5196 | Reviewer | 0
    • tienifr | Contributor | 0
tienifr commented 5 months ago

@johncschuster @abdulrahuman5196 Please handle payments. Thanks!

abdulrahuman5196 commented 5 months ago

The PR that introduced the bug has been identified. Link to the PR: The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

Not a regression.

Determine if we should create a regression test for this bug.

Yes.

If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

1) Send many images to a report (about 5) 2) Press an image 3) Quickly press the arrows to navigate between those images in carousel 4) Verify that while image is still loading, we only shows the loading indicator

@johncschuster

johncschuster commented 5 months ago

Payment has been issued and regression test issue has been created. Closing! 🎉