Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.34k stars 2.77k forks source link

[HOLD for payment 2024-02-20] [Snyk] Security upgrade electron from 25.9.4 to 26.6.8 #35657

Closed melvin-bot[bot] closed 6 months ago

melvin-bot[bot] commented 7 months ago

This PR was automatically created by Snyk using the credentials of a real user.


Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.

#### Changes included in this PR - Changes to the following files to upgrade the vulnerable dependencies to a fixed version: - package.json - package-lock.json #### Vulnerabilities that will be fixed ##### With an upgrade: Severity | Issue | Breaking Change | Exploit Maturity :-------------------------:|:-------------------------|:-------------------------|:------------------------- ![high severity](https://res.cloudinary.com/snyk/image/upload/w_20,h_20/v1561977819/icon/h.png "high severity") | Use After Free
[SNYK-JS-ELECTRON-6226524](https://snyk.io/vuln/SNYK-JS-ELECTRON-6226524) | Yes | No Known Exploit Check the changes in this PR to ensure they won't cause issues with your project. ------------ **Note:** *You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.* For more information: 🧐 [View latest project report](https://app.snyk.io/org/expensify/project/a75415c0-01a0-4906-abb8-070d86e05d58?utm_source=github&utm_medium=referral&page=fix-pr) 🛠 [Adjust project settings](https://app.snyk.io/org/expensify/project/a75415c0-01a0-4906-abb8-070d86e05d58?utm_source=github&utm_medium=referral&page=fix-pr/settings) 📚 [Read more about Snyk's upgrade and patch logic](https://support.snyk.io/hc/en-us/articles/360003891078-Snyk-patches-to-fix-vulnerabilities) [//]: # (snyk:metadata:{"prId":"f4d9d2c9-de50-407c-80ed-7f3ab047e10c","prPublicId":"f4d9d2c9-de50-407c-80ed-7f3ab047e10c","dependencies":[{"name":"electron","from":"25.9.4","to":"26.6.8"}],"packageManager":"npm","projectPublicId":"a75415c0-01a0-4906-abb8-070d86e05d58","projectUrl":"https://app.snyk.io/org/expensify/project/a75415c0-01a0-4906-abb8-070d86e05d58?utm_source=github&utm_medium=referral&page=fix-pr","type":"auto","patch":[],"vulns":["SNYK-JS-ELECTRON-6226524"],"upgrade":["SNYK-JS-ELECTRON-6226524"],"isBreakingChange":true,"env":"prod","prType":"fix","templateVariants":["updated-fix-title"],"priorityScoreList":[null],"remediationStrategy":"vuln"}) --- **Learn how to fix vulnerabilities with free interactive lessons:** 🦉 [Use After Free](https://learn.snyk.io/lesson/use-after-free/?loc=fix-pr)
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~012d3ec8e2707df38b
  • Upwork Job ID: 1753383789157388288
  • Last Price Increase: 2024-02-02
melvin-bot[bot] commented 7 months ago

This is a Snyk issue. Snyk is a tool that automatically tracks our repositories' dependencies and reports associated security vulnerabilities. It also automatically create PRs to fix these vulnerabilities.

    C+: Please follow these steps to test the linked PR before running through the reviewer checklist:
    - [ ] The first step is to understand the PR: what dependency is it upgrading, for which vulnerability, how it impacts our product & end users.
    - [ ] If the issue is not worth fixing, please add your reasoning in the issue and have the internal engineer review it.
    - [ ] Check the change log (which should be included in the PR description) to see all changes. We want to identify any breaking changes. If it is a minor version bump, it's unlikely that there are any breaking changes.
    - [ ] Test our feature(s) that make use of this package. If it does not work, we should understand what broke it. It is also a good idea to check our main flows to make sure they are not broken that you can add in the checklist screenshots/videos.
melvin-bot[bot] commented 7 months ago

Job added to Upwork: https://www.upwork.com/jobs/~012d3ec8e2707df38b

melvin-bot[bot] commented 7 months ago

Triggered auto assignment to Contributor Plus for review of internal employee PR - @allroundexperts (Internal)

pecanoro commented 7 months ago

@allroundexperts Could you prioritize this one, please?

pecanoro commented 7 months ago

@allroundexperts Ohh wait, I thought this was the PR, let me assign you to the PR

allroundexperts commented 7 months ago

On it today!

melvin-bot[bot] commented 7 months ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.40-5 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-02-20. :confetti_ball:

For reference, here are some details about the assignees on this issue:

melvin-bot[bot] commented 7 months ago

Issue is ready for payment but no BZ is assigned. @muttmuure you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

melvin-bot[bot] commented 7 months ago

Payment Summary

Upwork Job

BugZero Checklist (@muttmuure)

muttmuure commented 6 months ago

Ready for you to request money @allroundexperts

situchan commented 6 months ago

@muttmuure was there bounty discussion about these kind of issues (mostly Snyk)? I am asking because it was $250 in my issue (you're also BZ there) https://github.com/Expensify/App/issues/34251#issuecomment-1904238410

pecanoro commented 6 months ago

Hmm, yeah, you are right, these should be $250 since they are extremely straightforward, it only entails testing.

muttmuure commented 6 months ago

Oh wait- they should be $250

muttmuure commented 6 months ago

I updated the summary

muttmuure commented 6 months ago

@allroundexperts can submit a request for $250 in New Expensify

JmillsExpensify commented 6 months ago

$250 approved for @allroundexperts based on summary above.