[WAITING ON SITU TO FINISH CHECKLIST] [LOW] [Splits] [$500] IOU - Tapping split button & selecting 2nd contact are not highlighted like 1st contact

kbecciv commented 3 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.35.0 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4263802 Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:

Action Performed:

Go to https://staging.new.expensify.com/
Tap fab --- request money --- Scan
Tap camera button and upload a picture
Note first contact is not highlighted in Resents
Now tap split and select the first contact from Resents
Note, the contact is shown highlighted with green tick mark after selecting it
Tap split button next to second contact and select it

Expected Result:

When user taps split button (no matter first or second selection), the row isn't always highlighted but only green tick is shown

Actual Result:

When user taps split button and select 2nd contact, only green tick shown, it is not highlighted like first contact after selection.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/93399543/e848edfc-7fdb-4d41-b40b-43c2a2b2ad3b

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~010e869b36a20a1985
Upwork Job ID: 1753418217201557504
Last Price Increase: 2024-02-09
Automatic offers:

situchan | Contributor | 0
Krishna2323 | Contributor | 0

Issue Owner

Current Issue Owner: @situchan

situchan commented 2 months ago

Thanks

jliexpensify commented 2 months ago

Bump @situchan - can we push this along? Thanks!

melvin-bot[bot] commented 2 months ago

Current assignee @jliexpensify is eligible for the Bug assigner, not assigning anyone new.

melvin-bot[bot] commented 2 months ago

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

jliexpensify commented 2 months ago

Hi @trjExpensify - I'm headed OOO from 21st to 31st March so have added the auto-assigner for a buddy.

Summary:

@situchan needs to review proposals
I have bumped Situ on Slack regarding this issue

Thanks!

trjExpensify commented 1 month ago

Sounds good!

situchan commented 1 month ago

@Krishna2323's proposal looks good to me. (testing branch: https://github.com/Expensify/App/compare/main...Krishna2323:App:krishna2323/test2/35665) 🎀 👀 🎀 C+ reviewed

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @bondydaa, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

trjExpensify commented 1 month ago

Awaiting a PR. When can we expect it, @Krishna2323?

Krishna2323 commented 1 month ago

@trjExpensify @bondydaa, I'm not assigned yet.

trjExpensify commented 1 month ago

Oh sorry, I missed that we're waiting on @bondydaa for the secondary review of the proposal. Cool!

melvin-bot[bot] commented 1 month ago

Current assignee @situchan is eligible for the External assigner, not assigning anyone new.

melvin-bot[bot] commented 1 month ago

📣 @Krishna2323 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

Krishna2323 commented 1 month ago

@situchan, PR ready for review.

jliexpensify commented 1 month ago

Back - thanks @trjExpensify for the assist. I'll unassign you!

melvin-bot[bot] commented 1 month ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 1 month ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.62-17 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/39141

If no regressions arise, payment will be issued on 2024-04-25. :confetti_ball:

For reference, here are some details about the assignees on this issue:

@Krishna2323 requires payment automatic offer (Contributor)
@situchan requires payment automatic offer (Contributor)

melvin-bot[bot] commented 1 month ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@bondydaa] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@bondydaa] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@bondydaa] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@Krishna2323 / @situchan] Determine if we should create a regression test for this bug.
[ ] [@Krishna2323 / @situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ] [@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

jliexpensify commented 3 weeks ago

Payment Summary

C: @Krishna2323 $500
C+: @situchan $500

I had to create a new Upworks job, please accept!

Also @situchan - please complete the checklist

Krishna2323 commented 3 weeks ago

@jliexpensify, accepted, thanks!

jliexpensify commented 2 weeks ago

Thanks! Bumping @situchan to accept so I can pay everyone at once + complete checklist.

jliexpensify commented 2 weeks ago

Bumped @situchan again

jliexpensify commented 2 weeks ago

@situchan seems to be on leave.

jliexpensify commented 1 week ago

Was hoping to pay both together but seems like @situchan is still on vacation.

@Krishna2323 apologies for the delay, have paid you.

jliexpensify commented 2 days ago

Paid and job closed, waiting on the checklist

Expensify / App