[Hold for #38025] [$1000] Chat - Email id not shown in full available space & after sending full email iID shown for public accounts

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.36 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:

Action Performed:

1. Launch app
2. Tap in a report
3. Enter @ in compose box
4. Select an user from suggestions list
5. Note email id is not displayed occupying full space
6. Send the message

Expected Result:

After selecting an email ID from the user suggestion list, it should be displayed in full within the available space. Once sent, the full email ID should not be displayed.

Actual Result:

The selected email id from user suggestion list is not shown in full available space and after sending full email id is displayed.The selected email ID from the user suggestion list is not displayed in full within the available space. Additionally, after sending, the full email ID is still displayed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [x] Android: Native
• [x] Android: mWeb Chrome
• [ ] iOS: Native
• [ ] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/93399543/b78b686a-1d83-4555-a1eb-daf122688972

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~015976cfa3c5a4e481
• Upwork Job ID: 1753528802729029632
• Last Price Increase: 2024-03-07

[MitchExpensify]

Shared with expert agency https://expensify.slack.com/archives/C03UK30EA1Z/p1710810646724379

[Piotrfj]

Hi, Im Piotr from Callstack, I will start investigating this issue

[Piotrfj]

Update: found the source of the issue, now Im working on suitable solution that is not too big of walkoround

[shubham1206agra]

@Piotrfj Is this related to live markdown?

[MitchExpensify]

What's the latest @Piotrfj ?

[Piotrfj]

@shubham1206agra from what I see it's just native text wrapping behavior. There is no setting of that attribute that would change it exactly to what we want. Been trying to look for alternative solution but no luck for now. Right now I'm working on the second part of the issue and will consult the first one with others to find out if I'm missing something or not. That doesn't seem like to be connected to the live markdown though.

[Piotrfj]

Update: I have tested if the EmailUtils (mentioned here: https://github.com/Expensify/App/issues/35725#issuecomment-1991004933) are running, but they are not and it looks like all the breaking is due to android native behavior.

I have a question about the second part of the issue (mentioned here: https://github.com/Expensify/App/issues/35725#issuecomment-1930735370). I not sure if current behavior is a bug to be honest, I have followed the path of the values and everything seems to work as intended. Do I understand correctly that we would want to change the behavior of what is filled in the input after choosing something from the mention tooltip to a nickname if such is available?

[MitchExpensify]

By "nickname" do you mean "Display Name"? @Piotrfj ?

[Piotrfj]

@MitchExpensify yes

[MitchExpensify]

Do I understand correctly that we would want to change the behavior of what is filled in the input after choosing something from the mention tooltip to a nickname if such is available?

I think we always want to show the display name, is that what you are wondering?

[melvin-bot[bot]]

@MitchExpensify, @Piotrfj, @shubham1206agra Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[Piotrfj]

Current status for handing over the issue:

For the text breaking: I've checked many settings but none of them worked as desired. I've found a function called prefixMailSeparatorsWithBreakOpportunities in EmailUtils.ts file, but it does not seem to run in this case. My current thought is that the issue is due to some native behavior of android and I could not get to the source of it, so I don't know if it's fixable.

For the display name part: In file SuggestionMention.tsx at line 96

for both arguments login field is passed, as first argument the text field should be passed. However after doing so the mention is no longer clickable and I haven't been able to find solution for that.

[MitchExpensify]

If our best thesis is that this is caused by native Andoird behavior I am tempted to close this. Its a minor issue that I'm not sure is worth digging deeper on at this point

[MitchExpensify]

Thoughts @Piotrfj ?

[koko57]

@MitchExpensify Piotr was reassigned to another project in Callstack. Someone from our team will take this issue over and will see if it's worth fixing

[MitchExpensify]

Ok got it!

[melvin-bot[bot]]

@MitchExpensify, @shubham1206agra Huh... This is 4 days overdue. Who can take care of this?

[MitchExpensify]

@koko57 any update on a new set of eyes on this one?

[burczu]

@MitchExpensify I'm taking a look at this one as Callstack engineer - please assign it to me. Thank you.

[MitchExpensify]

Done! Thanks @burczu

[MitchExpensify]

What is the latest here @burczu ? Thanks

[koko57]

@MitchExpensify - @burczu is OOO till 05/05. He's still working on a proper solution for this issue.

[melvin-bot[bot]]

@burczu, @MitchExpensify, @shubham1206agra Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[MitchExpensify]

@burczu how is the solution coming along for this? Thanks

[burczu]

@MitchExpensify Hey! I'm back from ooo - sorry for not leaving an information about it here, I've completely forgotten to do it. I'm still involved in the Guided Setup Stage 2 project (there is one last PR to merge I'm taking care of) but I'll be also working on this issue this week.

Till now, I've confirmed what @Piotrfj found and described in his comment: https://github.com/Expensify/App/issues/35725#issuecomment-2052402367 - I think line breaking issue will be hard to fix and is minor, so i suggest leaving it as is. In terms of display name issue - I was looking for the solution for making it clickable after changing the format but didn't find the solution yet, so I'll continue an investigation.

[burczu]

Not overdue - still investigating.

[melvin-bot[bot]]

@burczu, @MitchExpensify, @shubham1206agra Whoops! This issue is 2 days overdue. Let's get this updated quick!

[burczu]

Here's my update for the second part of the issue:

Mention highlighting is done in two places: for the chat message list it is done in the MentionUserRenderer component, for composer it must be done inside the react-native-live-markdown library.

For now I've managed to show display name instead of login only in the MentionUserRenderer component, here's the result:

https://github.com/Expensify/App/assets/7771498/73b3e86c-8ab6-4abb-8687-373460ac4dd2

As you can see in the above video, the mention is not highlighted in the composer, and it shows a login as a mention - from what I've found, to fix it we need to change some native code of the react-native-live-markdown. I've tried to find the code responsible for this, but with no luck yet.

[melvin-bot[bot]]

@burczu, @MitchExpensify, @shubham1206agra Whoops! This issue is 2 days overdue. Let's get this updated quick!

[shubham1206agra]

@burczu The short mention highlighting issue will be taken care in https://github.com/Expensify/App/issues/38025.

[burczu]

@shubham1206agra Thanks for pointing this out. Should we put this issue on hold as the one you've mentioned is also on hold now?

[MitchExpensify]

Placed on hold for https://github.com/Expensify/App/issues/38025

[melvin-bot[bot]]

@burczu, @MitchExpensify, @shubham1206agra Huh... This is 4 days overdue. Who can take care of this?

[MitchExpensify]

On hold for https://github.com/Expensify/App/issues/38025

[melvin-bot[bot]]

@burczu, @MitchExpensify, @shubham1206agra Whoops! This issue is 2 days overdue. Let's get this updated quick!

[MitchExpensify]

On hold for https://github.com/Expensify/App/issues/38025

[melvin-bot[bot]]

@burczu, @MitchExpensify, @shubham1206agra Whoops! This issue is 2 days overdue. Let's get this updated quick!

[MitchExpensify]

On hold for https://github.com/Expensify/App/issues/38025

[MitchExpensify]

On hold for https://github.com/Expensify/App/issues/38025

[MitchExpensify]

On hold for https://github.com/Expensify/App/issues/38025

[melvin-bot[bot]]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[MitchExpensify]

Reassigning while I'm leave 🙇

[lschurr]

Still on hold

[lschurr]

Hold

[lschurr]

Still holding

[lschurr]

On hold

[lschurr]

On hold

[lschurr]

On hold

[lschurr]

On hold.

[lschurr]

On hold