search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.12k stars 2.62k forks source link

[PAYMENT DUE] [$500] mWeb - Device back button with emoji picker opened leads to LHN instead of closing picker #35756

Closed lanitochka17 closed 2 months ago

lanitochka17 commented 5 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.36-0 Reproducible in staging?: Y Reproducible in production?:Y If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4279504 Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:

Action Performed:

  1. Log in to New Expensify
  2. Navigate to any chat
  3. Open emoji picker
  4. Use device back button (twice if keyboard is opened)

Expected Result:

Emoji picker should be closed, user should remain in chat history

Actual Result:

User is redirected back to LHN

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/31c26028-7122-47f2-abe4-66363db68835

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0156cc7a92d86433bd
  • Upwork Job ID: 1753804975067238400
  • Last Price Increase: 2024-02-24
Julesssss commented 3 months ago

Thanks for the TLDR, yeah after viewing the video I agree the back button should first close the emoji picker -- I'll happily review the PR

adamgrzybowski commented 3 months ago

@Julesssss Just as a reminder. One of the questions is if we want the same behavior for narrow layout web on desktop and mobile web.

Julesssss commented 3 months ago

One of the questions is if we want the same behavior for narrow layout web on desktop and mobile web.

For all platforms I would not expect the < button to close the emoji picker, just like WhatsApp. The < action is different to the Android OS back action.

For the Android back action on mWeb I could go either way... As an Android user I would like for the emoji picker to close when back is pressed, just as the native keyboard does. But there is no consistency across mWeb apps, so I would also understand if mWeb behaves differently. What do you think @shawnborton?

shawnborton commented 3 months ago

I'm not entirely sure if I have a strong opinion here. I don't think it would be bad if mWeb worked like Android would in this case though.

Julesssss commented 3 months ago

mWeb Android matching the default app behaviour feels the better of the two options, so I'd also be happy with that.

zanyrenney commented 3 months ago

thanks @Julesssss and @shawnborton - super helpful!

zanyrenney commented 3 months ago

@sobitneupane can you C+ full review of this - https://github.com/Expensify/App/issues/35756#issuecomment-1925392413 so we can assign @suneox to the issue to work on it if so please?

thanks!

sobitneupane commented 3 months ago

Sure @zanyrenney. I will review the proposal asap.

sobitneupane commented 3 months ago

Thanks for the proposal @suneox

Proposal from @suneox looks good to me.

🎀 👀 🎀 C+ reviewed

melvin-bot[bot] commented 3 months ago

Current assignee @Julesssss is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

suneox commented 3 months ago

The PR has been deployed to production

suneox commented 3 months ago

Hi @zanyrenney how about payment for this issue has been deployed to production but the bot not updated status

suneox commented 3 months ago

Hi @zanyrenney this issue has been deployed to production 2 weeks, Can I get an offer for this issue?

sobitneupane commented 3 months ago

@zanyrenney This is ready for payment.

Julesssss commented 3 months ago

Yah, Zany has been OOO but will be back soon 🙂

suneox commented 2 months ago

Friendly bump @zanyrenney

suneox commented 2 months ago

Hi @sobitneupane how can I get payment for this issue? It has been deployed a month. Thank you!

Julesssss commented 2 months ago

Hey @zanyrenney, just wanted to check you've seen this payment request?

zanyrenney commented 2 months ago

on it, didn't see this with the lack of date automation.

zanyrenney commented 2 months ago

payment summary

@sobitneupane owed $500 - needs to request through NewDot (manual requests) @suneox needs $500 from upwork.

zanyrenney commented 2 months ago

@suneox I can't find you on upwork. 2024-05-07_12-30-36

2024-05-07_12-30-52

Please can you manually apply to the job? https://www.upwork.com/jobs/~01386bcc6b2c6f0fdf

Feel free to DM me in slack when you have and i'll process the payment ASAP.

suneox commented 2 months ago

@suneox I can't find you on upwork.

Here is my profile

zanyrenney commented 2 months ago

Invited, please accept !

suneox commented 2 months ago

Invited, please accept !

I have accept this job, Thank you

zanyrenney commented 2 months ago

payment summary

@sobitneupane owed $500 - needs to request through NewDot (manual requests) @suneox PAID $500 from upwork.

melvin-bot[bot] commented 2 months ago

@shawnborton @Julesssss @zanyrenney Be sure to fill out the Contact List!

JmillsExpensify commented 1 month ago

$500 approved for @sobitneupane