[HOLD App#35519] Android - Bank account - App crashes after filling out personal info offline killing app&go online

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.37.0 Reproducible in staging?: y Reproducible in production?: cannot verify in production If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:

Action Performed:

1. Open the app and log in
2. Create a workspace if there is no one
3. Navigate to the workspace settings > Bank account
4. Tap Continue online with Plaid
5. Select the bank, e.g. Regions
6. Continue with the Plaid flow
7. Select the savings 1111 account in the drop-down and continue
8. Enter the company information and tap "Continue"
9. On the "Personal information" disable the internet connection
10. Fill out the personal information form
11. Kill the app and open it again
12. Return online and tap "Save and continue"

Expected Result:

User is able to proceed to the next screen

Actual Result:

The app crashes

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [x] Android: Native
• [ ] Android: mWeb Chrome
• [ ] iOS: Native
• [ ] iOS: mWeb Safari
• [ ] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/93399543/dd74acbe-5538-4a87-b841-ccad5022a786

View all open jobs on GitHub

[github-actions[bot]]

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot[bot]]

Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[kbecciv]

We think that this bug might be related #wave6-collect-submitters CC @greg-schroeder

[marcaaron]

This feels like a non-blocker to me and is likely happening on production already.

[melvin-bot[bot]]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[trjExpensify]

@greg-schroeder we're refactoring the VBBA flow in wave6 aren't we? So I think I agree this issue goes there. It would be good for the peeps working on it to make sure this crash gets cleaned up.

[trjExpensify]

CC: @gedu do you agree on putting this on hold for the VBA refactor?

[melvin-bot[bot]]

@trjExpensify Eep! 4 days overdue now. Issues have feelings too...

[trjExpensify]

Reached out to @gedu for his input.

[gedu]

Hey, this bug maybe is not valid anymore, given that the flow changed. I give a try with the new flow and you can't move forward without internet, if you reach the confirmation page, then go offline, kill the app and open it again, all keeps working. I would double check if still happens or close this issue @trjExpensify

[mkhutornyi]

This is dupe of https://github.com/Expensify/App/issues/35519 Crash happens only on release build, which came from enabling proguard

[gedu]

This is how the new UI looks, so this and the #35519 has the old UI, I checked the new UI using dev build and was working ok.

[mkhutornyi]

@gedu please test production build, not dev build

[trjExpensify]

This is a dupe of #35519, so let's consolidate there.