search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.48k stars 2.83k forks source link

[HOLD E/E #359760] [$500] No "Hold Request" and "Add a receipt" option on workspace expense report as Admin #36202

Closed kavimuru closed 1 month ago

kavimuru commented 8 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Issue found when executing #35744 Version Number: 1.4.39-0 Reproducible in staging?: y Reproducible in production?: n If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause internal team Slack conversation:

Action Performed:

  1. Create a new expense request on a collect policy
  2. Submit the expense
  3. Open the expense report
  4. Right-click/long-press the expense preview
  5. (if employee) Verify there is no Delete Request (if admin) Verify there is a Delete Request option
  6. Press the expense preview to open the transaction thread
  7. Press the three-dots button
  8. (if employee) Verify there is no Delete Request and Add receipt (if admin) Verify there is a Delete Request and Add receipt option

Expected Result:

There should be Hold Request and Add a receipt option on Admins side

Actual Result:

No "Hold Request" and "Add a receipt" option on workspace expense report as Admin

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/43996225/c5d1909f-974f-4739-a770-5959a320a8d7

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01c35580d297f84569
  • Upwork Job ID: 1755778907181215744
  • Last Price Increase: 2024-03-08
MitchExpensify commented 6 months ago

Friendly bump @youssef-lr

melvin-bot[bot] commented 6 months ago

@hoangzinh, @youssef-lr, @MitchExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

youssef-lr commented 6 months ago

We should be able to merge the Web-E PR today, I'll continue work on the App PR meanwhile, starting tomorrow.

MitchExpensify commented 6 months ago

Nice one @youssef-lr !

melvin-bot[bot] commented 6 months ago

@hoangzinh, @youssef-lr, @MitchExpensify Eep! 4 days overdue now. Issues have feelings too...

MitchExpensify commented 6 months ago

Checking in on this progress @youssef-lr

youssef-lr commented 6 months ago

No update yet sorry @MitchExpensify , I have been busy with wave-collect and Uneven Split due to tight deadline

MitchExpensify commented 5 months ago

No worries, switching to weekly as this is polish

trjExpensify commented 5 months ago

@MitchExpensify can you clear up the OP and title of this issue to reflect the expected behaviour based on the discussion? I read the title and freaked out a little bit. I.e admins shouldn't be able to delete people's expenses.

MitchExpensify commented 5 months ago

Can do, I've updated the title and body to reflect that these options are expected from an admin's perspective on a workspace expense:

  1. Hold request
  2. Add a receipt
trjExpensify commented 5 months ago

Thanks!

youssef-lr commented 5 months ago

Working on this next week!

MitchExpensify commented 4 months ago

Fire likely slowed us down here, do you think this week is the week @youssef-lr ? 😄

MitchExpensify commented 4 months ago

Fire issues still being prioritized over this I imagine

MitchExpensify commented 4 months ago

Do you think you'll have bandwidth for this soon @youssef-lr ?

youssef-lr commented 3 months ago

Yes, I'll find some time for it next week @MitchExpensify

MitchExpensify commented 3 months ago

Melvin, @youssef-lr is finding time for this when they can

MitchExpensify commented 3 months ago

Reassigning while I'm leave 🙇

melvin-bot[bot] commented 3 months ago

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] commented 2 months ago

@hoangzinh, @youssef-lr, @kevinksullivan Eep! 4 days overdue now. Issues have feelings too...

hoangzinh commented 2 months ago

Waiting updates from @youssef-lr

melvin-bot[bot] commented 2 months ago

@hoangzinh, @youssef-lr, @kevinksullivan Eep! 4 days overdue now. Issues have feelings too...

hoangzinh commented 2 months ago

same as above.

youssef-lr commented 2 months ago

Looking into this one today @hoangzinh

melvin-bot[bot] commented 2 months ago

@hoangzinh, @youssef-lr, @kevinksullivan Eep! 4 days overdue now. Issues have feelings too...

hoangzinh commented 2 months ago

Waiting for updates from @youssef-lr .

youssef-lr commented 2 months ago

I've added a fix here since I touched that logic in the PR https://github.com/Expensify/App/pull/46931/commits/06f3d4d11ac683a23fba1ea758d1cd258617e3db, this is aligned with what we have in OldDot

trjExpensify commented 2 months ago

So this will be fixed by https://github.com/Expensify/App/pull/46931 in review, right?

youssef-lr commented 2 months ago

Yup!

melvin-bot[bot] commented 2 months ago

@hoangzinh, @youssef-lr, @kevinksullivan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

hoangzinh commented 2 months ago

Not overdue, PR has been merged

melvin-bot[bot] commented 2 months ago

@hoangzinh, @youssef-lr, @kevinksullivan Whoops! This issue is 2 days overdue. Let's get this updated quick!

hoangzinh commented 1 month ago

@youssef-lr The PR https://github.com/Expensify/App/pull/46931 has been deployed to Prod. Are we good to re-test this issue?

melvin-bot[bot] commented 1 month ago

@hoangzinh, @youssef-lr, @kevinksullivan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

kevinksullivan commented 1 month ago

it's been a while so we no longer have the three dots, but I see hold on this expense. image

kevinksullivan commented 1 month ago

@hoangzinh original posting expired so here is a new one in upwork

https://www.upwork.com/jobs/~014ecea72e003c577c

lmk when you accept!

hoangzinh commented 1 month ago

It's an internal issue and I haven't reviewed the PR so no payment for me @kevinksullivan

melvin-bot[bot] commented 1 month ago

@hoangzinh, @youssef-lr, @kevinksullivan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

kevinksullivan commented 1 month ago

still looking for internal volunteer

hoangzinh commented 1 month ago

@kevinksullivan It appears that we're good to close this issue https://github.com/Expensify/App/issues/36202#issuecomment-2308533553. Arent' we? 🤔

melvin-bot[bot] commented 1 month ago

@hoangzinh, @youssef-lr, @kevinksullivan Whoops! This issue is 2 days overdue. Let's get this updated quick!

hoangzinh commented 1 month ago

Not overdue, I think we can close this issue

trjExpensify commented 1 month ago

https://github.com/Expensify/App/issues/36202#issuecomment-2276998969 - yep, closing.