Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.17k stars 2.66k forks source link

Investigate workflow job failing on main: e2ePerformanceTests / Run E2E tests in AWS device farm #36248

Closed github-actions[bot] closed 5 months ago

github-actions[bot] commented 5 months ago

🚨 Failure Summary 🚨:

⚠️ Action Required ⚠️:

πŸ› οΈ A recent merge appears to have caused a failure in the job named e2ePerformanceTests / Run E2E tests in AWS device farm. This issue has been automatically created and labeled with Workflow Failure for investigation.

πŸ‘€ Please look into the following:

  1. Why the PR caused the job to fail?
  2. Address any underlying issues.

πŸ› We appreciate your help in squashing this bug!

flodnv commented 5 months ago

Weird, can you look into this please @JKobrynski @fabioh8010 @c3024 @filip-solecki ?

c3024 commented 5 months ago

That mock is used only in storybook webpack config. I don't understand why this failed. πŸ€”

fabioh8010 commented 5 months ago

@flodnv Do you know if it's possible to reproduce those e2e tests locally?

c3024 commented 5 months ago

Are these the same tests?

jjcoffee commented 5 months ago

Note that this is a new automation, so the workflow failure hasn't necessarily been triggered by the linked PR - it could have been failing for a while before, so might require some digging to figure out the original source!

flodnv commented 5 months ago

@jjcoffee who added this automation and where? Can we have them investigate it if they caused this problem?

jjcoffee commented 5 months ago

@flodnv The automation was implemented in https://github.com/Expensify/App/issues/34110 to catch main silently failing. This is expected behaviour on the first run, so not a problem they've caused as such :smile:

flodnv commented 5 months ago

Looks like this is being handled elsewhere, as it should be: https://github.com/Expensify/App/issues/36240#issuecomment-1936105461

jjcoffee commented 5 months ago

@flodnv Is there an issue that's tracking where it's being handled? The way the automation works it will keep opening a new issue if there isn't already an open issue with the failing job in the title :sweat_smile:

flodnv commented 5 months ago

Looks like the PR has been merged: https://github.com/Expensify/App/issues/36240#issuecomment-1936105461