Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.

https://new.expensify.com

MIT License

3.14k stars 2.64k forks source link

Deploy Checklist: New Expensify 2024-02-13 #36429

Closed github-actions[bot] closed 5 months ago

github-actions[bot] commented 5 months ago

Release Version: 1.4.41-12 Compare Changes: https://github.com/Expensify/App/compare/production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

[x] I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
[x] I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
[x] I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

blimpich commented 5 months ago

Demoting 36434

amyevans commented 5 months ago

Demoted https://github.com/Expensify/App/issues/36437

OSBotify commented 5 months ago

:rocket: All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.4.41-0 :rocket:

Beamanator commented 5 months ago

Marked https://github.com/Expensify/App/issues/36456 as NAB b/c we consider it a pretty strange edge case

Beamanator commented 5 months ago

Also marked https://github.com/Expensify/App/issues/36455 as NAB, it's not really broken - and it's a test that we'll be updating over the next few weeks

Beamanator commented 5 months ago

https://github.com/Expensify/App/issues/36458 also got marked nab as it's quite a small design bug that will be quick to fix

kavimuru commented 5 months ago

Regression is 4% left.

31055 failing with #36455

34752 failing with #36479

34498 failing with #36449, #36451, #36447 and blocked in desktop with KI #36368

34303 failing with #36433 on desktop

We still have validation pending on other unchecked PRs

Julesssss commented 5 months ago

Checking off #36502 as it's not a big problem. Will fix without it being a blocker

dangrous commented 5 months ago

36487 is not a blocker and is sort of a dupe of #36455. Checking off.

kavimuru commented 5 months ago

Regression completed.

Unchecked PRs:

31055 failing with #36455

34752 failing with #36479

34498 failing with #36449,#36451,#36447 and blocked in desktop with KI36368

34303 failing with #36433 on desktop

34963 blocked by #36479

35287 blocked by #36433

35841 failing with #36434 but closed as not reproduced, checking it off

35853 blocked by #36433

36204 blocked by #36433 in iOS (tester does not have an account with previous requests to validate the PR. Because PR steps does not require a new IOU)

35645 - Looks internal testing, can I check it off?

Open Blockers:

36433

36346

36438

36454

36457

36479

36481

36483

36490

36510

36517

We are validating the 2 cps now.

rlinoz commented 5 months ago

Checking off https://github.com/Expensify/App/issues/36510 as this is already in prod.

amyevans commented 5 months ago

Checked off #36454 following CP/retest

mountiny commented 5 months ago

checking https://github.com/Expensify/App/issues/36479 off, its backend blocker

AndrewGable commented 5 months ago

Checked off https://github.com/Expensify/App/issues/36517, it was fixed on staging by this CP https://github.com/Expensify/App/actions/runs/7909722028

thienlnam commented 5 months ago

Only fresh crash is for ImageMetaData.getColorSpace - which only happened for 1 user on 1.4.38-6 so it seems fine to ignore

thienlnam commented 5 months ago

Kicking off the deploy so we can get this fireroom fix to prod

thienlnam commented 5 months ago

:shipit:

os-botify[bot] commented 5 months ago

This issue either has unchecked items or has not yet been marked with the :shipit: emoji of approval. Reopening!

melvin-bot[bot] commented 5 months ago

📣 @os-botify[bot]! 📣 Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:

Make sure you've read and understood the contributing guidelines.
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details. Format:
```
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
```

thienlnam commented 5 months ago

:shipit: