search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.33k stars 2.76k forks source link

[$500] Web - Bank Account - Infinite loading on bank info page on connecting bank accounts #36479

Closed kbecciv closed 7 months ago

kbecciv commented 7 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v1.4.41-2 Reproducible in staging?: y Reproducible in production?: not able to check production If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4311330&group_by=cases:section_id&group_order=asc&group_id=283225 Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:

Action Performed:

  1. Log in with expensifail account
  2. Click bottom right wrench settings icon
  3. Select any WS
  4. Select Bank account
  5. Select Connect with Plaid
  6. Go through the Plaid flow using either Chase, Regions or Wells Fargo bank
  7. User redirected to ND site

Expected Result:

No infinite loading display on bank info page. User able to connect BA

Actual Result:

Infinite loading on bank info page on connecting bank accounts

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/93399543/f7ec00f9-e89a-4cbc-ac0b-1ebda02190a9

https://github.com/Expensify/App/assets/93399543/2fe4c068-e2a2-42e0-a72d-d9fe88e887f9

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~015f35a009ac3da6d6
  • Upwork Job ID: 1757770983720157184
  • Last Price Increase: 2024-02-14
  • Automatic offers:
    • akinwale | Contributor | 0
github-actions[bot] commented 7 months ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
melvin-bot[bot] commented 7 months ago

Triggered auto assignment to @youssef-lr (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

kbecciv commented 7 months ago

We think that this bug might be related #wave6-collect-submitters CC @greg-schroeder

Beamanator commented 7 months ago

Noted in slack - https://expensify.slack.com/archives/C01GTK53T8Q/p1707919815149159?thread_ts=1707829954.739589&cid=C01GTK53T8Q

melvin-bot[bot] commented 7 months ago

Job added to Upwork: https://www.upwork.com/jobs/~015f35a009ac3da6d6

melvin-bot[bot] commented 7 months ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

melvin-bot[bot] commented 7 months ago

📣 @akinwale 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

mountiny commented 7 months ago

cc @shubham1206agra @akinwale @MrMuzyk

mountiny commented 7 months ago

@Swor71 is working on this one

Swor71 commented 7 months ago

hey, I'm Marcin from Callstack - expert contributor group - I'd like to work on this issue

sorry for late comment on this one but yes, I am looking into this at the moment

mountiny commented 7 months ago

Might be related to backend PR potentially https://github.com/Expensify/Web-Expensify/pull/40691

Stacktrace from Marcin:

image

Swor71 commented 7 months ago

this is the onyx update received from the server:

image
mountiny commented 7 months ago

Ok yes the onyx data is not correct format

image
mountiny commented 7 months ago

Using production API

image

This is a backednd blocker

mountiny commented 7 months ago

Created a backend fix for this https://github.com/Expensify/Web-Expensify/pull/40897

melvin-bot[bot] commented 7 months ago

Current assignee @akinwale is eligible for the Internal assigner, not assigning anyone new.

mountiny commented 7 months ago

Fixed