[HOLD for payment 2024-04-05] [$100] Remove the closeFullScreen() method from code since it is no longer used

[kbecciv]

The back button was removed from the modals and so now the closeFullScreen() method is no longer used in the code, but it was never removed. Let's remove it!

Old Issue Description

If you haven’t already, check out our [contributing guidelines](https://github.com/Expensify/ReactNativeChat/blob/main/contributingGuides/CONTRIBUTING.md) for onboarding and email contributors@expensify.com to request to join our Slack channel! ___ **Version Number:** v1.4.41-3 **Reproducible in staging?:** y **Reproducible in production?:** y **If this was caught during regression testing, add the test name, ID and link from TestRail:** **Email or phone of affected tester (no customers):** **Logs:** https://stackoverflow.com/c/expensify/questions/4856 **Expensify/Expensify Issue URL:** **Issue reported by:** Applause - Internal **Slack conversation:** ## Action Performed: Precondition: - Workspace filter is set to "Expensify". 1. Go to staging.new.expensify.com 2. Go to any chat and send a message. 3. Open workspace switcher. 4. Select any workspace. 5. Click Profile settings. 6. Click back button on the top left. ## Expected Result: App closes profile settings and reopens the chat that shows up after switching workspace in Step 4. ## Actual Result: App reopens the chat that is opened in Step 2, which is before workspace filter is applied, while the workspace filter is still applied. ## Workaround: Unknown ## Platforms: Which of our officially supported platforms is this issue occurring on? - [ ] Android: Native - [ ] Android: mWeb Chrome - [ ] iOS: Native - [ ] iOS: mWeb Safari - [x] MacOS: Chrome / Safari - [x] MacOS: Desktop ## Screenshots/Videos Add any screenshot/video evidence https://github.com/Expensify/App/assets/93399543/32828cc3-8d1c-4347-a25d-f7b624a03ccc

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0124a682d645bc91de
• Upwork Job ID: 1757785433393643520
• Last Price Increase: 2024-03-15

Issue Owner

Current Issue Owner: @adelekennedy

[barros001]

PR open for review

[rushatgabhane]

@tgolen on a related note. Should we add a lint rule that checks for unused exported functions?

We already use no-unused-modules. Just need to configure it to detect unused exports. configuration docs here

[melvin-bot[bot]]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.57-5 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/38418

If no regressions arise, payment will be issued on 2024-04-05. :confetti_ball:

For reference, here are some details about the assignees on this issue:

• @barros001 requires payment (Needs manual offer from BZ)
• @rushatgabhane requires payment through NewDot Manual Requests

[melvin-bot[bot]]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [ ] [@rushatgabhane] The PR that introduced the bug has been identified. Link to the PR:
• [ ] [@rushatgabhane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [ ] [@rushatgabhane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [ ] [@rushatgabhane] Determine if we should create a regression test for this bug.
• [ ] [@rushatgabhane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [ ] [@adelekennedy] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[rushatgabhane]

Not a bug. This is a cleanup issue.

Checklist not applicable

[rushatgabhane]

@adelekennedy could you please attach payment summary 🙇

[adelekennedy]

Is payment due today or on the 5th? Happy to pay out today but want to check if the retitling automation is correct!

[adelekennedy]

ah - I see this is a cleanup issue: Payouts due:

• [ ] Contributor: $100 @barros001 (Upwork)
• [x] Contributor+: $100 @rushatgabhane (NewDot)

Upwork offer sent

[barros001]

@adelekennedy offer accepted

EDIT: Spoke too soon, looks like Upwork having issues and I can't accept it.. I'll try again shortly.

[adelekennedy]

ah Upwork, always reliably unreliable

[barros001]

looks like it worked this time!

[adelekennedy]

payment made!

[JmillsExpensify]

$100 approved for @rushatgabhane