[LOW] [P2P] Make new dot display a informative error message when user hits wallet limit

[blimpich]

Problem

Users with gold wallets who send greater than $1,000 every 60 days hit a limit on their wallets for sending money. This is intended, but when the user hits the limit the app doesn't give the user any feedback as to why their send requests are being rejected. This causes confusion and makes the app seem buggy when it actually is functioning as intended.

Solution

Give the user feedback when they try to send money after they have hit their limit.

Helpful Details

• 402 Total spend from P2P linked account is over wallet limit is the exact error that Auth is throwing
• This error can happen when we run the command PayWithWallet or when we run TransferWalletBalance
• relevant slack conversation
• I (@blimpich) marked this issue as internal because, after briefly looking at other places where we display descriptive errors in the frontend, the Web layer seems to usually handle actually sending a readable error message to the client

[melvin-bot[bot]]

Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.

[melvin-bot[bot]]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @abdulrahuman5196 (Internal)

[blimpich]

This is an internal issue, please ignore @abdulrahuman5196

[melvin-bot[bot]]

Triggered auto assignment to @stephanieelliott (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[stephanieelliott]

This was called out in #vip-split, waiting to be picked up based on priority.

[stephanieelliott]

Called out for volunteer: https://expensify.slack.com/archives/C05RECHFBEW/p1709590800671339

[stephanieelliott]

Waiting for internal prioritization

[stephanieelliott]

Hey @blimpich, I'm struggling to get an internal eng to pick this up -- any chance you can work on this one? Or do you know who might be familiar with this part of the code?

[blimpich]

I cannot unfortunately, and I have to admit this is a very low priority feature. Very few people use the wallets right now and even fewer people (basically just David) ever hit the wallet limit. So I can see why people aren't prioritizing it. We could make it monthly to reflect that priority @stephanieelliott ?

[stephanieelliott]

Good context, thanks @blimpich! It's assigned High priority by the wave curator so we will leave that by default, we'l continue to try and get this picked up.

[stephanieelliott]

Gonna move this to Weekly now that the issue has been reprioritized to LOW

[mvtglobally]

QA team is not able to confirm if this issue is still reproducible during KI retests as it requires production KYC passed for Wallet accounts. This issue will need to be retested internally

[blimpich]

I can confirm this is still an issue.

[mvtglobally]

QA team is not able to confirm if this issue is still reproducible during KI retests as it requires production KYC passed for Wallet accounts. This issue will need to be retested internally

[stephanieelliott]

This issue proposes the addition of a system error message, unless we specifically added one I think we can assume it is still occurring. This is bumped on the wave weekly, it's designated priority is Low so someone will pick it up once higher priority items have been done

[mvtglobally]

QA team is not able to confirm if this issue is still reproducible during KI retests as it requires production KYC passed for Wallet accounts. This issue will need to be retested internally

[stephanieelliott]

Waiting for prioritization

[mvtglobally]

QA team is not able to confirm if this issue is still reproducible during KI retests as it requires production KYC passed for Wallet accounts. This issue will need to be retested internally

[stephanieelliott]

Waiting for prioritization. I am going OOO until May 2 but will hang on to this seeing as it is Weekly and there has been no movement as of yet. Feel free to apply labels if a BZ is needed in the meantime though

[stephanieelliott]

This is categorized as low priority on the project and is currently not affecting anyone, waiting for this to be picked up

[stephanieelliott]

Holding this til it can be prioritized internally, see previous update

[stephanieelliott]

Seeing as fixing our current features is taking priority over creating new features (context) will continue holding on this one.

[mvtglobally]

QA team is not able to confirm if this issue is still reproducible during KI retests as it requires production KYC passed for Wallet accounts. This issue will need to be retested internally

[blimpich]

Rested and it still exists.

[stephanieelliott]

Holding this til it can be prioritized internally, see previous update

[mvtglobally]

QA team is not able to confirm if this issue is still reproducible during KI retests as it requires production KYC passed for Wallet accounts. This issue will need to be retested internally

[blimpich]

Still reproduces

[mvtglobally]

QA team is not able to confirm if this issue is still reproducible during KI retests as it requires production KYC passed for Wallet accounts. This issue will need to be retested internally

[blimpich]

Still reproduces

[stephanieelliott]

Waiting for this to be prioritized internally

[stephanieelliott]

Just noting here that the VIP this is under is paused, so this is not likely to be prioritized soon.

[stephanieelliott]

No movement on this, the VIP is paused

[stephanieelliott]

No update here, and the VIP is paused

[stephanieelliott]

Still held, this VIP is paused and this issue is not currently affecting customers

[stephanieelliott]

Still held, this VIP is paused and this issue is not currently affecting customers

[stephanieelliott]

Adding this to #quality, seeing as the absence of the error will make it seem buggy to the end user. Also adjusting labels, although this is low priority it seems like it would be a pretty simple fix

[stephanieelliott]

Waiting for this to be picked up, low priority since no one is actually running into this