[New architecture] App crashed after adding personal bank account, while selecting a bank account

WoLewicki commented 7 months ago

If you haven't already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

This issue is related to the ongoing new architecture adoption. It was reported on the build with new architecture enabled on the relevant PR.

Version Number: 1.4.42-1 Reproducible in staging?: no Reproducible in production?: no If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @ishpaul777 here Slack conversation:

Action Performed:

Break down in numbered steps

Expected Result:

App not crashing in the flow

Actual Result:

App crashing

Workaround:

Should be fixed by 9d2f0d5 (#13767)

Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[x] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

Available in the linked comment.

View all open jobs on GitHub

ishpaul777 commented 6 months ago

not able to repro the app crash but "Save & Continue" button was not functional after adding account

https://github.com/Expensify/App/assets/104348397/1aadc105-824d-47bc-9c01-e1d15dd37d67

j-piasecki commented 6 months ago

@ishpaul777 I got the same result on the main branch, in my case it looks like there are some errors returned by the plaid SDK (regarding identity or adding the same account twice) which are silently ignored by the App.

I've added some logs in AddPersonalBankAccountPage:

    console.log('personalBankAccount', personalBankAccount);
    console.log('shouldShowSuccess', shouldShowSuccess);
    console.log('plaidData', plaidData);

and this is what I got:

Could you also check on the main branch?

ishpaul777 commented 6 months ago

Will check and update give me 15-20 mins

ishpaul777 commented 6 months ago

i can reproduce the same on main (but not on staging app), i think this shouldn't be a blocker for new Arch PR but worth investigation as a seperate issue

mountiny commented 5 months ago

Will be tested once the PR is deployed.

Expensify / App