Closed kavimuru closed 3 months ago
Job added to Upwork: https://www.upwork.com/jobs/~017f68d54c34c3a131
Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External
)
Triggered auto assignment to @miljakljajic (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details.
:wave: Friendly reminder that deploy blockers are time-sensitive β± issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Triggered auto assignment to @MariaHCD (Engineering
), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.
We think this bug might be related to #vip-vsb cc @quinthar
Change in playback seep doesn't take effect
We don't pass rate
prop into Video
component to control the speed of the video so the speed is always the default
Ref: https://docs.expo.dev/versions/latest/sdk/video/#rate
Return currentPlaybackSpeed
in contextValue
of VideoPlayerContexts
const contextValue = useMemo(() => ({menuItems, updatePlaybackSpeed, currentPlaybackSpeed}), [menuItems, updatePlaybackSpeed]);
const {currentPlaybackSpeed} = useVideoPopoverMenuContext();
rate={currentPlaybackSpeed}
Then in BaseVideoPlayer
get this speed and pass it as rate
prop into Video
component.
Each video should have a default speed is 1.0
, we can create a speed
state in BaseVideoPlayer
and then when we update the speed we will update speed
state instead of updating it in VideoPlayerContexts
https://github.com/Expensify/App/assets/129500732/37b55b80-3977-4091-b2b1-629d98b11550
Looks like this is also related to https://github.com/Expensify/App/pull/30829
cc: @Skalakid @francoisl @akinwale
I think @dukenv0307's proposal makes sense. Thoughts, @Santhosh-Sellavel?
Waiting for feedback from @Santhosh-Sellavel
@Santhosh-Sellavel is OOO. Since this is a deploy blocker, I will help out here.
@dukenv0307's proposal looks good to me. π π π C+ reviewed
Current assignee @MariaHCD is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.
Thanks, @shubham1206agra!
π£ @dukenv0307 π An offer has been automatically sent to your Upwork account for the Contributor role π Thanks for contributing to the Expensify app!
Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review π§βπ» Keep in mind: Code of Conduct | Contributing π
@MariaHCD Can you please re-assign to the correct C+ so when I open the PR, bot can assign reviewer correctly.
π£ @shubham1206agra π An offer has been automatically sent to your Upwork account for the Contributor role π Thanks for contributing to the Expensify app!
Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review π§βπ» Keep in mind: Code of Conduct | Contributing π
Although perhaps we shouldn't proceed with a fix for this just yet: https://expensify.slack.com/archives/C01GTK53T8Q/p1708443654362909?thread_ts=1708443084.946829&cid=C01GTK53T8Q
Yes.
@shubham1206agra The PR is ready for review.
I don't think we're going to end up reverting the PR, we already merged other fixes and there would be too many conflicts to resolve at this point. @shubham1206agra please proceed with reviewing and testing the PR. Thanks!
Removing the deploy blocker label. Seems like something we can fix at the normal cadence.
PR was already merged and deployed.
is payment due here?
Yes
@miljakljajic Can you start payment process here?
@shubham1206agra and @dukenv0307 sent contracts to you both, previous job expired.
@miljakljajic I have discussed this internally here. You may close this issue whenever you pay the other contributor as I am keeping track of payment internally and will ask to pay once the issue is resolved. Just write in the payment summary that I still need to be paid.
Thank you @shubham1206agra
@shubham1206agra - owed 500 USD for their work on this issue.
@dukenv0307 please accept the offer when you can.
@dukenv0307 please accept the offer when you can.
@miljakljajic I accepted, thank you!
@miljakljajic You can process payment here now.
@miljakljajic Bump here.
@miljakljajic Bump for the payment.
@miljakljajic Bump here.
Paid!
If you havenβt already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.43-0 Reproducible in staging?: y Reproducible in production?: new feature If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: applause internal team Slack conversation:
Action Performed:
Expected Result:
Change in playback speed setting should take effect
Actual Result:
Change in playback seep doesn't take effect
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/43996225/c4743e25-6f29-4dfd-a2ee-0e50bb0ae3c9
View all open jobs on GitHub
Upwork Automation - Do Not Edit