search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.48k stars 2.84k forks source link

Investigate workflow job failing on main: e2ePerformanceTests / Run E2E tests in AWS device farm #37070

Closed github-actions[bot] closed 7 months ago

github-actions[bot] commented 8 months ago

🚨 Failure Summary 🚨:

⚠️ Action Required ⚠️:

🛠️ A recent merge appears to have caused a failure in the job named e2ePerformanceTests / Run E2E tests in AWS device farm. This issue has been automatically created and labeled with Workflow Failure for investigation.

👀 Please look into the following:

  1. Why the PR caused the job to fail?
  2. Address any underlying issues.

🐛 We appreciate your help in squashing this bug!

srikarparsi commented 7 months ago

Will take a look at this tomorrow

srikarparsi commented 7 months ago

Not sure what's going on, the performance tests seemed to have passed when I merged. @hannojg do you have any thoughts on this, it seems like it could be related to this message?

hannojg commented 7 months ago

(Copied from slack)

last week we merged a PR https://github.com/Expensify/App/pull/29991 that changes the navigation to use the native platform navigation components (better native like performance for navigation). However, it seems like it introduced a regression. That regression is currently also failing the e2e tests (thats how we detected the regression actually):

Issue: https://github.com/Expensify/App/issues/37156 PR mitigating the issue: https://github.com/Expensify/App/pull/37155

hannojg commented 7 months ago

So the mentioned PR hasn't anything todo with the failed tests

srikarparsi commented 7 months ago

Cool sounds good. In that case I'll close out this issue