search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.34k stars 2.77k forks source link

[Discussion] Wallet - User goes to Plaid after filling out the debit card fields #37265

Closed izarutskaya closed 6 months ago

izarutskaya commented 6 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.44-0 Reproducible in staging?: Y Reproducible in production?: Y Email or phone of affected tester (no customers): applausetester+022624dr003@applause.expensifail.com Logs: https://stackoverflow.com/c/expensify/questions/4856 Issue reported by: Applause-Internal Team

Action Performed:

  1. Open App or go to staging.new.expensify,com
  2. Log in with expensifail account
  3. Go to Wallet
  4. Select "Add bank account" > "Debit card"
  5. Fill in all fields using the card number from the Sandbox Test Cards list
  6. Tap/click "Save"

Expected Result:

Debit card saved

Actual Result:

User goes to Plaid (If bank accounts were previously added, then user will be asked to fill in additional details instead of Plaid). But the card is added.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

https://github.com/Expensify/App/assets/115492554/a97bd5b2-5666-4cb5-a53d-8198390b95ea

View all open jobs on GitHub

melvin-bot[bot] commented 6 months ago

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

izarutskaya commented 6 months ago

@strepanier03 I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

izarutskaya commented 6 months ago

We think that this bug might be related to #wave8-collect-admins CC @zanyrenney

strepanier03 commented 6 months ago

Thanks @izarutskaya - I'm working on testing this and will have a little internal chat, then move this forward tomorrow.

strepanier03 commented 6 months ago

Discussion ongoing here.

strepanier03 commented 6 months ago

tl;dr: Adding a debit card is useless unless the wallet is enabled. The only way to enable the wallet is to add a bank account. This means that adding the debit card is prompting Plaid so that the wallet can be enabled and be useful.

I'll update when I have a final decision on how to proceed.

strepanier03 commented 6 months ago

Discussion is still ongoing.

strepanier03 commented 6 months ago

Okay, we are going to close this for the following reason.

Adding a debit card, it is unusable unless the user also enables the wallet. Enabling the wallet requires adding the bank account (Plaid step). When you add a debit card, we prompt you to add your bank account via Plaid so that it can be used. There is currently no way the user would know that they have to enable the wallet to use the card.

Because of this, we're going to leave the prompts to add the bank account and enable the wallet after adding a debit card. This may change in the future if we create a way to alert customers to the need to enable the wallet. If we do that, we'd then allow adding the debit card without enabling the wallet via Plaid first.