Closed izarutskaya closed 7 months ago
Job added to Upwork: https://www.upwork.com/jobs/~01bcfec6134c6b50b2
Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External
)
Triggered auto assignment to @slafortune (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details.
:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Triggered auto assignment to @danieldoglas (Engineering
), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.
hm, that's very strange.
Also, in the first flow, you connected through plaid but you had to fill everything again.
We just reviewed the bank account flow recently on https://github.com/Expensify/App/pull/34498
@nkuoch can you please check this video and confirm if the flow the video is showing is correct?
Also @izarutskaya can you please confirm and post a video of this not happening in production?
⚠️ Looks like this issue was linked to a Deploy Blocker here
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
I wonder if the whole flow is failing because of the issue with the Radiobutton described on #37290
@danieldoglas I tested ZhenjaHorbach's proposal, and the issue with RadioButtons
disappears when we "modify the useEffect to only set a new value if it exists." However, the issue with the "add bank account flow" persists.
Is there a missing _
separating reimbursementAccount
from the id
?
Continuing to press Confirm
results in the observed issue:
I will further investigate. Additionally, along with the mentioned issue, I suspect it could be related to how we manage/clean Onyx. If, for some reason, BA registration is unsuccessful and there's an opportunity to redo it, calling RestartBankAccountSetup
also exhibits the same issue.
Is there a missing _ separating reimbursementAccount from the id?
I think we should have added, but looking into the backend and the app code, it was prepared to not have the _
so we should be all good here.
Can you also send me the requestIDs for those responses? That way I can check the logs on my side.
I think we should have added, but looking into the backend and the app code, it was prepared to not have the _ so we should be all good here.
humm ... I see
Can you also send me the requestIDs
Like this?
In the example above, I was unable to register the bank account successfully, instead I receive a message to confirm data in the chat. I click on 'reset registration', follow the flow again, and the reported issue appears.
@brunovjk I can see in the logs that the issue on the failure request is that plaidAccessToken
is being sent as empty string when you resend the request. So probably we're erasing it in the frontend code - that should help you find out what's happening.
Awesome! Thank you @danieldoglas!! Im on it!
Whoops, sorry got my issues mixed up. I believe this is still a blocker.
:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
I reverted this PR and was unable to reproduce the issue. Can anyone confirm please? Thanks. I continue working on a solution, any help is welcome :D
I've added the retest tag
Issue is reproducible during KI retests.
Will take a look myself, to see if I see any BE or FE issue.
Current assignee @abdulrahuman5196 is eligible for the Internal assigner, not assigning anyone new.
This will be a BE PR, no need for contributor plus
@nkuoch no payment is due on this one, right? Can this be closed now?
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v1.4.44-0 Reproducible in staging?: Y Reproducible in production?: N Email or phone of affected tester (no customers): applausetester+vd_web022624@applause.expensifail.com Logs: https://stackoverflow.com/c/expensify/questions/4856 Issue reported by: Applause-Internal Team
Action Performed:
Pre-requisite: the user must be logged in and have created a workspace.
Expected Result:
There should be any issue on the flow when trying to add the new BA.
Actual Result:
When trying to confirm the bank account, an error flickers and the user is not able to proceed with the flow. Also, if the user returns to the add BA modal, the new account seems to be connected.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
https://github.com/Expensify/App/assets/115492554/b1bc9943-0468-4c94-be78-f6e14574b56b
View all open jobs on GitHub
Upwork Automation - Do Not Edit