Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.53k stars 2.88k forks source link

[$500] Bank account - Error flickers when trying to add bank account after deleting previous one #37271

Closed izarutskaya closed 7 months ago

izarutskaya commented 8 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.4.44-0 Reproducible in staging?: Y Reproducible in production?: N Email or phone of affected tester (no customers): applausetester+vd_web022624@applause.expensifail.com Logs: https://stackoverflow.com/c/expensify/questions/4856 Issue reported by: Applause-Internal Team

Action Performed:

Pre-requisite: the user must be logged in and have created a workspace.

  1. Go to Workspace > Bank account.
  2. Using Connect online with Plaid, select Chase and complete the add BA flow.
  3. After BA has been added, disconnect the BA.
  4. Again, using Connect online with Plaid, select Regions and try to add the BA.
  5. On the account confirmation screen, click on "Confirm" button.
  6. Verify an error flickers and the user can not proceed with the flow.
  7. Exit the add BA modal.
  8. Go to Workspace > Bank account.
  9. Verify the new BA appears as connected.

Expected Result:

There should be any issue on the flow when trying to add the new BA.

Actual Result:

When trying to confirm the bank account, an error flickers and the user is not able to proceed with the flow. Also, if the user returns to the add BA modal, the new account seems to be connected.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

https://github.com/Expensify/App/assets/115492554/b1bc9943-0468-4c94-be78-f6e14574b56b

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01bcfec6134c6b50b2
  • Upwork Job ID: 1762427912527470592
  • Last Price Increase: 2024-02-27
melvin-bot[bot] commented 8 months ago

Job added to Upwork: https://www.upwork.com/jobs/~01bcfec6134c6b50b2

melvin-bot[bot] commented 8 months ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

melvin-bot[bot] commented 8 months ago

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

github-actions[bot] commented 8 months ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
melvin-bot[bot] commented 8 months ago

Triggered auto assignment to @danieldoglas (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

danieldoglas commented 8 months ago

hm, that's very strange.

Also, in the first flow, you connected through plaid but you had to fill everything again.

danieldoglas commented 8 months ago

We just reviewed the bank account flow recently on https://github.com/Expensify/App/pull/34498

danieldoglas commented 8 months ago

@nkuoch can you please check this video and confirm if the flow the video is showing is correct?

danieldoglas commented 8 months ago

Also @izarutskaya can you please confirm and post a video of this not happening in production?

melvin-bot[bot] commented 8 months ago

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

danieldoglas commented 8 months ago

I wonder if the whole flow is failing because of the issue with the Radiobutton described on #37290

brunovjk commented 8 months ago

@danieldoglas I tested ZhenjaHorbach's proposal, and the issue with RadioButtons disappears when we "modify the useEffect to only set a new value if it exists." However, the issue with the "add bank account flow" persists.

Please review the response when calling `ConnectBankAccountWithPlaid` in step 5: ![image](https://github.com/Expensify/App/assets/95647348/b49e335c-4a4c-4d36-aba1-53a248e0f880)

Is there a missing _ separating reimbursementAccount from the id?

Continuing to press Confirm results in the observed issue:

Consecutive responses to `ConnectBankAccountWithPlaid` call in step 5: ![image](https://github.com/Expensify/App/assets/95647348/625a8390-b67c-4bb8-a348-84d0f548ff72)

I will further investigate. Additionally, along with the mentioned issue, I suspect it could be related to how we manage/clean Onyx. If, for some reason, BA registration is unsuccessful and there's an opportunity to redo it, calling RestartBankAccountSetup also exhibits the same issue.

danieldoglas commented 8 months ago

Is there a missing _ separating reimbursementAccount from the id?

I think we should have added, but looking into the backend and the app code, it was prepared to not have the _ so we should be all good here.

Can you also send me the requestIDs for those responses? That way I can check the logs on my side.

brunovjk commented 8 months ago

I think we should have added, but looking into the backend and the app code, it was prepared to not have the _ so we should be all good here.

humm ... I see

Can you also send me the requestIDs

Like this?

First/Successful `ConnectBankAccountWithPlaid` response: ``` { "onyxData": [ { "onyxMethod": "merge", "key": "reimbursementAccount", "value": { "achData": { "routingNumber": "011401533", "accountNumber": "XXXXXXXXXXXX1111", "addressName": "XXXXXXXXXXXX1111", "isSavings": true, "bankAccountID": 3953947, "created": "2024-02-27 23:51:20", "state": "SETUP", "bankName": "Regions Bank", "country": "US", "currency": "USD", "enableCardAfterVerified": true, "fieldsType": "local", "hasFullSSN": false, "mask": "1111", "plaidAccountID": "oVG1eVgQgLfa5ZbGavVRiMm8qwEJk6foLDkdr", "policyID": "C2D04064D2525A53", "setupType": "plaid", "verifications": [], "currentStep": "RequestorStep" }, "errors": null } }, { "onyxMethod": "merge", "key": "reimbursementAccountC2D04064D2525A53", "value": { "achData": { "routingNumber": "011401533", "accountNumber": "XXXXXXXXXXXX1111", "addressName": "XXXXXXXXXXXX1111", "isSavings": true, "bankAccountID": 3953947, "created": "2024-02-27 23:51:20", "state": "SETUP", "bankName": "Regions Bank", "country": "US", "currency": "USD", "enableCardAfterVerified": true, "fieldsType": "local", "hasFullSSN": false, "mask": "1111", "plaidAccountID": "oVG1eVgQgLfa5ZbGavVRiMm8qwEJk6foLDkdr", "policyID": "C2D04064D2525A53", "setupType": "plaid", "verifications": [], "currentStep": "RequestorStep" }, "errors": null } }, { "onyxMethod": "set", "key": "onfidoToken", "value": "" }, { "key": "reimbursementAccount", "onyxMethod": "merge", "value": { "achData": { "accountNumber": "XXXXXXXXXXXX1111", "addressName": "XXXXXXXXXXXX1111", "bankAccountID": 3953947, "bankName": "Regions Bank", "country": "US", "created": "2024-02-27 23:51:20", "currency": "USD", "enableCardAfterVerified": true, "fieldsType": "local", "hasFullSSN": false, "isSavings": true, "mask": "1111", "plaidAccountID": "oVG1eVgQgLfa5ZbGavVRiMm8qwEJk6foLDkdr", "policyID": "C2D04064D2525A53", "routingNumber": "011401533", "setupType": "plaid", "state": "SETUP", "verifications": [] } } }, { "key": "reimbursementAccountC2D04064D2525A53", "onyxMethod": "merge", "value": { "achData": { "accountNumber": "XXXXXXXXXXXX1111", "addressName": "XXXXXXXXXXXX1111", "bankAccountID": 3953947, "bankName": "Regions Bank", "country": "US", "created": "2024-02-27 23:51:20", "currency": "USD", "enableCardAfterVerified": true, "fieldsType": "local", "hasFullSSN": false, "isSavings": true, "mask": "1111", "plaidAccountID": "oVG1eVgQgLfa5ZbGavVRiMm8qwEJk6foLDkdr", "policyID": "C2D04064D2525A53", "routingNumber": "011401533", "setupType": "plaid", "state": "SETUP", "verifications": [] } } } ], "jsonCode": 200, "requestID": "85c455d219243553-CNF", "previousUpdateID": 138593653, "lastUpdateID": 138757556 } ```
`RestartBankAccountSetup` ``` { "jsonCode": 200, "requestID": "85c47d65f8a83559-CNF", "onyxData": [ { "key": "report_8080116427258102", "onyxMethod": "merge", "value": { "lastReadTime": "2024-02-28 00:18:22.037" } }, { "key": "report_8080116427258102", "onyxMethod": "merge", "value": { "lastActorAccountID": 16460731, "lastMentionedTime": null, "lastMessageText": "updated the default business bank account to \"None\"", "lastReadTime": "2024-02-28 00:18:22.037", "lastVisibleActionCreated": "2024-02-28 00:18:22.037", "maxSequenceNumber": null, "reportID": "8080116427258102" } }, { "key": "reportActions_8080116427258102", "onyxMethod": "merge", "shouldNotify": true, "value": { "1265675800217017416": { "actionName": "POLICYCHANGELOG_UPDATE_ACH_ACCOUNT", "actorAccountID": 16460731, "automatic": false, "avatar": "https:\/\/d2k5nsl2zxldvw.cloudfront.net\/images\/avatars\/default-avatar_20.png", "created": "2024-02-28 00:18:22.037", "isAttachment": false, "lastModified": "2024-02-28 00:18:22.037", "message": [ { "html": "updated the default business bank account to \"None\"", "isDeletedParentAction": false, "isEdited": false, "reactions": [], "text": "updated the default business bank account to \"None\"", "type": "COMMENT", "whisperedTo": [] } ], "originalMessage": { "bankAccountName": "", "lastModified": "2024-02-28 00:18:22.037", "maskedBankAccountNumber": "" }, "person": [ { "style": "strong", "text": "Bruno Rocha", "type": "TEXT" } ], "previousReportActionID": "3512067784918861444", "reportActionID": "1265675800217017416", "reportActionTimestamp": 1709079502037, "sequenceNumber": null, "shouldShow": true, "timestamp": 1709079502, "whisperedToAccountIDs": [] } } } ], "previousUpdateID": 138790143, "lastUpdateID": 138790448 } ```
First after restart `ConnectBankAccountWithPlaid` response: ``` { "onyxData": [ { "onyxMethod": "merge", "key": "reimbursementAccount", "value": { "achData": { "routingNumber": "011401533", "accountNumber": "XXXXXXXXXXXX1111", "addressName": "Alberta Bobbeth Charleson", "isSavings": true, "bankAccountID": 3953947, "created": "2024-02-27 23:51:20", "state": "VERIFYING", "acceptTerms": true, "addressCity": "Anchorage", "addressState": "AK", "addressStreet": "123 Place Street", "addressZipCode": "99504", "bankName": "Regions Bank", "beneficialOwners": [], "certifyTrueInformation": true, "companyName": "Alberta Bobbeth Charleson", "companyPhone": "4404521379", "companyTaxID": "123456789", "country": "US", "currency": "USD", "dateSigned": "2024-02-28 00:17:55", "dob": "2006-02-02", "enableCardAfterVerified": true, "fieldsType": "local", "firstName": "Alberta", "hasFullSSN": true, "hasNoConnectionToCannabis": true, "incorporationDate": "2024-02-01", "incorporationState": "AK", "incorporationType": "LLC", "industryCode": "623110", "isAuthorizedToUseBankAccount": true, "isControllingOfficer": false, "isOnfidoSetupComplete": true, "lastName": "Charleson", "lastUpdate": "2024-02-28 00:18:22", "mask": "1111", "ownsMoreThan25Percent": false, "plaidAccountID": "zPRaBWlPPRtk77rEBnqVtPmAzDGaLBtlNEVE7", "previousState": 2, "requestorAddressCity": "Anchorage", "requestorAddressState": "AK", "requestorAddressStreet": "123 Place Street", "requestorAddressZipCode": "99504", "setupType": "plaid", "ssnLast4": "3333", "verifications": { "blackListed": { "isBankAccountCopy": false, "isBlackListedAddress": false, "isBlackListedName": false, "isBlackListedUser": false, "isFlagged": false } }, "website": "https:\/\/g.com", "currentStep": "RequestorStep" }, "errors": null } }, { "onyxMethod": "merge", "key": "reimbursementAccountC2D04064D2525A53", "value": { "achData": { "routingNumber": "011401533", "accountNumber": "XXXXXXXXXXXX1111", "addressName": "Alberta Bobbeth Charleson", "isSavings": true, "bankAccountID": 3953947, "created": "2024-02-27 23:51:20", "state": "VERIFYING", "acceptTerms": true, "addressCity": "Anchorage", "addressState": "AK", "addressStreet": "123 Place Street", "addressZipCode": "99504", "bankName": "Regions Bank", "beneficialOwners": [], "certifyTrueInformation": true, "companyName": "Alberta Bobbeth Charleson", "companyPhone": "4404521379", "companyTaxID": "123456789", "country": "US", "currency": "USD", "dateSigned": "2024-02-28 00:17:55", "dob": "2006-02-02", "enableCardAfterVerified": true, "fieldsType": "local", "firstName": "Alberta", "hasFullSSN": true, "hasNoConnectionToCannabis": true, "incorporationDate": "2024-02-01", "incorporationState": "AK", "incorporationType": "LLC", "industryCode": "623110", "isAuthorizedToUseBankAccount": true, "isControllingOfficer": false, "isOnfidoSetupComplete": true, "lastName": "Charleson", "lastUpdate": "2024-02-28 00:18:22", "mask": "1111", "ownsMoreThan25Percent": false, "plaidAccountID": "zPRaBWlPPRtk77rEBnqVtPmAzDGaLBtlNEVE7", "previousState": 2, "requestorAddressCity": "Anchorage", "requestorAddressState": "AK", "requestorAddressStreet": "123 Place Street", "requestorAddressZipCode": "99504", "setupType": "plaid", "ssnLast4": "3333", "verifications": { "blackListed": { "isBankAccountCopy": false, "isBlackListedAddress": false, "isBlackListedName": false, "isBlackListedUser": false, "isFlagged": false } }, "website": "https:\/\/g.com", "currentStep": "RequestorStep" }, "errors": null } }, { "onyxMethod": "set", "key": "onfidoToken", "value": "" }, { "key": "reimbursementAccount", "onyxMethod": "set", "value": { "acceptTerms": true, "accountNumber": "XXXXXXXXXXXX1111", "addressCity": "Anchorage", "addressName": "Alberta Bobbeth Charleson", "addressState": "AK", "addressStreet": "123 Place Street", "addressZipCode": "99504", "bankAccountID": 3953947, "bankName": "Regions Bank", "beneficialOwners": [], "certifyTrueInformation": true, "companyName": "Alberta Bobbeth Charleson", "companyPhone": "4404521379", "companyTaxID": "123456789", "country": "US", "created": "2024-02-27 23:51:20", "currency": "USD", "currentStep": "RequestorStep", "dateSigned": "2024-02-28 00:17:55", "dob": "2006-02-02", "enableCardAfterVerified": true, "fieldsType": "local", "firstName": "Alberta", "hasFullSSN": true, "hasNoConnectionToCannabis": true, "incorporationDate": "2024-02-01", "incorporationState": "AK", "incorporationType": "LLC", "industryCode": "623110", "isAuthorizedToUseBankAccount": true, "isControllingOfficer": false, "isOnfidoSetupComplete": true, "isSavings": true, "lastName": "Charleson", "lastUpdate": "2024-02-28 00:18:22", "mask": "1111", "ownsMoreThan25Percent": false, "plaidAccountID": "vNKzgbgrPdF3Llx1D6NkFz4g5LplQJCqDgvRG", "policyID": "C2D04064D2525A53", "previousState": 2, "requestorAddressCity": "Anchorage", "requestorAddressState": "AK", "requestorAddressStreet": "123 Place Street", "requestorAddressZipCode": "99504", "routingNumber": "011401533", "setupType": "plaid", "ssnLast4": "3333", "state": "VERIFYING", "verifications": { "blackListed": { "isBankAccountCopy": false, "isBlackListedAddress": false, "isBlackListedName": false, "isBlackListedUser": false, "isFlagged": false } }, "website": "https:\/\/g.com" } }, { "key": "reimbursementAccountC2D04064D2525A53", "onyxMethod": "set", "value": { "acceptTerms": true, "accountNumber": "XXXXXXXXXXXX1111", "addressCity": "Anchorage", "addressName": "Alberta Bobbeth Charleson", "addressState": "AK", "addressStreet": "123 Place Street", "addressZipCode": "99504", "bankAccountID": 3953947, "bankName": "Regions Bank", "beneficialOwners": [], "certifyTrueInformation": true, "companyName": "Alberta Bobbeth Charleson", "companyPhone": "4404521379", "companyTaxID": "123456789", "country": "US", "created": "2024-02-27 23:51:20", "currency": "USD", "currentStep": "RequestorStep", "dateSigned": "2024-02-28 00:17:55", "dob": "2006-02-02", "enableCardAfterVerified": true, "fieldsType": "local", "firstName": "Alberta", "hasFullSSN": true, "hasNoConnectionToCannabis": true, "incorporationDate": "2024-02-01", "incorporationState": "AK", "incorporationType": "LLC", "industryCode": "623110", "isAuthorizedToUseBankAccount": true, "isControllingOfficer": false, "isOnfidoSetupComplete": true, "isSavings": true, "lastName": "Charleson", "lastUpdate": "2024-02-28 00:18:22", "mask": "1111", "ownsMoreThan25Percent": false, "plaidAccountID": "vNKzgbgrPdF3Llx1D6NkFz4g5LplQJCqDgvRG", "policyID": "C2D04064D2525A53", "previousState": 2, "requestorAddressCity": "Anchorage", "requestorAddressState": "AK", "requestorAddressStreet": "123 Place Street", "requestorAddressZipCode": "99504", "routingNumber": "011401533", "setupType": "plaid", "ssnLast4": "3333", "state": "VERIFYING", "verifications": { "blackListed": { "isBankAccountCopy": false, "isBlackListedAddress": false, "isBlackListedName": false, "isBlackListedUser": false, "isFlagged": false } }, "website": "https:\/\/g.com" } }, { "key": "reimbursementAccountDraft", "onyxMethod": "set", "value": null }, { "key": "reimbursementAccountC2D04064D2525A53Draft", "onyxMethod": "set", "value": null }, { "key": "onfidoApplicantID", "onyxMethod": "set", "value": null }, { "key": "onfidoToken", "onyxMethod": "set", "value": null }, { "key": "plaidData", "onyxMethod": "set", "value": null }, { "key": "plaidLinkToken", "onyxMethod": "set", "value": null }, { "key": "reimbursementAccount", "onyxMethod": "merge", "value": { "achData": { "acceptTerms": true, "accountNumber": "XXXXXXXXXXXX1111", "addressCity": "Anchorage", "addressName": "Alberta Bobbeth Charleson", "addressState": "AK", "addressStreet": "123 Place Street", "addressZipCode": "99504", "bankAccountID": 3953947, "bankName": "Regions Bank", "beneficialOwners": [], "certifyTrueInformation": true, "companyName": "Alberta Bobbeth Charleson", "companyPhone": "4404521379", "companyTaxID": "123456789", "country": "US", "created": "2024-02-27 23:51:20", "currency": "USD", "dateSigned": "2024-02-28 00:17:55", "dob": "2006-02-02", "enableCardAfterVerified": true, "fieldsType": "local", "firstName": "Alberta", "hasFullSSN": true, "hasNoConnectionToCannabis": true, "incorporationDate": "2024-02-01", "incorporationState": "AK", "incorporationType": "LLC", "industryCode": "623110", "isAuthorizedToUseBankAccount": true, "isControllingOfficer": false, "isOnfidoSetupComplete": true, "isSavings": true, "lastName": "Charleson", "lastUpdate": "2024-02-28 00:18:22", "mask": "1111", "ownsMoreThan25Percent": false, "plaidAccountID": "zPRaBWlPPRtk77rEBnqVtPmAzDGaLBtlNEVE7", "previousState": 2, "requestorAddressCity": "Anchorage", "requestorAddressState": "AK", "requestorAddressStreet": "123 Place Street", "requestorAddressZipCode": "99504", "routingNumber": "011401533", "setupType": "plaid", "ssnLast4": "3333", "state": "VERIFYING", "verifications": { "blackListed": { "isBankAccountCopy": false, "isBlackListedAddress": false, "isBlackListedName": false, "isBlackListedUser": false, "isFlagged": false } }, "website": "https:\/\/g.com" } } }, { "key": "reimbursementAccountC2D04064D2525A53", "onyxMethod": "merge", "value": { "achData": { "acceptTerms": true, "accountNumber": "XXXXXXXXXXXX1111", "addressCity": "Anchorage", "addressName": "Alberta Bobbeth Charleson", "addressState": "AK", "addressStreet": "123 Place Street", "addressZipCode": "99504", "bankAccountID": 3953947, "bankName": "Regions Bank", "beneficialOwners": [], "certifyTrueInformation": true, "companyName": "Alberta Bobbeth Charleson", "companyPhone": "4404521379", "companyTaxID": "123456789", "country": "US", "created": "2024-02-27 23:51:20", "currency": "USD", "dateSigned": "2024-02-28 00:17:55", "dob": "2006-02-02", "enableCardAfterVerified": true, "fieldsType": "local", "firstName": "Alberta", "hasFullSSN": true, "hasNoConnectionToCannabis": true, "incorporationDate": "2024-02-01", "incorporationState": "AK", "incorporationType": "LLC", "industryCode": "623110", "isAuthorizedToUseBankAccount": true, "isControllingOfficer": false, "isOnfidoSetupComplete": true, "isSavings": true, "lastName": "Charleson", "lastUpdate": "2024-02-28 00:18:22", "mask": "1111", "ownsMoreThan25Percent": false, "plaidAccountID": "zPRaBWlPPRtk77rEBnqVtPmAzDGaLBtlNEVE7", "previousState": 2, "requestorAddressCity": "Anchorage", "requestorAddressState": "AK", "requestorAddressStreet": "123 Place Street", "requestorAddressZipCode": "99504", "routingNumber": "011401533", "setupType": "plaid", "ssnLast4": "3333", "state": "VERIFYING", "verifications": { "blackListed": { "isBankAccountCopy": false, "isBlackListedAddress": false, "isBlackListedName": false, "isBlackListedUser": false, "isFlagged": false } }, "website": "https:\/\/g.com" } } } ], "jsonCode": 200, "requestID": "85c480f6380c3553-CNF", "previousUpdateID": 138790448, "lastUpdateID": 138793030 } ```
Sequential/Failure`ConnectBankAccountWithPlaid` response: ``` { "code": 666, "jsonCode": 666, "type": "Expensify\\Libs\\Error\\ExpError", "UUID": "fc38abb3-e3d1-4abd-b6fd-4e05be7a751b", "message": "An unexpected error occurred while trying to add your bank account via Plaid.", "title": "", "data": { "onyxData": [ { "onyxMethod": "merge", "key": "reimbursementAccountC2D04064D2525A53", "value": { "errors": { "1709079671718244": "An unexpected error occurred while trying to add your bank account via Plaid." } } }, { "onyxMethod": "merge", "key": "reimbursementAccount", "value": { "errors": { "1709079671718251": "An unexpected error occurred while trying to add your bank account via Plaid." } } } ] }, "htmlMessage": "", "onyxData": [ { "onyxMethod": "merge", "key": "reimbursementAccountC2D04064D2525A53", "value": { "errors": { "1709079671718244": "An unexpected error occurred while trying to add your bank account via Plaid." } } }, { "onyxMethod": "merge", "key": "reimbursementAccount", "value": { "errors": { "1709079671718251": "An unexpected error occurred while trying to add your bank account via Plaid." } } } ], "requestID": "85c481893ed73553-CNF" } ```

In the example above, I was unable to register the bank account successfully, instead I receive a message to confirm data in the chat. I click on 'reset registration', follow the flow again, and the reported issue appears.

danieldoglas commented 8 months ago

@brunovjk I can see in the logs that the issue on the failure request is that plaidAccessToken is being sent as empty string when you resend the request. So probably we're erasing it in the frontend code - that should help you find out what's happening.

brunovjk commented 8 months ago

Awesome! Thank you @danieldoglas!! Im on it!

puneetlath commented 8 months ago

Whoops, sorry got my issues mixed up. I believe this is still a blocker.

github-actions[bot] commented 8 months ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
brunovjk commented 8 months ago

I reverted this PR and was unable to reproduce the issue. Can anyone confirm please? Thanks. I continue working on a solution, any help is welcome :D

slafortune commented 8 months ago

I've added the retest tag

mvtglobally commented 8 months ago

Issue is reproducible during KI retests.

nkuoch commented 8 months ago

Will take a look myself, to see if I see any BE or FE issue.

melvin-bot[bot] commented 8 months ago

Current assignee @abdulrahuman5196 is eligible for the Internal assigner, not assigning anyone new.

nkuoch commented 8 months ago

This will be a BE PR, no need for contributor plus

slafortune commented 7 months ago

@nkuoch no payment is due on this one, right? Can this be closed now?