[HOLD for payment 2024-03-22] [$500] Tag - Selected tag in Parent: Child format is displayed as Parent\: Child in split menu

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.44-0 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:

Action Performed:

Precondition:

• User is an employee of paid workspace
• The paid workspace has tags in Parent: Child format
  1. Go to workspace chat
  2. Go to + > Split bill > Scan
  3. Select a receipt
  4. Click Tag
  5. Select a tag in Parent: Child format
  6. Click Split
  7. Click on the split preview

Expected Result:

The selected Tag in Parent: Child format will be displayed correctly in the split menu

Actual Result:

The selected Tag in Parent: Child format is displayed as Parent\: Child in split menu

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [x] Android: Native
• [x] Android: mWeb Chrome
• [x] iOS: Native
• [x] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [x] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/dc8aa00e-58dd-4b45-849d-19263e4ca41e

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a0f7b9261707ddc4
• Upwork Job ID: 1762476499067256832
• Last Price Increase: 2024-03-06
• Automatic offers:
• dukenv0307 | Contributor | 0

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~01a0f7b9261707ddc4

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[github-actions[bot]]

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot[bot]]

Triggered auto assignment to @iwiznia (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[lanitochka17]

We think that this bug might be related to #vip-split-p2p-chat-groups CC @arielgreen

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Tag - Selected tag in Parent: Child format is displayed as Parent\: Child in split menu

What is the root cause of that problem?

When implementing multilevel tags in https://github.com/Expensify/App/pull/34983 we missed the colon cleaning code here https://github.com/Expensify/App/blob/cfa0ae37156208ebecdc6b2126464ec462271b76/src/components/MoneyRequestConfirmationList.js#L792-L793

What changes do you think we should make in order to solve the problem?

we should clean the escaping char as

                                title={PolicyUtils.getCleanedTagName(TransactionUtils.getTag(transaction, index))}

What alternative solutions did you explore? (Optional)

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Tag - Selected tag in Parent: Child format is displayed as Parent\: Child in split menu

  What is the root cause of that problem?

• In here we do not use getTagForDisplay to display the tag, that leads to the bug (see PR)

  What changes do you think we should make in order to solve the problem?

• We should use title={TransactionUtils.getTagForDisplay(transaction, index)} instead

What alternative solutions did you explore? (Optional)

• NA

[iwiznia]

Context https://expensify.slack.com/archives/C01GTK53T8Q/p1709049225214569 Seems this was fixed in https://github.com/Expensify/App/pull/36978

[kbecciv]

QA team is able to reproduce the issue on build 1.4.47.0 Account - applausetester+kh040301@applause.expensifail.com

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[mananjadhav]

This is not a deploy blocker, but seems like earlier PR didn't fix this.

@dukenv0307 @FitseTLT Can you review your own proposals and confirm if they're still valid? If yes, then I can take a look.

[FitseTLT]

This is not a deploy blocker, but seems like earlier PR didn't fix this.

@dukenv0307 @FitseTLT Can you review your own proposals and confirm if they're still valid? If yes, then I can take a look.

Yep @mananjadhav

[mananjadhav]

I think it makes sense to use getTagForDisplay as it already has getCleanedTagName method call. @dukenv0307's proposal looks good.

🎀 👀 🎀 C+ reviewed.

[melvin-bot[bot]]

Current assignee @yuwenmemon is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[melvin-bot[bot]]

📣 @dukenv0307 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

[dukenv0307]

@mananjadhav PR https://github.com/Expensify/App/pull/38111 is ready to review

[mananjadhav]

Done with the PR Review, waiting on @yuwenmemon now.

[yuwenmemon]

Merged!

[melvin-bot[bot]]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot[bot]]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.52-6 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/38111

If no regressions arise, payment will be issued on 2024-03-22. :confetti_ball:

For reference, here are some details about the assignees on this issue:

• @mananjadhav requires payment through NewDot Manual Requests
• @dukenv0307 requires payment automatic offer (Contributor)

[mananjadhav]

We replaced the PolicyUtils.getCleanedTagName(props.iouTag) here with TransactionUtils.getTag(transaction, index) which caused the issue. I posted this comment.

I am not sure if we should be adding a regression test here. @yuwenmemon wdyt? Also can you assign a BZ member here for the payout?

[mananjadhav]

Quick bump @yuwenmemon

[melvin-bot[bot]]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[JmillsExpensify]

@adelekennedy Can you provide a payment summary and help with payouts please. Thanks!

[adelekennedy]

Payouts due:

Contributor: $500 @dukenv0307 (Upwork) Contributor+: $500 @mananjadhav (NewDot)

Upwork job is here.

[JmillsExpensify]

$500 approved for @mananjadhav.