[HOLD for payment 2024-09-11] ][$500] Lack of maximum height for the `description` field for room hides other options on the page

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.44-2 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @JmillsExpensify Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1709046310280799

Action Performed:

1. Create a room in the workspace with lengthy description
2. Open the room and view the details of the room

Expected Result:

All the option in the details page should be visible restricting the max height of the description field

Actual Result:

Lack of a max height for the description field obscures other options

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android: Native
• [ ] Android: mWeb Chrome
• [x] iOS: Native
• [ ] iOS: mWeb Safari
• [ ] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b55a4d576f4c3f8a
• Upwork Job ID: 1762602581669859328
• Last Price Increase: 2024-03-26
• Automatic offers:
• shubham1206agra | Reviewer | 0
• brandonhenry | Contributor | 0

Issue Owner

Current Issue Owner: @greg-schroeder

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[greg-schroeder]

Thoughts on https://github.com/Expensify/App/issues/37357#issuecomment-2016628057 @ishpaul777?

[ishpaul777]

I asked a volunteer c+ here https://expensify.slack.com/archives/C02NK2DQWUX/p1711481272237069, I won't be able to priortize this soon :-(

[greg-schroeder]

Adding to #vip-vsb per roadmap doc:

Anything related to a DM, room, group chat, thread, or task is in scope for here

[shubham1206agra]

I have checked the https://github.com/Expensify/App/issues/37357#issuecomment-2016628057, and @brandonhenry's solution seems to work properly.

So, let's proceed with @brandonhenry's proposal.

🎀👀🎀 C+ reviewed

Side note - @brandonhenry The limit should be fine-tunable through prop and optional.

[melvin-bot[bot]]

Triggered auto assignment to @puneetlath, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[shubham1206agra]

Proof of solution working on native iOS

[puneetlath]

For my understanding, does this solution require us to add a new dependency?

[shubham1206agra]

No, we will update it inside expensify-common

[melvin-bot[bot]]

📣 @shubham1206agra 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job

[melvin-bot[bot]]

📣 @shubham1206agra 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot[bot]]

📣 @brandonhenry 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

[brandonhenry]

Thank you! Already have the code for this so will get the expensify-common request in today!

[puneetlath]

@brandonhenry how's it going?

[brandonhenry]

Submitting PR over at expensify-common right now

[mallenexpensify]

@brandonhenry per CONTRIBUTING.md,

New contributors are limited to working on one job at a time, however experienced contributors may work on numerous jobs simultaneously.

You currently have 6 issues open with non merged or closed. Please do not submit proposals for new issues until all six PRs have been merged.

[brandonhenry]

This one is in review at expensify-common. PR

[brandonhenry]

this is still pending review over at expensify-common

[brandonhenry]

Got some small styling related updates from review. Hopefully have this PR done by tomorrow 🥳 updating expensify-common PR now

[greg-schroeder]

Work on PR continues

[brandonhenry]

Just gotta do some more thorough testing and add test cases to ticket

[brandonhenry]

Created test to verify against all possible markdown. Still working on the unit tests. Will wrap all this up today

[brandonhenry]

Tests done and updated. back in hands of reviewers

[greg-schroeder]

Linked PR in review

[brandonhenry]

got feedback on this today. just got it turned back around

[greg-schroeder]

Linked PR in review

Same story! Hopefully we can get this merged this week!

[brandonhenry]

Pushing on this in review now - all wrapped up

[brandonhenry]

@greg-schroeder @puneetlath @shubham1206agra not sure what the holdup on this one is but like to convene to get this merged this week. I went with agreed upon proposal, but seems there is pushback on truncating markdown using my method. Just like to agree on a direction and get this wrapped up - thanks!

Edit: Seems there is some concern with my function not handling all markdown. If that is the case, I think we increase unit test count for the edge cases @shubham1206agra believes will fail. I believe this works in all markdown cases.

Edit 2: I'm adding in those tests now..

[brandonhenry]

To note:

• Created a new utility function truncateMarkdown inside ExpensiMark.js class that will accept markdown text, a limit, and whether to add ellipsis and return the truncated markdown
• This function will give us the ability to add a limit to the character count of the description field for rooms while still maintaining proper markdown
• I've written 8 unit tests to verify proper conversion and truncation
• PR

[brandonhenry]

I just added more test that handle every possible edge case. My additional tests are based on the current html to markdown test in the repo and will start with html, convert to markdown, then truncate. I am confident my methodology handles all cases @shubham1206agra

[brandonhenry]

Added example on ExpensifyApp PR request per review comment.

[brandonhenry]

This is still awaiting review..

Cc. @shubham1206agra @puneetlath @greg-schroeder

[brandonhenry]

still awaiting review from C+...

Cc. @shubham1206agra @puneetlath @greg-schroeder

[greg-schroeder]

PR remains in review

[greg-schroeder]

Hey @brandonhenry - it seems @NikkiWines requested some changes on your PR, are you able to address those?

[brandonhenry]

@greg-schroeder sorry team. I was affected by the recent natural disaster in NW Houston. I have been without power for 7 days straight and was told ETA for restoration is today. I'm praying I can be back online by tomorrow. Cell service has also been very spotty

Source: https://www.centerpointenergy.com/en-us/corporate/about-us/news/1751

[mallenexpensify]

Damn, sorry to hear @brandonhenry , hope everyone's safe and that you get power back soon.

[brandonhenry]

thanks @mallenexpensify ! our power came back on late last night. acclimating back into normal life so will try to update here over the weekend. Thanks again for the patience 🙏🏿

[brandonhenry]

@mallenexpensify finally getting back into the swing of things. Had to catch back up on a lot but I will have updates for this ticket today. Thank you for the patience!

[greg-schroeder]

Thanks for your perseverance here @brandonhenry!

[brandonhenry]

update coming here soon.. unfortunately haven't caught a break as my eldest cat got deathly sick out of the blue and had to do emergency vet trip ..

[brandonhenry]

This ticket is back in review and hopefully very close to being approved

[greg-schroeder]

Thanks for your effort here!

[melvin-bot[bot]]

This issue has not been updated in over 15 days. @puneetlath, @brandonhenry, @greg-schroeder, @shubham1206agra eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[brandonhenry]

This ticket is actively being worked on. Currently in final stages of review here

[greg-schroeder]

Setting back to Daily here as there's active progress and last updates from @NikkiWines indicate that we're close here

[melvin-bot[bot]]

@puneetlath, @brandonhenry, @greg-schroeder, @shubham1206agra Whoops! This issue is 2 days overdue. Let's get this updated quick!

[brandonhenry]

My power has been out since Monday, July 8 - due to hurricane Beryl knocking off power for all of Houston. I just came back online today. Catching up and wrapping things up!

[brandonhenry]

Sent this back over for final review 🤞🏿 this is pushed through tomorrow

[brandonhenry]

The PR in expensify-common was just merged!! 🙌🏿 applying the fix in this PR and doing final checks. Hopefully have this reviewed and out soon!

Cc. @greg-schroeder @mallenexpensify