[HOLD for payment 2024-09-10] [$1000] Upgrade to RN 0.75

roryabraham commented 6 months ago

slack context: https://expensify.slack.com/archives/C02NK2DQWUX/p1709024519896479

Problem

There are some new arch problems that should be fixed in RN 0.74+. So far that's the only thing I'm aware of in 0.74+ that we'll need, but it takes a long time to upgrade. It's not necessarily a blocker but unless we upgrade we'll have to use patches.

Solution

Let's get the ball rolling on the RN 0.74 upgrade. If there are issues in the RC we should report them to Meta.

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021833172516619025999
Upwork Job ID: 1833172516619025999
Last Price Increase: 2024-09-09

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @dylanexpensify

MrRefactor commented 2 months ago

Update 26.06

PR link -> https://github.com/Expensify/App/pull/40548 PR is ready to be tested/reviewed by C+ PR is under regression testing from QA team

Builds link -> here

Hey hey,

Fixed: -> iOS images issue @kubabutkiewicz -> Updated all of the expo libraries

Working on: -> weird background flashing while selecting emoji/animation glitches on android @MrRefactor -> CI jest pipeline crashing @MrRefactor @kubabutkiewicz -> update PR description with all of the patches applied and upstream links @MrRefactor -> Removing potentially unnecessary patches for react-native-cli @MrRefactor

Also @hannojg please let us know when new release of react-native-release-profiler will be ready so we can remove react-native-cli version workarounds.

CC: @mallenexpensify @roryabraham @mountiny @koko57 @kubabutkiewicz

MrRefactor commented 2 months ago

Update 27.06

PR link -> https://github.com/Expensify/App/pull/40548 PR is ready to be tested/reviewed by C+ PR is under regression testing from QA team

Builds link -> here

Hey hey,

Fixed: -> attachment preview image fix @kubabutkiewicz -> update PR description with all of the patches applied and upstream links @MrRefactor

Working on: -> weird background flashing while selecting emoji/animation glitches on android @MrRefactor -> CI jest pipeline crashing @MrRefactor @kubabutkiewicz

CC: @mallenexpensify @roryabraham @mountiny @kubabutkiewicz

MrRefactor commented 2 months ago

Update 01.07

PR link -> https://github.com/Expensify/App/pull/40548 PR is ready to be tested/reviewed by C+ PR is under regression testing from QA team Builds link -> here

Hey hey,

StrictMode enabled: We have encountered several critical issues after merging newest main with enabled StrictMode, for both android and iOS mobile main screen is not working at all, we cannot navigate etc.

https://github.com/Expensify/App/assets/32591413/5efba304-d4bb-4f09-a718-2a9667db5afb

For web there are issues connected with:

attachment preview not loading,
attachment modal crash

How should we tackle those issues? Disabling StrictMode is resolving all of them. Could team that implemented StrictMode help us with those issues?

Working on: -> weird background flashing while selecting emoji/animation glitches on android @MrRefactor -> CI jest pipeline crashing @MrRefactor @kubabutkiewicz

CC: @mallenexpensify @roryabraham @mountiny @kubabutkiewicz

Kicu commented 2 months ago

@MrRefactor hey I was working on StrictMode and spent a lot of time fighting similar bugs. On RN 73 the main culprits was react-navigation and reanimated, and I introduced these 2 patches to fix it: https://github.com/Expensify/App/pull/42592/files#diff-8e669add6c10c59477d19de093739cc27882aeaeafcf1dcd920891f3affad29a

What you are describing on native apps is exactly what used to happen on web (cannot navigate problem) and the patch fixed it. I have no idea what exactly could RN 74 change that adds bugs similar to this one. Did you already try removing all build artefacts and re-running install to make sure patches are applied ok? Just to be 100% sure.

As far as native logic goes - did you add any modifications in the app that might be related to navigation, first loaded screen etc? Any new useEffect hooks that were added?

hannojg commented 2 months ago

@MrRefactor a new version of react-native-release-profiler is available, which should be compatible with RN 0.74 now 😊

MrRefactor commented 2 months ago

@MrRefactor a new version of react-native-release-profiler is available, which should be compatible with RN 0.74 now 😊

Thanks, I will check it tomorrow morning!

Kicu commented 2 months ago

@MrRefactor @roryabraham I spend some time investigating (with great help from @WoLewicki 🙏) and I think I found the issue and a fix.

tl;dr is this: We need the same patch for navigation applied to another file. We should merge this PR that I prepared: https://github.com/Expensify/App/pull/44726 and then @MrRefactor you can continue using the updated patch. I have checked out your branch and built the app from scratch with 0.74 and confirmed that navigation issues disappear.

details

The biggest finding is that StrictMode did not work on RN 0.73 on native apps. I have no idea why and I did not know that was the case when I created the original PR. Don't know whether it was intended by react team or just a bug.

In my original PR I focused on web, investigated concurrent react and made web work. When I ran ios/android builds - they just worked, so I assumed everything was ok on the native side.

However now I have confirmed that on RN 0.73 StrictMode in fact does nothing, no double renders but on RN 0.74 we get a working StrictMode for the first time on native. That's why all these bugs emerged just now. Sorry that this happened on your issue, but we should be able to still move forward. I will be also available to help with any other bugs in future, together with @WoLewicki.

MrRefactor commented 2 months ago

Update 02.07

PR link -> https://github.com/Expensify/App/pull/40548 PR is ready to be tested/reviewed by C+ PR is under regression testing from QA team

Builds link -> link

Hey hey,

Fixed: -> CI jest pipeline crashing @MrRefactor @kubabutkiewicz -> updated version of react-native-release-profiler and removed overrides for rn-cli @MrRefactor -> applied patch for StrictMode for native platforms by @Kicu

Bugs status:

Work in progress: Android - Composer - Previous text is cut off after creating next line @MrRefactor Android - Composer - Pasted multiline message is displayed in one line @MrRefactor Android - Composer - The suggestion list appears with spacing above the composer @MrRefactor Android - Chat - Green background flickers when dismissing the + modal @MrRefactor

IOU - Same results appear twice when search email on submit expense modal @kacper-mikolajczak Task – Hidden assignee appears in LHN when assign task without assignee to yourself @kacper-mikolajczak

IOS-Distance rate-Keyboard not open/disappear smoothly when selecting default category @MrRefactor IOS/Android - Videoplayer controls issue @kubabutkiewicz

Fixed: IOS - Image preview before sending is not displayed for images from the gallery @MrRefactor iOS - Track expense - App crashes after selecting track expense @MrRefactor iOS - App crashes after selecting a video as the attachment to send @MrRefactor iOS - No image preview on confirmation screen when creating scan request @MrRefactor Android - Expense - Cursor positions behind the currency when editing amount @MrRefactor

CC: @mallenexpensify @roryabraham @mountiny @kubabutkiewicz

MrRefactor commented 2 months ago

Update 03.07

PR link -> https://github.com/Expensify/App/pull/40548 PR is ready to be tested/reviewed by C+ PR is under regression testing from QA team

Hey hey,

Working on: -> fixing issues related to strictMode @kubabutkiewicz @kacper-mikolajczak -> Upgrading to rn 0.74.3 @MrRefactor

Bugs status: Work in progress: Android - Composer - Previous text is cut off after creating next line @MrRefactor Android - Composer - Pasted multiline message is displayed in one line @MrRefactor Android - Composer - The suggestion list appears with spacing above the composer @MrRefactor Android - Chat - Green background flickers when dismissing the + modal @MrRefactor Android - Expense - App flickers when opening and closing year picker repeatedly @MrRefactor Android - Workspace chat avatar preview is not displayed @MrRefactor IOS-Distance rate-Keyboard not open/disappear smoothly when selecting default category @kubabutkiewicz

Fixed: IOS - Image preview before sending is not displayed for images from the gallery @MrRefactor iOS - Track expense - App crashes after selecting track expense @MrRefactor iOS - App crashes after selecting a video as the attachment to send @MrRefactor iOS - No image preview on confirmation screen when creating scan request @MrRefactor IOS/Android - Videoplayer controls issue @kubabutkiewicz Android - Expense - Cursor positions behind the currency when editing amount @MrRefactor IOU - Same results appear twice when search email on submit expense modal @kacper-mikolajczak Task – Hidden assignee appears in LHN when assign task without assignee to yourself @kacper-mikolajczak

CC: @mallenexpensify @roryabraham @mountiny @kubabutkiewicz

MrRefactor commented 2 months ago

Update 04.07

PR link -> https://github.com/Expensify/App/pull/40548 PR is ready to be tested/reviewed by C+ PR is under regression testing from QA team

Hey hey,

Working on: -> fixing issues related to strictMode @kubabutkiewicz @kacper-mikolajczak -> Upgrading to rn 0.74.3 @MrRefactor

Bugs status: Work in progress: Android - Composer - Previous text is cut off after creating next line @MrRefactor Android - Composer - Pasted multiline message is displayed in one line @MrRefactor Android - Composer - The suggestion list appears with spacing above the composer @MrRefactor Android - Chat - Green background flickers when dismissing the + modal @kubabutkiewicz @kacper-mikolajczak Android - Expense - App flickers when opening and closing year picker repeatedly @kubabutkiewicz @kacper-mikolajczak Android - Workspace chat avatar preview is not displayed @MrRefactor IOS-Distance rate-Keyboard not open/disappear smoothly when selecting default category @kubabutkiewicz @kacper-mikolajczak

Fixed: IOS - Image preview before sending is not displayed for images from the gallery @MrRefactor iOS - Track expense - App crashes after selecting track expense @MrRefactor iOS - App crashes after selecting a video as the attachment to send @MrRefactor iOS - No image preview on confirmation screen when creating scan request @MrRefactor IOS/Android - Videoplayer controls issue @kubabutkiewicz Android - Expense - Cursor positions behind the currency when editing amount @MrRefactor IOU - Same results appear twice when search email on submit expense modal @kacper-mikolajczak Task – Hidden assignee appears in LHN when assign task without assignee to yourself @kacper-mikolajczak

CC: @mallenexpensify @roryabraham @mountiny @kubabutkiewicz

MrRefactor commented 2 months ago

Update 05.07

PR link -> https://github.com/Expensify/App/pull/40548 PR is ready to be tested/reviewed by C+ PR is under regression testing from QA team

Hey hey,

Working on: -> fixing issues related to strictMode @kubabutkiewicz @kacper-mikolajczak

Work in progress: Android - Composer - Previous text is cut off after creating next line @MrRefactor Android - Composer - Pasted multiline message is displayed in one line @MrRefactor Android - Composer - The suggestion list appears with spacing above the composer @MrRefactor Android - Workspace chat avatar preview is not displayed @MrRefactor

Android - Chat - Green background flickers when dismissing the + modal @kubabutkiewicz @kacper-mikolajczak Android - Expense - App flickers when opening and closing year picker repeatedly @kubabutkiewicz @kacper-mikolajczak IOS-Distance rate-Keyboard not open/disappear smoothly when selecting default category @kubabutkiewicz @kacper-mikolajczak

Fixed: IOS - Image preview before sending is not displayed for images from the gallery @MrRefactor iOS - Track expense - App crashes after selecting track expense @MrRefactor iOS - App crashes after selecting a video as the attachment to send @MrRefactor iOS - No image preview on confirmation screen when creating scan request @MrRefactor IOS/Android - Videoplayer controls issue @kubabutkiewicz Android - Expense - Cursor positions behind the currency when editing amount @MrRefactor IOU - Same results appear twice when search email on submit expense modal @kacper-mikolajczak Task – Hidden assignee appears in LHN when assign task without assignee to yourself @kacper-mikolajczak

CC: @mallenexpensify @roryabraham @mountiny @kubabutkiewicz

MrRefactor commented 2 months ago

Update 08.07

PR link -> https://github.com/Expensify/App/pull/40548 PR is ready to be tested/reviewed by C+ PR is under regression testing from QA team

Hey hey,

Working on: -> fixing issues related to strictMode @kubabutkiewicz @kacper-mikolajczak -> resolving nativeDriver issues & composer issues

Work in progress: Android - Composer - Previous text is cut off after creating next line @MrRefactor Android - Composer - Pasted multiline message is displayed in one line @MrRefactor Android - Composer - The suggestion list appears with spacing above the composer @MrRefactor Android - Workspace chat avatar preview is not displayed @MrRefactor

Android - Chat - Green background flickers when dismissing the + modal @kubabutkiewicz @kacper-mikolajczak Android - Expense - App flickers when opening and closing year picker repeatedly @kubabutkiewicz @kacper-mikolajczak IOS-Distance rate-Keyboard not open/disappear smoothly when selecting default category @kubabutkiewicz @kacper-mikolajczak

Fixed: IOS - Image preview before sending is not displayed for images from the gallery @MrRefactor iOS - Track expense - App crashes after selecting track expense @MrRefactor iOS - App crashes after selecting a video as the attachment to send @MrRefactor iOS - No image preview on confirmation screen when creating scan request @MrRefactor IOS/Android - Videoplayer controls issue @kubabutkiewicz Android - Expense - Cursor positions behind the currency when editing amount @MrRefactor IOU - Same results appear twice when search email on submit expense modal @kacper-mikolajczak Task – Hidden assignee appears in LHN when assign task without assignee to yourself @kacper-mikolajczak

CC: @mallenexpensify @roryabraham @mountiny @kubabutkiewicz

MrRefactor commented 2 months ago

Update 09.07

PR link -> https://github.com/Expensify/App/pull/40548 PR is ready to be tested/reviewed by C+ PR is under regression testing from QA team

Hey hey,

Working on: -> resolving nativeDriver issues @kubabutkiewicz @kacper-mikolajczak -> composer issues on android @MrRefactor

Work in progress: Android - Composer - Previous text is cut off after creating next line @MrRefactor Android - Composer - Pasted multiline message is displayed in one line @MrRefactor Android - Composer - The suggestion list appears with spacing above the composer @MrRefactor Android - Workspace chat avatar preview is not displayed @MrRefactor

Android - Chat - Green background flickers when dismissing the + modal @kubabutkiewicz @kacper-mikolajczak Android - Expense - App flickers when opening and closing year picker repeatedly @kubabutkiewicz @kacper-mikolajczak IOS-Distance rate-Keyboard not open/disappear smoothly when selecting default category @kubabutkiewicz @kacper-mikolajczak

CC: @mallenexpensify @roryabraham @mountiny @kubabutkiewicz

MrRefactor commented 2 months ago

Update 10.07

PR link -> https://github.com/Expensify/App/pull/40548 PR is ready to be tested/reviewed by C+ PR is under regression testing from QA team

Hey hey,

Working on: -> resolving nativeDriver issues android&iOS @kubabutkiewicz @MrRefactor -> composer issues on android @MrRefactor

CC: @mallenexpensify @roryabraham @mountiny @kubabutkiewicz

MrRefactor commented 2 months ago

Update 11.07

PR link -> https://github.com/Expensify/App/pull/40548 PR is ready to be tested/reviewed by C+ PR is under regression testing from QA team

Hey hey,

Working on: -> resolving nativeDriver issues android&iOS @kubabutkiewicz @hurali97 @kacper-mikolajczak -> composer issues on android @MrRefactor @gedu -> Suggestion box issues on android @MrRefactor

CC: @mallenexpensify @roryabraham @mountiny

MrRefactor commented 2 months ago

Update 12.07

PR link -> https://github.com/Expensify/App/pull/40548 PR is ready to be tested/reviewed by C+ PR is under regression testing from QA team

Hey hey,

Working on: -> resolving nativeDriver issues android&iOS @kubabutkiewicz @hurali97 @kacper-mikolajczak -> composer issues on android @MrRefactor @gedu -> Suggestion box issues on android @MrRefactor

CC: @mallenexpensify @roryabraham @mountiny

MrRefactor commented 2 months ago

Update 15.07

PR link -> https://github.com/Expensify/App/pull/40548 PR is ready to be tested/reviewed by C+ PR is under regression testing from QA team

Hey hey,

Working on: -> Upgrading from 0.74.2 -> 0.74.3(removing patches, updating libs) @MrRefactor -> resolving nativeDriver issues android&iOS @kubabutkiewicz @hurali97 @kacper-mikolajczak -> composer issues on android @MrRefactor @gedu -> Suggestion box issues on android @MrRefactor

CC: @mallenexpensify @roryabraham @mountiny

shubham1206agra commented 2 months ago

There's another upgrade PR going on https://github.com/Expensify/App/pull/45289.

cc @roryabraham @mountiny @mallenexpensify

MrRefactor commented 2 months ago

Update 16.07

PR link -> https://github.com/Expensify/App/pull/40548 PR is ready to be tested/reviewed by C+ PR is under regression testing from QA team

Hey hey,

-> Updated from 0.74.2 -> 0.74.3, removed patches for rnmapbox, react-native-plaid-link-sdk, react-native-clipboard

Working on: -> resolving nativeDriver issues android&iOS @kubabutkiewicz @hurali97 -> composer issues on android @MrRefactor @gedu -> Suggestion box issues on android @MrRefactor

Also @j-piasecki @WoLewicki as mentioned on slack, could you help us with bugs mentioned above? CC: @mallenexpensify @roryabraham @mountiny

MrRefactor commented 2 months ago

Update 17.07

PR link -> https://github.com/Expensify/App/pull/40548 PR is ready to be tested/reviewed by C+ PR is under regression testing from QA team

Hey hey,

Working on: -> resolving nativeDriver issues android&iOS @kubabutkiewicz @hurali97 - Kuba was able to reproduce the issue with pure rn project, he will open issue for it soon -> composer issues on android @MrRefactor @gedu - reproduced on rn tester on both 0.74 and 0.75 will open issue for that -> Suggestion box issues on android @MrRefactor -> I have opened 4 PR's as per @roryabraham suggestion to split upgrade pr into smaller pieces with libs bumps:

CC: @mallenexpensify @roryabraham @mountiny

MrRefactor commented 1 month ago

Update 18.07

PR link -> https://github.com/Expensify/App/pull/40548 PR is ready to be tested/reviewed by C+ PR is under regression testing from QA team

Hey hey,

Fixed: -> nativeDriver issues android - patch by @j-piasecki

Working on: -> composer issues on android - link to upstream issue - link -> Suggestion box issues on android @MrRefactor - checking changes between 0.74 and 0.75 as on 0.75 its working fine -> Cursor positions behind the currency when editing amount (android) - @kubabutkiewicz

CC: @mallenexpensify @roryabraham @mountiny

shubham1206agra commented 1 month ago

@roryabraham @mountiny Can we ask @mrousavy to work on bumping react-native-vision-camera to v4.3.2 here to fix the NewArch issue stated here https://github.com/mrousavy/react-native-vision-camera/issues/2614#issuecomment-2166071968?

mrousavy commented 1 month ago

Yea - do you want to just upgrade VisionCamera (ideally to latest), or want me to do that?

MrRefactor commented 1 month ago

Yea - do you want to just upgrade VisionCamera (ideally to latest), or want me to do that?

I would appreciate that @mrousavy

MrRefactor commented 1 month ago

Update 19.07

PR link -> https://github.com/Expensify/App/pull/40548 PR is ready to be tested/reviewed by C+ PR is under regression testing from QA team

Hey hey,

Working on: -> composer issues on android - link to upstream issue - https://github.com/facebook/react-native/issues/45522 @j-piasecki -> Suggestion box issues on android @MrRefactor - checking changes between 0.74 and 0.75 as on 0.75 its working fine -> Cursor positions behind the currency when editing amount (android) - @kubabutkiewicz

CC: @mallenexpensify @roryabraham @mountiny

MrRefactor commented 1 month ago

Update 22.07

PR link -> https://github.com/Expensify/App/pull/40548 PR is ready to be tested/reviewed by C+ PR is under regression testing from QA team New adhoc builds are ready.

Hey hey,

Working on: -> composer issues on android, testing changes in prefabs - link to upstream issue - https://github.com/facebook/react-native/issues/45522 @j-piasecki @MrRefactor -> Suggestion box issues on android @MrRefactor - checking changes between 0.74 and 0.75 as on 0.75 its working fine -> Cursor positions behind the currency when editing amount (android) - @kubabutkiewicz

CC: @mallenexpensify @roryabraham @mountiny

MrRefactor commented 1 month ago

Update 23.07

PR link -> https://github.com/Expensify/App/pull/40548 PR is ready to be tested/reviewed by C+ PR is under regression testing from QA team New adhoc builds are ready.

Hey hey,

Working on: -> composer issues on android(line height and paste from clipboard), testing changes in prefabs - link to upstream issue - https://github.com/facebook/react-native/issues/45522 @j-piasecki @MrRefactor -> Suggestion box issues on android @MrRefactor - checking changes between 0.74 and 0.75 as on 0.75 its working fine

CC: @mallenexpensify @roryabraham @mountiny

MrRefactor commented 1 month ago

Update 24.07

PR link -> https://github.com/Expensify/App/pull/40548 PR is ready to be tested/reviewed by C+ PR is under regression testing from QA team New adhoc builds are ready.

Hey hey,

Working on: -> composer issues on android(line height and paste from clipboard), testing changes in prefabs, applied patch by @j-piasecki , checking if both issues are fixed -> Suggestion box issues on android @MrRefactor - checking changes between 0.74 and 0.75 as on 0.75 its working fine

CC: @mallenexpensify @roryabraham @mountiny

MrRefactor commented 1 month ago

Update 25.07

PR link -> https://github.com/Expensify/App/pull/40548 PR is ready to be tested/reviewed by C+ PR is under regression testing from QA team New adhoc builds are ready.

Hey hey,

Working on: -> Suggestion box issues on android @MrRefactor & @kubabutkiewicz - checking changes between 0.74 and 0.75 as on 0.75 its working fine

CC: @mallenexpensify @roryabraham @mountiny

MrRefactor commented 1 month ago

Update 26.07

PR link -> https://github.com/Expensify/App/pull/40548

New adhoc builds are ready -> link

Hey hey,

New adhoc builds are ready to be tested!

Working on: -> Suggestion box issues on android @MrRefactor & @kubabutkiewicz - checking changes between 0.74 and 0.75 as on 0.75 its working fine

CC: @mallenexpensify @roryabraham @mountiny

MrRefactor commented 1 month ago

Update 29.07

PR link -> https://github.com/Expensify/App/pull/40548

New adhoc builds are ready -> https://github.com/Expensify/App/pull/40548#issuecomment-2252822245

Hey hey,

Working on: -> Suggestion box issues on android @MrRefactor & @kubabutkiewicz - checking changes between 0.74 and 0.75 as on 0.75 its working fine -> Attachment - Opening attachments takes you back to the first attachment - there is an issue with opening attachment, checking it

CC: @mallenexpensify @roryabraham @mountiny

MrRefactor commented 1 month ago

Update 30.07

PR link -> https://github.com/Expensify/App/pull/40548

New adhoc builds are ready -> https://github.com/Expensify/App/pull/40548#issuecomment-2252822245

Hey hey,

Working on: -> Suggestion box issues on android @MrRefactor & @kubabutkiewicz - checking changes between 0.74 and 0.75 as on 0.75 its working fine -> Attachment - Opening attachments takes you back to the first attachment - there is an issue with opening attachment, checking it, most likely connected with reanimated -> Expense - Incorrect currency is displayed when creating an Expense Request in WS -> most likely regression from main, checking -> Members - Application crashes when scrolling through the "Invite new members" list in WS - every SelectionList component in the app is crashing while opening, seems like its connected to wrong parsing of users with emojis in their names, checking previous builds if its regression from main or not.

CC: @mallenexpensify @roryabraham @mountiny

MrRefactor commented 1 month ago

Update 31.07

PR link -> https://github.com/Expensify/App/pull/40548

New adhoc builds are ready -> https://github.com/Expensify/App/pull/40548#issuecomment-2252822245

Hey hey,

Fixed: -> Attachment - Opening attachments takes you back to the first attachment -> Expense - Incorrect currency is displayed when creating an Expense Request in WS -> Members - Application crashes when scrolling through the "Invite new members" list in WS

Working on: -> Suggestion box issues on android @MrRefactor & @kubabutkiewicz - checking changes between 0.74 and 0.75 as on 0.75 its working fine

CC: @mallenexpensify @roryabraham @mountiny

MrRefactor commented 1 month ago

Update 01.08

PR link -> https://github.com/Expensify/App/pull/40548

New adhoc builds are ready -> https://github.com/Expensify/App/pull/40548#issuecomment-2252822245

Hey hey,

Upgraded rn to 0.74.4, applied fixes for CI

Working on: -> Suggestion box issues on android @perunt

CC: @mallenexpensify @roryabraham @mountiny

MrRefactor commented 1 month ago

Update 05.08

PR link -> https://github.com/Expensify/App/pull/40548

Hey hey,

Updated patches for expo related to hybrid app setup, I have also implemented a workaround solution to fix suggestion box issue before 0.75 is merged. With that I think we are ready to merge?

CC: @mallenexpensify @roryabraham @mountiny

MrRefactor commented 1 month ago

Update 07.08

PR link -> https://github.com/Expensify/App/pull/40548 Fresh builds -> https://github.com/Expensify/App/pull/40548#issuecomment-2273386021

Hey hey,

Added workaround for suggestion list by @perunt

We are ready regression testing, also @staszekscp reported issues with building HybridApp, he will look into that as per: https://github.com/Expensify/App/pull/40548#issuecomment-2272724454

CC: @mallenexpensify @roryabraham @mountiny @AndrewGable

staszekscp commented 3 weeks ago

Hey! 👋 I'll be working on the upgrade with @WoLewicki starting today!

roryabraham commented 1 week ago

Thanks for all the work here. as is clear by all the PRs linked above we're in the cleanup phase, upgrading dependencies and removing patches

shubham1206agra commented 1 week ago

@roryabraham Can you add labels for payment?

melvin-bot[bot] commented 5 days ago

Triggered auto assignment to @dylanexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

melvin-bot[bot] commented 5 days ago

Job added to Upwork: https://www.upwork.com/jobs/~021833172516619025999

melvin-bot[bot] commented 5 days ago

Current assignee @shubham1206agra is eligible for the External assigner, not assigning anyone new.

melvin-bot[bot] commented 5 days ago

Upwork job price has been updated to $750

melvin-bot[bot] commented 5 days ago

Upwork job price has been updated to $1000

mountiny commented 5 days ago

@dylanexpensify This is ready to be paid out to @shubham1206agra for their help on this one and previously with the 0.74

I think $1000 is fair reward for their testing and code review as well as help with follow ups. Let me know if you disagree

MuhammadIqbalDev commented 5 days ago

Hi,

The issue likely stems from architectural changes in React Native 0.74+ that are incompatible with your current codebase. The need for patches suggests that your existing setup is not fully aligned with the new architecture, which could introduce bugs, performance regressions, or maintainability challenges. Without upgrading, you may face technical debt, increased complexity, and potential conflicts with future React Native updates.

One possible short-term fix can be applying specific patches with patch-package to replace modules or dependencies that are not compatible, giving alternative solutions for outdated APIs or components. This enables the project to operate without updating while addressing immediate problems. To achieve a lasting fix, transition completely to React Native 0.74+, restructure code to match the new design, verify third-party libraries work well, and conduct thorough testing to prevent any setbacks or additional issues. This will make the project future-proof, get rid of technical debt, and guarantee long-term stability.

Best Muhammad

melvin-bot[bot] commented 5 days ago

📣 @MuhammadIqbalDev! 📣 Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:

Make sure you've read and understood the contributing guidelines.
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details. Format:
```
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
```

dylanexpensify commented 5 days ago

Payment summary:

Contributor+: @shubham1206agra $1000

Please apply/request!

shubham1206agra commented 5 days ago

@dylanexpensify You need to send me an offer through Upwork.

dylanexpensify commented 5 days ago

@shubham1206agra https://www.upwork.com/jobs/~021833459090006846967

Expensify / App