Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.33k stars 2.76k forks source link

[$500] Web - Workspace - It's not accepting the SSN for the first time #37442

Closed lanitochka17 closed 6 months ago

lanitochka17 commented 6 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.44.0 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:

Issue found when executing PR https://github.com/Expensify/App/pull/29991

Action Performed:

  1. Login with expensify account
  2. Go to Settings > Wallet > Enable Wallet
  3. Go through Chase plaid verification flow
  4. Follow the flow until Additional details
  5. Fill the form with following data: First name: Alberta Last name: Bobbeth SSN: 3333 Any other information for the rest of the fields
  6. Press Save & continue

Expected Result:

It should accept it

Actual Result:

It's not accepting the SSN for the first time. I can continue after clicking on the button again

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/7bfe9fc6-1d06-441a-9a09-f6a24721cc11

View all open jobs on GitHub

melvin-bot[bot] commented 6 months ago

Job added to Upwork: https://www.upwork.com/jobs/~019098329cb3e1ec5a

melvin-bot[bot] commented 6 months ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)

github-actions[bot] commented 6 months ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
melvin-bot[bot] commented 6 months ago

Triggered auto assignment to @roryabraham (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

puneetlath commented 6 months ago

I talked to @joekaufmanexpensify and we don't think this should block the deploy given it's current usage. But let's definitely get it fixed.

melvin-bot[bot] commented 6 months ago

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

damadoko commented 6 months ago

I think the bug came from BE, the error was retrived from UpdatePersonalDetailsForWallet.

roryabraham commented 6 months ago

@lanitochka17 the email of the account the bug occurred on would be helpful here. Managed to see from the video that it's

applausetester+0227rbt@applause.expensifail.com

roryabraham commented 6 months ago

not able to find any logs for that account in a 72 hour period surrounding this issue's creation 😕

https://staging.expensify.com/_devportal/tools/logSearch/#sort=asc&size=10000&query=email%3A%22applausetester%2B0227rbt%40applause.expensifail.com%22%20AND%20timestamp%3A%5B2024-02-27T00%3A00%20TO%202024-02-29T23%3A59%5D

roryabraham commented 6 months ago

typo, it's +rb2 not +rbt

roryabraham commented 6 months ago

found logs, looks like an Idology error

roryabraham commented 6 months ago

Using mock Idology ExpectID API response

(throws error response)

lol

roryabraham commented 6 months ago

this is a fun gotcha. The Idology ExpectID mock is set up to fail if the last name of the user matches the middle name (just because we needed a way to test failure scenarios in the mock).

In this case, you used Bobbeth for the last name on this request, which caused that to fail.

So all this is expected behavior.