search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.56k stars 2.9k forks source link

Deploy Checklist: New Expensify 2024-02-28 #37459

Closed github-actions[bot] closed 8 months ago

github-actions[bot] commented 8 months ago

Release Version: 1.4.45-6 Compare Changes: https://github.com/Expensify/App/compare/production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

cc @Expensify/applauseleads

OSBotify commented 8 months ago

:rocket: All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.4.45-0 :rocket:

melvin-bot[bot] commented 8 months ago

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

kavimuru commented 8 months ago

Regression is 5% left.

37438 failing with KI #37363 not yet fixed. Please see the comment https://github.com/Expensify/App/pull/37438#issuecomment-1971393124. Checking it off

37402 failing with 37511

37285 failing with #37465

34646 failing with #37463

34168 failing with #36342 repro in production, checking it off

32678 failing with #37469

luacmartins commented 8 months ago

Checking off https://github.com/Expensify/App/issues/37508. Demoted

puneetlath commented 8 months ago

@kavimuru we CP'd this revert: https://github.com/Expensify/App/pull/37529

Could you re-test these? The revert is live on v1.4.45-2 https://github.com/Expensify/App/issues/37473 https://github.com/Expensify/App/issues/37488 https://github.com/Expensify/App/issues/37489 https://github.com/Expensify/App/issues/37491 https://github.com/Expensify/App/issues/37492 https://github.com/Expensify/App/issues/37523

kavimuru commented 8 months ago

37491 and #37492 are still reproducible.

37488 step 6 still fails. (Not sure if this is expected)

37473, #37489 and #37523 are not reproducible

Videos for the bugs reproducible:

https://github.com/Expensify/App/assets/43996225/587d35a5-16c3-4446-ab35-1f88958064fc https://github.com/Expensify/App/assets/43996225/0af6bf02-caef-4a07-9eea-879824a662ac https://github.com/Expensify/App/assets/43996225/c5325333-eb1c-4cbc-8804-b1e4adadb032

puneetlath commented 8 months ago

Great, thank you!

puneetlath commented 8 months ago

For https://github.com/Expensify/App/issues/37488 I think being able to split a bill with one user is correct, so I'm going to mark that one off.

kavimuru commented 8 months ago

@puneetlath Regression is completed.

Unchecked PRs:

32678 failing with #37469

37402 failing with #37511

37285 failing with #37465

34646 failing with #37463

32678 failing with #37469

37136 failing with #37469

36850 - in desktop navigating to web and correct message is displayed. Seems expected. Should we report it as a bug? Other platforms are pass.

37160 failing with Known bug #36267 and not fixed. Please see comment - Checking off

37133 failing with #37569

Open Blockers:

37569

37472

37466

puneetlath commented 8 months ago

https://github.com/Expensify/App/pull/36850 - in desktop navigating to web and correct message is displayed. Seems expected. Should we report it as a bug? Other platforms are pass.

I agree that sounds like the correct behavior. Going to check it off.

puneetlath commented 8 months ago

:shipit: