[HOLD for payment 2024-05-06] [HIGH] [Splits][$500] Split - Group chat is missing everywhere when created via FAB and bill is split in group chat

m-natarajan commented 7 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v1.4.45-1

Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause internal team Slack conversation:

Action Performed:

Go to staging.new.expensify.com
Click FAB > Request money > Manual.
Click a split bill with two users that have no prior chat via FAB.
Navigate to a different chat.
Note that the group chat remains in LHN and appears in Search.
Go to FAB > Start chat.
Create a group chat with two users that have no prior chat.
In the group chat, click + > Split bill.
Create a bill split.
Go to a different chat.
Open Search.
Expected Result:

The group chat will remain in LHN and appear in Search list.

Actual Result:

The group chat disappears from LHN and is missing in Search list. This issue only happens when user creates a group chat first, then splits bill in the group chat (Step 6 - 11). The only way to retrieve the group chat is by recreating it.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos

https://github.com/Expensify/App/assets/38435837/87159b78-56c6-46d5-a8ef-62a010e870e6

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~016f541763635e6d84
Upwork Job ID: 1767854808847859712
Last Price Increase: 2024-03-13
Automatic offers:

mkhutornyi | Contributor | 0
bernhardoj | Contributor | 0

Issue Owner

Current Issue Owner: @mananjadhav

dylanexpensify commented 5 months ago

waiting for deploy to prod -> regression period

bernhardoj commented 5 months ago

We have a regression because looks like participants contains the current user ID, so we need to filter it out. The PR is ready to fix ti.

cc: @mananjadhav

mananjadhav commented 5 months ago

Taking a look.

melvin-bot[bot] commented 5 months ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 5 months ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.67-7 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/40271

If no regressions arise, payment will be issued on 2024-05-06. :confetti_ball:

For reference, here are some details about the assignees on this issue:

@mananjadhav requires payment through NewDot Manual Requests
@bernhardoj requires payment automatic offer (Contributor)

melvin-bot[bot] commented 5 months ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@mananjadhav] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@mananjadhav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@mananjadhav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@mananjadhav] Determine if we should create a regression test for this bug.
[ ] [@mananjadhav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ] [@dylanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

dylanexpensify commented 5 months ago

Payment coming up!

dylanexpensify commented 4 months ago

Payment summary:

Contributor: @bernhardoj $250
Contributor+: @mananjadhav $250

Please apply/request!

dylanexpensify commented 4 months ago

@bernhardoj paid out! @mananjadhav to request, closing issue

dylanexpensify commented 4 months ago

JK - we need @mananjadhav to give regression step proposal

mananjadhav commented 4 months ago

@dylanexpensify Shouldn't a regression test exist already for group chat in LHN? If they don't we can use the steps mentioned below.

These are the test steps.

Create a new group chat with user that is not in your contacts
Create a new split bill
(Web/Desktop) Switch to another chat (Android/iOS/mWeb) Close the group chat
Verify the group chat is still shown in LHN
Go to search page and verify the group chat is shown

mananjadhav commented 4 months ago

Quick bump @dylanexpensify

JmillsExpensify commented 4 months ago

$250 approved for @mananjadhav

lanitochka17 commented 4 months ago

Do we need to open a new bug or is it the same one? The tester was able to reproduce this issue again.

https://github.com/Expensify/App/assets/78819774/a35ef934-918a-4c70-9e44-87c67d150f72

mananjadhav commented 4 months ago

We had fixed this for Split bill and group chat. But in the new video I can see you're trying Submit expense on DM. Could be a separate issue.

dylanexpensify commented 4 months ago

Agree, @lanitochka17 separate issue

Expensify / App