Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.19k stars 2.66k forks source link

[Awaiting Payment 29th May] [$500] Wrong message appears when the Expensify site is going down #37565

Closed m-natarajan closed 2 months ago

m-natarajan commented 5 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @flodnv Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1709063517335079

Action Performed:

  1. Open any chat or go to sign in page when the site is down

Expected Result:

When the site is down we should show: We might have a problem. Check out status.expensify.com.

Actual Result:

You appear to be offline appears confusing the user that they have a network problem when really it's the site.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

image

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01ed912188740cf497
  • Upwork Job ID: 1764575263440932864
  • Last Price Increase: 2024-04-24
trjExpensify commented 4 months ago

PR is in draft, Melv.

tienifr commented 4 months ago

PR ready for review https://github.com/Expensify/App/pull/38377.

cubuspl42 commented 3 months ago

I'm finishing the review

melvin-bot[bot] commented 3 months ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (External)

melvin-bot[bot] commented 3 months ago

Upwork job price has been updated to $500

mallenexpensify commented 3 months ago

@DylanDylann reassigning, please take over as C+. If you don't have bandwidth, unassign yourself. Thanks. PR is here:

DylanDylann commented 3 months ago

Thanks. reviewing today

melvin-bot[bot] commented 3 months ago

@trjExpensify, @aldo-expensify, @tienifr, @DylanDylann Whoops! This issue is 2 days overdue. Let's get this updated quick!

trjExpensify commented 3 months ago

I've assigned you to the PR @DylanDylann. @tienifr there are conflicts here.

melvin-bot[bot] commented 2 months ago

@trjExpensify, @aldo-expensify, @tienifr, @DylanDylann Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] commented 2 months ago

@trjExpensify, @aldo-expensify, @tienifr, @DylanDylann 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

melvin-bot[bot] commented 2 months ago

@trjExpensify, @aldo-expensify, @tienifr, @DylanDylann Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

trjExpensify commented 2 months ago

Hit staging yesterday melv, chill.

flodnv commented 2 months ago

I did notice the change working last week 😅 👍 🙇

mvtglobally commented 2 months ago

Issue not reproducible during KI retests. (First week)

melvin-bot[bot] commented 2 months ago

@trjExpensify, @aldo-expensify, @tienifr, @DylanDylann Whoops! This issue is 2 days overdue. Let's get this updated quick!

trjExpensify commented 2 months ago

Not overdue, Melv. Awaiting payment on the 29th.

trjExpensify commented 2 months ago

Payment summary for tomorrow as follows:

mvtglobally commented 2 months ago

Issue not reproducible during KI retests. (Second week)

trjExpensify commented 2 months ago

Offers sent!

tienifr commented 2 months ago

Thanks @trjExpensify I accepted the offer!

trjExpensify commented 2 months ago

Paid, @tienifr! @DylanDylann, I think you need to accept? 🤔

DylanDylann commented 2 months ago

@trjExpensify Accepted! Thanks

trjExpensify commented 2 months ago

Paid!