[HOLD] Implement Android conversation notifications

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.

https://new.expensify.com

MIT License

3.11k stars 2.61k forks source link

[HOLD] Implement Android conversation notifications #37604

Open arosiclair opened 4 months ago

arosiclair commented 4 months ago

In Android 11, conversation notifications were added that offer a richer notification experience for messaging.

conv_notification

Conversation notifications are placed highest in the notification shade and prominently display avatars and names with the app's logo in the corner. Individual notifications can be marked as a priority allowing them to cut through Do Not Disturb settings. This is very similar to communication notifications which we implemented for iOS here.

Android docs

melvin-bot[bot] commented 4 months ago

Triggered auto assignment to @bfitzexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

arosiclair commented 4 months ago

FYI this is a copy of the old internal issue here: https://github.com/Expensify/Expensify/issues/258528

arosiclair commented 4 months ago

From the docs, we need to implement these to get conversation notifications

[x] The notification uses MessagingStyle.
- [ ] (Only if the app targets Android 11 or higher) The notification is associated with a valid long-lived dynamic or cached sharing shortcut. The notification can set this association by calling setShortcutId() or setShortcutInfo(). If the app targets Android 10 or lower, the notification doesn't have to be associated with a shortcut, as discussed in the fallback options section.

Which means we should just need to implement sharing shortcuts. I'm going to look for a contributor to work on this.

@robertKozik you worked on our last issue for clearing notifications on Android. Would you be interested in working on this as well?

staszekscp commented 4 months ago

Hey @arosiclair! I can take care of this feature, because currently I work on the HybridApp, where we will refactor notifications in order to make sure they work for both OldDot, and NewDot. However, could we slightly wait with implementation of this feature? I just want to make sure that the notifications work fine after the refactor, and then, as a follow-up, I will add the conversation notifications on Android.

arosiclair commented 4 months ago

Makes sense I'll assign you and put this on hold. Keep us updated 🙏

bfitzexpensify commented 3 months ago

Still held @staszekscp?

arosiclair commented 3 months ago

Still held I believe. cc @staszekscp for any updates

staszekscp commented 3 months ago

Hey! Sorry, I missed the previous comment - the PR with the refactor is open, I just have to find one fix for a bug that I noticed. After merging I will work on this issue - I have already done some small testing, and I think I know what needs to be done 😄

bfitzexpensify commented 2 months ago

Still held on https://github.com/Expensify/Mobile-Expensify/pull/12610

bfitzexpensify commented 2 months ago

Remains held

bfitzexpensify commented 2 months ago

Stil held on https://github.com/Expensify/Mobile-Expensify/pull/12610

arosiclair commented 2 months ago

Asked for an update on the PR. Still held for now.

bfitzexpensify commented 1 month ago

Still held.

bfitzexpensify commented 1 month ago

Still held, but the latest comment in that PR indicates we're getting closer:

Seems like we need to merge main, but probably also fix New Arch + iOS still, so this is close to being ready for a merge

bfitzexpensify commented 1 month ago

Still held.

arosiclair commented 3 weeks ago

Haven't been able to make progress in the last couple months. Dropping this to monthly.