Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.33k stars 2.76k forks source link

BA - User can continue the flow with wrong account number, then error appears on other page #37730

Closed izarutskaya closed 5 months ago

izarutskaya commented 6 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.4.47-0 Reproducible in staging?: Y Reproducible in production?: Not able to test on production Email or phone of affected tester (no customers): applausetestervd_mweb030424@applause.expensifail.com Logs: https://stackoverflow.com/c/expensify/questions/4856 Issue reported by: Applause-Internal Team

Action Performed:

Pre-requisite: the user must be logged in and have created a Workspace.

  1. Go to Workspace > Bank account.
  2. Tap on Connect with Plaid.
  3. Select Chase bank and use the testing credentials.
  4. Select the account ending with 1111.
  5. Enter "011401533" as the Routing number.
  6. Enter "1111" as Account number.
  7. Verify you can continue the add BA flow.
  8. Reach the double check Company information page.
  9. Tap on "Confirm".
  10. Verify you see an error is displayed.
  11. Tap on "fix the errors".
  12. Verify nothing happens.

Expected Result:

The user should not be able to continue the flow if the account number entered is incomplete or wrong.

Actual Result:

The user is able to continue the flow with incomplete account number, then an error appears on the double check Company information page.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

https://github.com/Expensify/App/assets/115492554/6229d4e9-3fcf-4782-910b-82848fa95098

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01e89faf072ebd1655
  • Upwork Job ID: 1765013045602160640
  • Last Price Increase: 2024-03-05
melvin-bot[bot] commented 6 months ago

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

github-actions[bot] commented 6 months ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
melvin-bot[bot] commented 6 months ago

Triggered auto assignment to @cristipaval (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

izarutskaya commented 6 months ago

@cristipaval I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

nkuoch commented 6 months ago

I'll fix it myself

cristipaval commented 6 months ago

This is reproducible in production as well. Tested with 1.4.46-2

cristipaval commented 6 months ago

Thanks @nkuoch!

shubham1206agra commented 6 months ago

@nkuoch If you want, I can help you here as this is probably coming from VBBA refactor

melvin-bot[bot] commented 6 months ago

Job added to Upwork: https://www.upwork.com/jobs/~01e89faf072ebd1655

melvin-bot[bot] commented 6 months ago

Triggered auto assignment to Contributor Plus for review of internal employee PR - @aimane-chnaif (Internal)

nkuoch commented 6 months ago

This will be a BE PR, no need for contributor plus

melvin-bot[bot] commented 5 months ago

This issue has not been updated in over 15 days. @nkuoch, @kadiealexander eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

trjExpensify commented 5 months ago

@kadiealexander as a bug that doesn't block the release, I'm moving this to Polish. That said, is the PR done here?

kadiealexander commented 5 months ago

Yeah it is, weird this didn't close. Closing as complete, thanks @trjExpensify!